aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2015-10-26gme: don't loop forever, fall back to GME's default play lengthMax Kellermann1-3/+3
Fixes http://bugs.musicpd.org/view.php?id=4432
2015-10-26decoder/gme: free the gme_info_t as early as possibleMax Kellermann1-6/+7
2015-10-26decoder/gme: call decoder_seek_error() on seek errorMax Kellermann1-2/+4
2015-10-26output/Command: flush the mixer cache when enabling/disabling outputMax Kellermann1-0/+8
Fixes mixer lag (http://bugs.musicpd.org/view.php?id=4425).
2015-10-26decoder/ffmpeg: fix crash due to wrong avio_alloc_context() callMax Kellermann1-4/+13
Allocate the buffer dynamically using av_malloc(), and free AVIOContext.buffer in the destructor, as mandated by the libavformat documentation. Fixes http://bugs.musicpd.org/view.php?id=4446
2015-10-16decoder/mpcdec: use SampleTraits<SampleFormat::S24_P32>Max Kellermann1-11/+13
Eliminates some duplicate code, and as a side effect, this works around clang 3.8 compiler warning because a negative value was shifted.
2015-10-16decoder/mpcdec: use Clamp()Max Kellermann1-6/+2
2015-10-16unix/Daemon, playlist/...: remove unused Domain variablesMax Kellermann7-21/+0
2015-10-16encoder/flac: fix crash with 32 bit playbackMax Kellermann1-2/+2
Copy to encoder->audio_format *after* adjusting the sample format to S24_P32. Fixes http://bugs.musicpd.org/view.php?id=4433
2015-10-16tag/ApeLoader: fix buffer overflow after unterminated keyMax Kellermann1-6/+6
2015-06-21PlayerThread: start the decoder on PlayerCommand::QUEUEMax Kellermann1-0/+6
Fixes missing SongBorder() call, which causes "single" mode breakage.
2015-06-21DecoderAPI: discard unused song tag earlyMax Kellermann1-2/+5
If there's a stream tag, don't let the song tag override it in the next update_stream_tag() call.
2015-06-21DecoderThread: set Decoder::song_tag only for local filesMax Kellermann1-1/+5
If the song tag comes from a stream, and MPD playback restarts, MPD would believe the tag should override the newly received tag. This makes the previous tag appear stuck. This change passes the song tag only if it's authoritative - i.e. if it's a song file.
2015-06-20DecoderAPI: "move" the Tag objectMax Kellermann1-1/+1
Reduce runtime overhead.
2015-06-20OutputControl: fix fail_timer check right after bootingRomain Rollet1-1/+2
Right after booting, the monotonic clock starts with a very small value, and AudioOutput::LockUpdate() may believe that the fail_timer has not recovered yet.
2015-06-20system/PeriodClock: make IsDefined() "constexpr"Max Kellermann1-1/+1
2015-06-20decoder/ffmpeg: skip unwanted samples after seekingMax Kellermann1-5/+48
When seeking to the beginning of a packet, skip the samples that come before the desired time stamp.
2015-06-20decoder/ffmpeg: use AVSEEK_FLAG_BACKWARD for seekingMax Kellermann1-1/+5
Ask FFmpeg to seek to the next packet boundary *before* the seek position, so we don't miss audio data. Now we get too much, but we'll solve that in the next commit.
2015-06-19decoder/ffmpeg: move code to StreamRelativePts()Max Kellermann1-6/+20
2015-06-19input/curl: trigger the condition variable in RequestDone()Max Kellermann1-0/+2
Fixes deadlock on small responses.
2015-05-29storage/nfs: fix deadlock when connectingThomas Guillem1-2/+2
The Connect method can be called between Schedule and lock. In that case, when locked, the state is already set to CONNECTING of READY and the condition won't be signaled anymore.
2015-05-29input/smbclient: fix DFF playbackjai1-0/+1
2015-03-25OpusEncoderPlugin: initialise granulepos so we end up with sane valuesMichal Nazarewicz1-1/+1
Not initialising granulepos leads to it having arbitrary values in the encoded stream including possibly negative values which are not valid and confuse opusdec. Explicitly initialise opus_encoder::granulepos to avoid that problem.
2015-02-06fs/io/FileOutputStream: don't auto-delete file on WIN32Max Kellermann1-0/+2
The file handle is never reset to INVALID_HANDLE_VALUE, and thus the destructor will assume the operation shall be cancelled and will delete the temporary file. This was a major breakage for saving the database file and the state file.
2015-02-06TagBuilder: allow adding duplicate tag types in Complement()Max Kellermann1-1/+10
Build a table of pre-existing tag types before adding new items. The old way would check HasType() each time, which would return true after the first instance of that tag type had been added, preventing duplicate tag types to be merged. This broke duplicate tag types loaded from the state file, because this code path uses TagBuilder::Complement().
2015-01-29db/update/Walk: use std::unique_ptr instead of std::auto_ptrMax Kellermann1-1/+1
std::auto_ptr is deprecated, and std::unique_ptr is much better anyway.
2015-01-29Avoid integer overflow in MonotonicClock{S,MS,US}PHO1-6/+6
This is Darwin specific: the previous implementation was causing an integer overflow when base.numer is very large. On PPC Darwin, the timebase info is 1000000000/33330116 and this is too large for integer arithmetic.
2015-01-29Avoid integer overflow in MonotonicClock{S,MS,US}PHO1-4/+4
This is Darwin specific: the previous implementation was causing an integer overflow when base.numer is very large. On PPC Darwin, the timebase info is 1000000000/33330116 and this is too large for integer arithmetic.
2015-01-29decoder/DsdLib: use new[] to allocate the ID3 bufferMax Kellermann1-3/+5
Don't abort the process if there's not enough memory. This buffer is not important and can be large.
2015-01-29decoder/DsdLib: free ID3 buffer right after id3_tag_parse()Max Kellermann1-5/+2
Merge two free() calls.
2015-01-29decoder/DsdLib: raise ID3 tag limit to 1 MBMax Kellermann1-1/+1
A bug report was submitted with a 600 kB ID3 tag that could not be read by MPD.
2015-01-26Test the existence of strndup(3) before using it.PHO1-5/+6
This can eliminate the ad-hoc "#ifdef WIN32" and can also support other platforms lacking it as well (including Darwin 9).
2015-01-26{playlist,input}/despotify: remove defunct pluginMax Kellermann9-668/+0
2015-01-23util/list: disable gcc5 warningMax Kellermann1-0/+4
This file has been removed in newer MPD versions, so don't care about it now.
2015-01-23ClientProcess: cast enum to int before passing to printf()Max Kellermann1-3/+3
Fixes gcc5 warning.
2015-01-21thread/Name: include stdio.h if HAVE_PRCTLMax Kellermann1-1/+4
Caused a build failure with uClibc because snprintf() was not available.
2015-01-06input/async: reset the "open" flag after seeking successfullyMax Kellermann1-0/+5
Fixes a problem with the "curl" input plugin: IsEOF() always returns true because the "open" flag was cleared by CurlInputStream::RequestDone() when end-of-stream was reached. This flag stays false even when seeking to another position has succeeded. This patch resets the "open" flag to true after seeking successfully.
2015-01-06thread/Name: disable pthread_setname_np() on NetBSDMax Kellermann1-2/+6
NetBSD's pthread_setname_np() prototype is incompatible with the rest of the world, and it requires to pass the string argument as a non-const pointer. Instead of working around this misdesign, I hereby disable the feature on NetBSD.
2015-01-06thread/Name: enable FormatThreadName() with prctl()Max Kellermann1-1/+5
Add macro HAVE_THREAD_NAME which is set when any method to set the thread name is available. Use that macro in FormatThreadName() instead of just checking for HAVE_PTHREAD_SETNAME_NP.
2015-01-06thread/Name: indent preprocessor commandsMax Kellermann1-3/+3
2014-12-26db/simple: fix implicit nullptr/bool conversionMax Kellermann3-5/+5
Return false on error, not nullptr.
2014-12-26fs/Traits, ...: work around -Wtautological-pointer-compareMax Kellermann5-1/+32
New in clang 3.6.
2014-12-26db/lazy, input/mms: add "override" keywordsMax Kellermann3-4/+6
Fixes -Winconsistent-missing-override (clang 3.6).
2014-12-26db/proxy, output/shout: fix implicit nullptr/bool conversionMax Kellermann2-4/+4
Return false on error, not nullptr.
2014-12-26db/{simple,proxy}, ...: add "override" keywordsMax Kellermann7-22/+26
Fixes -Winconsistent-missing-override (clang 3.6).
2014-12-26util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compareMax Kellermann10-0/+51
New in clang 3.6.
2014-12-26DatabaseGlue: convert nullptr check to assertionMax Kellermann1-3/+2
2014-12-26util/ASCII: fix indentMax Kellermann1-10/+10
2014-12-26Compiler.h: add macro CLANG_CHECK_VERSION()Max Kellermann1-0/+7
2014-12-26Compiler.h: add macro GCC_OLDER_THAN()Max Kellermann2-4/+12