Commit message (Collapse) | Author | Files | Lines | ||
---|---|---|---|---|---|
2015-01-29 | Avoid integer overflow in MonotonicClock{S,MS,US} | PHO | 1 | -4/+4 | |
This is Darwin specific: the previous implementation was causing an integer overflow when base.numer is very large. On PPC Darwin, the timebase info is 1000000000/33330116 and this is too large for integer arithmetic. | |||||
2015-01-26 | {playlist,input}/despotify: remove defunct plugin | Max Kellermann | 9 | -668/+0 | |
2015-01-23 | util/list: disable gcc5 warning | Max Kellermann | 1 | -0/+4 | |
This file has been removed in newer MPD versions, so don't care about it now. | |||||
2015-01-23 | ClientProcess: cast enum to int before passing to printf() | Max Kellermann | 1 | -3/+3 | |
Fixes gcc5 warning. | |||||
2014-12-26 | db/proxy, output/shout: fix implicit nullptr/bool conversion | Max Kellermann | 2 | -4/+4 | |
Return false on error, not nullptr. | |||||
2014-12-26 | db/{simple,proxy}, ...: add "override" keywords | Max Kellermann | 7 | -22/+26 | |
Fixes -Winconsistent-missing-override (clang 3.6). | |||||
2014-12-26 | util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compare | Max Kellermann | 10 | -0/+51 | |
New in clang 3.6. | |||||
2014-12-26 | DatabaseGlue: convert nullptr check to assertion | Max Kellermann | 1 | -3/+2 | |
2014-12-26 | util/ASCII: fix indent | Max Kellermann | 1 | -10/+10 | |
2014-12-26 | Compiler.h: add macro CLANG_CHECK_VERSION() | Max Kellermann | 1 | -0/+7 | |
2014-12-26 | Compiler.h: add macro GCC_OLDER_THAN() | Max Kellermann | 2 | -4/+12 | |
2014-12-26 | util/Manual: reimplement GCC_CHECK_VERSION() using GCC_MAKE_VERSION() | Max Kellermann | 1 | -4/+3 | |
2014-12-26 | Compiler.h: add macro GCC_MAKE_VERSION() | Max Kellermann | 1 | -6/+4 | |
2014-12-16 | playlist/embcue: fix filename suffix detection | k44 | 1 | -1/+1 | |
The definition of the playlist_plugin struct member of the embcue plugin was incorrect. | |||||
2014-12-15 | decoder/ffmpeg: detect and fix negative time stamps | Max Kellermann | 1 | -4/+7 | |
Works around assertion failure due to something that appears to be a (minor) FFmpeg bug. | |||||
2014-12-08 | decoder/ffmpeg: support FFmpeg 2.5 | Max Kellermann | 1 | -0/+5 | |
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough. | |||||
2014-12-08 | thread/Id: drop "::" prefix before pthread function names | Max Kellermann | 1 | -2/+2 | |
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl). | |||||
2014-11-24 | archive/zzip: fix inverted error handler | Max Kellermann | 1 | -4/+5 | |
Set the Error when zzip_seek()==-1 and not on success. Fixes a crash after seeking. | |||||
2014-11-18 | Client: assume uid==0 is local socket | Max Kellermann | 2 | -2/+2 | |
A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected. | |||||
2014-11-18 | event/ServerSocket: fix get_remote_uid() error value | Max Kellermann | 1 | -1/+1 | |
Must return -1 on error, not 0. 0 is root. | |||||
2014-11-11 | Construct a Null AllocatedPath if the filename conversion into UTF8 failed | Florent Le Coz | 1 | -1/+5 | |
2014-11-10 | decoder/ffmpeg: support opus | Max Kellermann | 1 | -1/+2 | |
2014-11-02 | input/curl: fix curl_easy_setopt() parameter types | Max Kellermann | 1 | -4/+4 | |
2014-11-02 | Decoder, Playlist: ignore URI query string for plugin detection | Max Kellermann | 2 | -6/+8 | |
Use the new uri_get_suffix() overload that removes the query string. | |||||
2014-11-02 | util/UriUtil: add uri_get_suffix() overload that ignores query string | Max Kellermann | 2 | -0/+28 | |
2014-11-02 | PlaylistFile: don't allow empty playlist name | Max Kellermann | 1 | -0/+4 | |
2014-11-02 | playlist/m3u: recognize the file suffix ".m3u8" | Max Kellermann | 2 | -1/+3 | |
2014-11-02 | decoder/faad: remove workaround for ancient libfaad2 ABI bug | Max Kellermann | 1 | -10/+2 | |
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround! | |||||
2014-11-02 | decoder/ffmpeg: recognize MIME type audio/aacp | Steven OBrien | 1 | -0/+1 | |
2014-11-02 | output/roar: remove unnecessary "volatile" keyword | Max Kellermann | 1 | -1/+1 | |
A mutex acts as a memory barrier, and thus "volatile" is not necessary. | |||||
2014-11-02 | TagString: use g_strndup() for unterminated string | Max Kellermann | 1 | -1/+1 | |
Fixes buffer overflow bug. | |||||
2014-09-26 | CommandLine: update copyright year | Max Kellermann | 1 | -2/+2 | |
2014-09-26 | configure.ac: add option to disable the DSD decoders | Max Kellermann | 1 | -0/+2 | |
Allow building a smaller MPD binary for people who don't need DSD. | |||||
2014-09-26 | playlist/embcue: change name string to "embcue" | Max Kellermann | 1 | -1/+1 | |
The name "cue" was listed twice in "mpd --version". | |||||
2014-09-18 | OutputThread: retain negative mix ratio | Max Kellermann | 1 | -1/+10 | |
Fixes MixRamp breakage. | |||||
2014-09-18 | command/list: reset used size after the list has been processed | Andrzej Rybczak | 1 | -0/+1 | |
2014-09-13 | thread/Posix{Cond,Mutex}: don't ues PTHREAD_*_INITIALIZER on NetBSD | Max Kellermann | 3 | -1/+29 | |
On NetBSD, PTHREAD_MUTEX_INITIALIZER and PTHREAD_COND_INITIALIZER are not compatible with C++11 "constexpr" (see Mantis ticket 0004110). As a workaround, don't ues "constexpr", and use the functions pthread_mutex_init(), pthread_mutex_destroy(), pthread_cond_init() and pthread_cond_destroy() instead. This adds some runtime overhead, but is portable to POSIX implementations that have awkward initializer macros. | |||||
2014-09-09 | decoder/ffmpeg: use memset() to initialize AVProbeData | Max Kellermann | 1 | -0/+6 | |
2014-09-07 | decoder/ffmpeg: pass MIME type to ffmpeg/libav version 11 | Max Kellermann | 1 | -0/+7 | |
That attribute was uninitialized before, which could crash libavformat. See Debian bug 760669 | |||||
2014-09-07 | Decoder*: add more assertions | Max Kellermann | 2 | -0/+7 | |
2014-09-07 | DecoderThread: clear the pipe when handling late SEEK | Max Kellermann | 1 | -1/+11 | |
See code comment. Fixes assertion failure in decoder_command_finished(). | |||||
2014-09-06 | decoder/audiofile: fix crash after seeking | Max Kellermann | 1 | -1/+1 | |
Log call was added to the wrong branch. Fixes regression by commit ca1a1149 | |||||
2014-09-04 | protocol/ArgParser: fix integer overflow in parse_range() | Max Kellermann | 1 | -2/+2 | |
Casting std::numeric_limits<unsigned>::max() to "long" leads to an overflow if sizeof(unsigned)==sizeof(long), and the result will be -1. This happens on some 32 bit architectures, for example ARM and WIN32. Workaround: use std::numeric_limits<int>::max(), which is the largest signed integer. Since sizeof(long)>=sizeof(int), this will never overflow. Fixes Mantis ticket 0004080. | |||||
2014-08-31 | PlaylistControl: use SeekSongOrder(current) to keep current song | Max Kellermann | 1 | -1/+1 | |
The "current" attribute is a "song order", not a "song position". This is usually the same - except in random mode. Fixes Mantis ticket 0004073. | |||||
2014-08-31 | PlaylistControl: move code to new method SeekSongOrder() | Max Kellermann | 2 | -7/+19 | |
2014-08-31 | output/alsa: fix endless loop at end of file in dsd_usb mode | Max Kellermann | 1 | -0/+9 | |
2014-08-31 | output/{alsa,oss}: add assertions | Max Kellermann | 2 | -0/+6 | |
2014-08-29 | decoder/gme: fix song duration | Max Kellermann | 1 | -1/+1 | |
The unit of gme_info_t::length is milliseconds, not centiseconds. | |||||
2014-08-24 | event/TimeoutMonitor: really reset "active" flag before invoking OnTimeout() | Max Kellermann | 1 | -1/+1 | |
The previous commit was broken. D'oh! | |||||
2014-08-24 | event/TimeoutMonitor: reset "active" flag before invoking OnTimeout() | Max Kellermann | 1 | -1/+3 | |
The IsActive() method returned true even if the timer was not active, after it completed once. This broke the state file timer, and the state file was not saved periodically. |