| Commit message (Collapse) | Author | Files | Lines |
|---|
|
A linked list is quite uncomfortable here because there is a lot of
indexed access to the list. Use a GPtrArray of strings instead.
Note that mpdclient_get_artists_utf8() and mpdclient_get_albums_utf8()
return a linked list, and sorting is also performed on the linked
list. This will be optimized later.
|
|
Generate these special list entries on the fly.
|
|
To unify the code, wrap list_window_cmd() in artist_lw_cmd(), which
properly checks the current mode.
|
|
"prev_song_id" and "current_song_id" had value 0 if MPD was not
playing at all. This way, ncmpc cannot see the difference between
"song 0 playing" and "not playing". Change "not playing" to -1.
|
|
When deciding whether to repaint the current highlight, test if MPD is
actually playing. If MPD starts playing, repaint.
|
|
The play_update() function was reduced too much: it didn't repaint the
screen when the current song changed. Add check for that.
Don't repaint the screen in center_playing_item(), make the caller do
it.
|
|
Ignore SIGPIPE, and handle errno==EPIPE instead.
|
|
If the lyrics screen is disabled at compile time, don't initialize the
lyrics library in main().
|
|
CMD_ADD ('a') appends a song to the playlist, no matter if it is
already there, i.e. unlike CMD_SELECT, it does not toggle the song.
|
|
Static variables, pointers vs integers, void function returning, ...
|
|
|
|
Everything is now managed with a pointer to the screen_functions
struct.
|
|
Finally remove all screen ids, they are not used anymore.
|
|
Trying to get rid of the screen ids. A pointer to screen_functions is
better for identifying a screen.
|
|
Screen code shouldn't know anything about the screen ids (which will
be eliminated completely later). Instead of comparing ids, compare
the screen_functions pointer.
|
|
Move the hard-coded screen list and everything which works with this
array to screen_list.c.
|
|
Instead of evaluating macros from config.h in the disabled source,
don't start the compiler on it at all.
|
|
The second wmove() is redundant, because the cursor is already there
after waddstr(). This also repairs wide characters in the prompt.
|
|
Since all screen updating is now on demand, we don't need this flag
anymore.
|
|
play_update() is the only update() implementation left, and it does
not use the screen pointer. Remove it from the method signature.
|
|
Instead of hiding the cursor in the update() callback, hide it with a
glib main loop timeout.
|
|
Repaint the search screen on demand. No need for the update() method
anymore.
|
|
The check wasn't actually doing anything, except leaking memory.
Remove it.
|
|
Repaint the file screen on demand. No need for the update() method
anymore.
|
|
Repaint the artist screen on demand. No need for the update() method
anymore.
|
|
Repaint the playlist window on demand. Don't repaint it
unconditionally in play_update().
|
|
The property "repaint" is never read, since all callers repaint the
list window on demand.
|
|
Automatically redraw the screen on demand, whenever data has changed.
|
|
lyrics_repaint() or lyrics_repaint_if_active() are called after data
has changed, and the screen needs an update.
|
|
Automatically redraw the list on demand, whenever data has changed.
|
|
None of the paint() implementations actually use the screen pointer -
remove it from the method signature.
|
|
screen_paint() and screen_update() are responsible for refreshing the
screen. We can remove all wrefresh() and wnoutrefresh() invocations
from all paint() and update() method implementations.
|
|
Without clearing previous screen contents, there may be corruptions,
make this mandatory and optimize screen clearing.
|
|
Follow the same code style als MPD itself.
|
|
Instead of manually adjusting the selection, let list_window.c do it.
|
|
There are lots of functions not being used outside of list_window.c.
Make them static to make it easier for gcc to optimize.
|
|
The lyrics library loads all plugins from the directory configured
with "--with-lyrics-plugin-dir".
|
|
Instead of letting our caller poll lyrics_result(), call it back as
soon as we have the result.
|
|
Instead of creating a thread for handling lyrics plugin data, register
a channel at the glib main loop.
|
|
The variable current.song was never set, thus the cache did not work.
Don't reset it in screen_lyrics_clear() (which is called from
screen_lyrics_set()).
|
|
Instead of checking for the sentinel at the end of the option table,
check the option_table_size constant.
|
|
Make the options_table constant, since it is never modified.
|
|
If prompt is NULL, do not add a second call to wreadln_masked() with a
literal string, but assign this literal string to the variable
"prompt". This saves several bytes in the compiled binary.
|
|
The call to curs_set(0) in screen_read_password() was dead code,
because it was after the function return. Repair that.
|
|
Store screen width and height as unsigned integer.
|
|
Follow the same code style als MPD itself.
|
|
Since screen.c has default code for CMD_SCREEN_UPDATE, return 0 from
the command handlers and let screen.c do the rest.
|
|
Several screens ignore the attribute list_window->repaint. Don't set
it there. It will be replaced with a more intelligent repaint
algorithm later.
|
|
The variable cur_action_id is not used at all.
|
|
last_cmd stores the previous command sent to the screen. It is not a
timestamp, and its type should be command_t.
|
