aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-09-15free info entity while iteratingMax Kellermann1-0/+2
Memory leak: the function mpdclient_playlist_update_changes() did not free the entity which was returned by mpd_getNextInfoEntity(). Add a mpd_freeInfoEntity() call at the end of each iteration.
2008-09-15manage tag string allocations in a poolMax Kellermann4-44/+200
There are many duplicated strings in the tag database, e.g. many songs having the same artist. Don't allocate such strings twice, manage all strings in a pool.
2008-09-15added support for unix domain socketsMax Kellermann1-1/+58
If a host name starts with a slash, it is assumed to be a unix domain socket path. The port is ignored. This code is disabled on WIN32, until someone tests it.
2008-09-15lyrics: missing "break"Max Kellermann1-1/+2
If get_text_line() fails, we should break from the loop.
2008-09-15lyrics: converted global variables to staticMax Kellermann2-6/+3
The variables "lyrics_text_rows" and "lw" were declared in src_lyrics.h as static, but they were only actually used in screen_lyrics.c. Move both there.
2008-09-15fix unused parameter warningsMax Kellermann8-47/+59
Add the "unused" attribute to all function parameters which are indeed going to be ignored.
2008-09-15imported gcc.h from mpdMax Kellermann2-1/+71
gcc.h contains a useful set of macros for setting attributes.
2008-09-15don't declare local variable "options"Max Kellermann3-13/+15
In main.c, the global variable "options" is used all over, except in main(), which contains a shadowing declaration of it. Remove this local variable, and use the global "options" instead. Also don't pollute conf.c's namespace with the global variable with a CPP hack (to be removed when we have fixed more of ncmpc's namespace pollution).
2008-09-15use size_t and unsigned integersMax Kellermann18-114/+130
2008-09-15fixed mixed declaration + codeMax Kellermann3-16/+19
Although they are allowedd in C99, try to avoid them. Move variable declarations to the top of the current scope.
2008-09-15fix shadow warningsMax Kellermann10-144/+148
Rename local variables and function parameters, so they don't shadow global variables.
2008-09-15include cleanupMax Kellermann36-167/+173
A header should include all headers which he needs. Move local includes on top, and let foo.c include foo.h in the first line, to automatically test its dependencies.
2008-09-15screen_auth() returns resultMax Kellermann1-1/+2
screen_auth() returns an int, and its result is actually being used. Only the "return" was missing in its implementation. Return _screen_auth()'s result.
2008-09-15fix function prototypesMax Kellermann15-39/+84
Add missing prototypes, and fix wrong prototypes. Convert lots of functions to "static" when they are only used within the current source file.
2008-09-15const pointersMax Kellermann33-134/+135
Convert pointers to const whenever it is possible. Fixes all those -Wconst warnings.
2008-09-15clock: don't initialize static variables with zeroMax Kellermann1-1/+1
Uninitialized static variables are put into BSS, which is automatically zeroed. Initializing doesn't hurt, but in this case, there were elements missing, emitting a gcc warning.
2008-09-15screen: moved code to paint_top_window2()Max Kellermann1-68/+74
Nearly all of the code in paint_top_window() is on indent level 2, just because it depends on a condition. Make this more readable and move to indent level 1 by moving this code to a separate function.
2008-09-15use !NDEBUG instead of DEBUGMax Kellermann4-7/+7
NDEBUG is more commonly used than DEBUG, e.g. in assert.h. Convert all macros to NDEBUG, and declare NDEBUG when debugging is disabled.
2008-09-15code style, indent with tabsMax Kellermann29-4250/+3931
Follow the same code style als MPD itself. This patch only fixes parts of the code which are going to be touched in the following bunch of patches, i.e. there will be more "code style" patches in the future.
2008-09-15remove unused static functionsMax Kellermann18-72/+17
Also remove some commented code and unused function parameters.
2008-09-15splash: removed the useless splash screenMax Kellermann7-142/+2
The code looks strange and spews lots of warnings. Since it does nothing useful, and wastes the user's precious time, simply remove it.
2008-01-18improve escaping of URLsAndreas Obergrusberger1-5/+5
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7141 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-11-30make item highlighiting more appropriateAndreas Obergrusberger1-4/+1
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7062 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-11-30cmd_select_all addedAndreas Obergrusberger6-0/+96
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7061 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-08-26fixed 0001496Andreas Obergrusberger1-0/+13
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6817 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-08-26Removed nested functionsAndreas Obergrusberger3-213/+335
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6811 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-06-172 critical bugs in leoslyrics lyrics src fixedAndreas Obergrusberger1-2/+7
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6630 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-03-29fix segfaultAndreas Obergrusberger2-3/+8
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5773 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-03-14ugh!Andreas Obergrusberger1-1/+1
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5621 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-02-16way too much stuff to describe hereAndreas Obergrusberger11-38/+127
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5346 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-02-01lyrics updates, leoslyrics fixesAndreas Obergrusberger5-16/+12
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5314 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-01-05fix user plugin dir; code cleanupAndreas Obergrusberger3-10/+16
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5220 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-01-03fix error display on lyrics screenAndreas Obergrusberger1-7/+7
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5219 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-01-03added a plugin system for lyrics sourcesAndreas Obergrusberger8-304/+566
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5217 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-11-11Daniel rocked the houseAndreas Obergrusberger5-12/+51
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5041 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-11-08go to root/parent dir key addedAndreas Obergrusberger4-9/+36
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5034 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-28filelist sorting improvedAndreas Obergrusberger2-0/+40
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4953 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-05you can specify %shortalbum% for playlist song markup, parent directory is ↵Andreas Obergrusberger2-1/+30
shown in the browse screen title git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4871 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-09http://musicpd.org/mantis/view.php?id=1324Andreas Obergrusberger1-1/+6
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4757 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-08multi liner ;) fixed segfaultAndreas Obergrusberger2-8/+7
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4749 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-08disable splash by defaultAndreas Obergrusberger1-1/+1
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4744 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-08oppps forgot 2 files...Andreas Obergrusberger2-0/+126
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4742 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-07due to bensonk's demand i added a splash screen.Andreas Obergrusberger10-21/+124
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4741 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28use older revision till serious bugfixAndreas Obergrusberger1-394/+376
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4704 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26make compilation work againAndreas Obergrusberger1-3/+6
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4697 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26code cleanupAndreas Obergrusberger1-210/+225
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4695 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-25fix a bug the makes utf8 names behave evilAndreas Obergrusberger1-2/+2
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4683 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-12spelling fixes by avutonAndreas Obergrusberger5-5/+5
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4615 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-08fix a bug that doubled empty lines when loading lyrics from hdAndreas Obergrusberger1-1/+1
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4601 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-08avuton fixed some warningsAndreas Obergrusberger2-4/+7
git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4600 09075e82-0dd4-0310-85a5-a0d7c8717e4f
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 01:53:53 +0000