aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-08-28client: allocate clients dynamicallyMax Kellermann1-90/+76
Due to the large buffers in the client struct, the static client array eats several megabytes of RAM with a maximum of only 10 clients. Stop this waste and allocate each client struct from the heap.
2008-08-28client: added function client_by_fd()Max Kellermann1-13/+21
The code becomes less complex and more readable when we move this linear search into a separate mini function.
2008-08-28client: return early in client_new()Max Kellermann1-30/+31
This saves one level of indent.
2008-08-28client: renamed all public functionsMax Kellermann6-19/+19
Functions which operate on the whole client list are prefixed with "client_manager_", and functions which handle just one client just get "client_".
2008-08-28client: renamed internal functions and variablesMax Kellermann1-297/+296
Rename all static functions, variables and macros which have "interface" in their name to something nicer prefixed with "client_".
2008-08-28client: renamed Interface to struct clientMax Kellermann1-19/+19
Second patch: rename the internal struct name. We will eventually export this type as an opaque forward-declared struct later, so we can pass a struct pointer instead of a file descriptor, which would save us an expensive linear lookup.
2008-08-28renamed interface.c to client.cMax Kellermann7-7/+7
I don't believe "interface" is a good name for something like "connection by a client to MPD", let's call it "client". This is the first patch in the series which changes the name, beginning with the file name.
2008-08-28imported list.h from the Linux kernel sourcesMax Kellermann2-0/+485
linux/list.h is a nice doubly linked list library - it is lightweight and powerful at the same time. It will be useful later, when we begin to allocate client structures dynamically. Import it, and strip out all the stuff which we are not going to use.
2008-08-28const pointersMax Kellermann6-16/+16
The usual bunch of pointer arguments which should be const.
2008-08-28unsigned integers and size_tMax Kellermann3-11/+11
Use "unsigned int" whenever negative values are not meaningful. Use size_t whenever we are going to describe buffer sizes.
2008-08-28include cleanupMax Kellermann4-2/+3
Only include headers which are really needed.
2008-08-28protect locate.h from double inclusionMax Kellermann1-0/+5
2008-08-26moved player_command_finished() to player_thread.cMax Kellermann3-10/+8
2008-08-26moved code to pc_init(), dc_init()Max Kellermann8-24/+37
2008-08-26renamed player.c to player_control.cMax Kellermann13-272/+252
Give player.c a better name, meaning that the code is used to control the player thread.
2008-08-26no commandError() in playerSeek()Max Kellermann3-9/+9
We should avoid having protocol specific code in player.c. Just return success or failure, and let the caller send the error code to the MPD client.
2008-08-26don't initialize "i" if we overwrite it anywayMax Kellermann1-1/+3
2008-08-26renamed decoderInit() to decoder_thread_start()Max Kellermann3-3/+3
2008-08-26renamed decode.h to decoder_control.hMax Kellermann7-6/+7
2008-08-26renamed decode.c to decoder_thread.cMax Kellermann5-4/+30
It should be obvious in which thread or context a function is being executed at runtime. The code which was left in decode.c is for the decoder thread itself; give the file a better name.
2008-08-26moved global variable "pc" to player.hMax Kellermann11-9/+32
This is the last of the three variables. Now we don't need playerData.h anymore in most sources.
2008-08-26moved global variable "ob" to outputBuffer.hMax Kellermann7-6/+14
This releases several include file dependencies. As a side effect, "CHUNK_SIZE" isn't defined by decoder_api.h anymore, so we have to define it directly in the plugins which need it. It just isn't worth it to add it to the decoder plugin API.
2008-08-26moved enum decoder_command to decoder_api.hMax Kellermann2-8/+9
The decoder plugins need this type, so export it in the public API. This allows is to remove "decode.h" from "decoder_api.h", uncluttering the API namespace some more.
2008-08-26moved variable "dc" to decode.hMax Kellermann8-22/+27
Now that "dc" is available here, we don't have to pass it to decoder_is_idle() and decoder_is_starting() anymore.
2008-08-26player_thread: removed decode(), renamed decodeParent()Max Kellermann1-15/+4
decode() is a trivial wrapper for decodeParent(). Merge both and rename them to do_play().
2008-08-26hide DecoderControl accesses in inline functionsMax Kellermann2-10/+27
Unfortunately, we have to pass the DecoderControl pointer to these inline functions, because the global variable "dc" may not be available here. This will be fixed later.
2008-08-26check for decoder error before state!=STARTMax Kellermann1-9/+8
When dc->error!=NOERROR, we do not need to check state!=START. Simplify the checks by moving the error check to the top.
2008-08-26don't reset dc->command in quitDecode()Max Kellermann1-1/+0
The decoder thread is responsible for resetting dc->command after a command was executed. As a consequence, we can assume that dc->command is already NONE after decoder_stop().
2008-08-26added decoder_control.cMax Kellermann4-50/+110
The source "decoder_control.c" provides an API for controlling the decoder. This replaces various direct accesses to the DecoderControl struct.
2008-08-26removed the "queue" parameter from syncPlaylistWithQueue()Max Kellermann1-12/+11
There is only one caller which passes "true", so we can move the queueNextSongInPlaylist() invocation there.
2008-08-26merge the playlist lock functions into clearPlayerQueue()Max Kellermann1-24/+11
There is no unlocked caller of clearPlayerQueue(), and the functions lockPlaylistInteraction() and unlockPlaylistInteraction() are trivial - merge them.
2008-08-26use switch/case in syncPlaylistWithQueue()Max Kellermann1-8/+18
2008-08-26don't call playerStop() before playerPlay()Max Kellermann3-12/+3
Since playerPlay() already calls playerStop(), we can remove its invocation of playerStop() from playPlaylistOrderNumber(). We can also make playerStop a static function.
2008-08-26assert locked/unlocked in queue lock functionsMax Kellermann1-2/+5
There are no nested queue locks in mpd, thus replace the locked checks in playerQueueLock(), playerQueueUnlock() with assertions.
2008-08-26don't unlock player queue in playerStop(), playerWait()Max Kellermann1-2/+6
There is no caller of these two functions which locks the player queue; replace the playerQueueUnlock() call with an assertion.
2008-08-26queueSong() cannot failMax Kellermann3-21/+8
All (indirect) callers of queueSong() ensure that the queue state is BLANK, so there is no need to check it in queueSong() again. As a side effect, queueSong() cannot fail anymore, and can return void. Also, playlist_queueError and all its error handling can go away.
2008-08-26fix a comment regarding the player queueMax Kellermann1-1/+1
2008-08-26document the PLAYER_QUEUE_ constantsMax Kellermann1-0/+15
2008-08-26added enum player_queue_stateMax Kellermann3-11/+19
2008-08-26rewrote playerKill()Max Kellermann3-2/+11
playerKill() was marked as deprecated, but it seems like a good idea to do proper cleanup in all threads (e.g. for usable valgrind results). Introduce the command "EXIT" which makes the player thread exit cleanly.
2008-08-26player: don't call STOP before CLOSE_AUDIOMax Kellermann2-15/+10
playerWait() stops the player thread (twice!) and closes the output device. It should be well enough to just send CLOSE_AUDIO, without STOP. This requires a tiny change to the player thread code: make it break when CLOSE_AUDIO is sent.
2008-08-26playlist: eliminate unused fd parametersMax Kellermann3-49/+46
Again, remove file descriptor parameters, which are not actually used. These functions can also be converted to return void.
2008-08-26player: no "fd" and no return valueMax Kellermann4-47/+30
Most player*() functions do not actually use the file descriptor, and always return 0 (success). Eliminate them to get a leaner interface.
2008-08-26flac: decoder command means EOFMax Kellermann2-11/+9
It was possible for the decoder thread to go into an endless loop (flac and oggflac decoders): when a "STOP" command arrived, the Read() callback would return 0, but the EOF() callback returned false. Fix: when decoder_get_command()!=NONE, return EOF==true.
2008-08-26made "sample_size" static constMax Kellermann1-1/+1
sample_size is a variable which is computed at compile time. Declare it "static const", so the compiler can optimize it away.
2008-08-26moved jack configuration to the JackData structMax Kellermann1-49/+64
Storing local configuration in global (static) variables is obviously a bad idea. Move all those variables into the JackData struct, including the locks.
2008-08-26jack: removed unused macrosMax Kellermann1-10/+0
2008-08-26jack: don't set audioOutput->data=NULLMax Kellermann1-5/+5
There is only one caller of freeJackData() left: jack_finishDriver(). This function is called by the mpd core, and is called exactly once for every successful jack_initDriver(). We do not need to clear audioOutput->data, since this variable is invalidated anyway.
2008-08-26jack: initialize JackData in jack_initDriver()Max Kellermann1-6/+2
Over the lifetime of the jack AudioOutput object, we want a single valid JackData object, so we can persistently store data there (configuration etc.). Allocate JackData in jack_initDriver(). After that, we can safely remove all audioOutput->data==NULL checks (and replace them with assertions).
2008-08-26jack: added freeJackClient()Max Kellermann1-13/+25
No need to destroy the JackData object when an error occurs, since jack_finishDriver() already frees it. Only deinitialize the jack library, introduce freeJackClient() for that, and move code from freeJackData().