aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-07-18output/httpd: add missing g_free in error pathJonathan Neuschäfer1-0/+1
2011-07-18output/ao: add missing g_free in error pathJonathan Neuschäfer1-0/+3
2011-07-18conf: add missing fclose in error pathJonathan Neuschäfer1-1/+10
This patch seems a bit ugly, maybe it would be a bit cleaner with gotos.
2011-07-18sticker: fix a memory leakJonathan Neuschäfer1-1/+3
2011-07-18ape: add missing g_free in error pathJonathan Neuschäfer1-1/+3
2011-07-03decoder/flac: validate the sample rate when scanning the tagMax Kellermann2-1/+5
Don't calculate the song duration when the sample rate is 0 (division by zero crash).
2011-07-03ffmpeg: workaround for semantic API change in recent ffmpeg versionsoblique1-2/+2
2011-05-09directory: allow directories with just playlistsMax Kellermann2-1/+8
Keep those when scanning for empty directories. The check in playlist_vector_is_empty() was missing.
2011-05-09playlist_song: fix playlist files in base music directoryMax Kellermann1-0/+7
g_path_get_dirname() returns "." when there is no directory name in the given path. This patch adds a workaround for that.
2011-05-09playlist_song: fix NULL pointer dereferenceMax Kellermann1-1/+1
2011-05-09decoder/ffmpeg: use avcodec_decode_audio3() if availableMax Kellermann1-1/+22
avcodec_decode_audio3() has been added in libavformat 52.25.0, and the predecessor avcodec_decode_audio2() has been deprecated.
2011-05-09decoder/ffmpeg: make variables more localMax Kellermann1-27/+16
2011-05-09decoder/ffmpeg: don't use deprecated CODEC_TYPE_AUDIO with new lavcAnton Khirnov1-0/+4
fixes build with lavc 53.
2011-05-09decoder/ffmpeg: define fallback macro AV_VERSION_INT()Max Kellermann1-1/+5
For ffmpeg < 0.5. Copied from libavutil 0.5.
2011-03-23decoder/flac: fix enum mismatch in flac_tell_cb()Max Kellermann1-1/+1
Fix clang warning.
2011-03-23listen: suppress "unused variable" warningMax Kellermann1-0/+2
2011-03-23audio_parser: fix assertion failure in audio format mask parserMax Kellermann1-1/+2
Use audio_format_mask_valid() to verify a mask.
2011-03-23command: fix return value of handle_currentsong()Max Kellermann1-1/+1
Thanks to clang for complaining.
2011-03-18command: print playlist load errorMax Kellermann1-1/+1
Call print_playlist_result() instead of casting the enum implicitly.
2011-03-18output/httpd: include sys/socket.h only when building with libwrapMax Kellermann1-1/+1
Fixes build failure on WIN32.
2011-03-18update_walk: ignore parameter "mode" on WIN32Max Kellermann1-0/+1
Fix compiler warning.
2011-03-16audio_format, output_thread: add more audio_format_valid() assertionsMax Kellermann4-0/+13
2011-03-16encoder/vorbis: reset the Ogg stream after flushMax Kellermann1-0/+2
Without the ogg_stream_reset() call, the "e_o_s" flag never gets reset, and libogg writes EOS packets over and over.
2011-03-16encoder/vorbis: reset the Ogg stream after flushMax Kellermann1-0/+2
Without the ogg_stream_reset() call, the "e_o_s" flag never gets reset, and libogg writes EOS packets over and over.
2011-03-09output/httpd: include sys/socket.h for AF_UNIXUlrich Spörlein1-0/+1
2011-02-28output/oss: disable 24 bit playback on FreeBSDMax Kellermann1-0/+9
See code comment.
2011-02-28output/oss: AFMT_S24_PACKED is little-endianMax Kellermann1-0/+12
According to the Solaris dsp manpage, AFMT_S24_PACKED is little-endian: http://download.oracle.com/docs/cd/E19963-01/821-1475/6nmf5baot/index.html The Minix soundcard.h header says the same.
2011-02-27output/jack: fix crash with mono playbackMax Kellermann1-1/+1
With mono sound, jack_sample_size is smaller than frame_size (4 vs 2 bytes), and "space/jack_sample_size==0". That means mpd_jack_play() will return 0, although no error has occurred.
2011-02-25output/jack: rename variable sample_size to jack_sample_sizeMax Kellermann1-5/+6
2011-02-15Insure proper initialization of stack-allocated struct.Christopher Brannon1-1/+4
Version 1.0.0 of the libao library added a new field to the ao_sample_format struct. It is a char * named matrix. When an ao_sample_format is allocated on the stack, this field contains garbage. The proper course is to insure that is initialized to NULL. NULL indicates that we do not want any mapping. The struct is now initialized using a static initializer, and this technique is compatible with all known versions of libao.
2011-02-09general: whitespace cleanupThomas Jansen9-29/+29
Remove trailing whitespace found by this command: find -name '*.[ch]' | xargs grep "[[:space:]]$"
2011-02-09output/httpd: initialize unflushed_inputThomas Jansen1-0/+1
This fixes the following valgrind warning occuring on the first call of httpd_output_read_page: ==20124== Conditional jump or move depends on uninitialised value(s) ==20124== at 0x425E65: httpd_output_read_page (httpd_output_plugin.c:240) ==20124== by 0x426087: httpd_output_open (httpd_output_plugin.c:279) ==20124== by 0x41D862: ao_open (output_plugin.h:206) ==20124== by 0x41E133: audio_output_task (output_thread.c:590)
2011-02-03Set fadeout in gme_decoder_plugin. Due to the nature of the gme library,Tony Miller1-0/+3
this needs to be done for the end of songs to be detected.
2011-01-31update: log all file permission problemsMax Kellermann1-0/+6
2011-01-14Fix NDEBUG testAndreas Wiese1-1/+1
<stdbool.h> needs to be included unconditionally from definition of NDEBUG, since »bool« doesn't get defined otherwise. Signed-off-by: Andreas Wiese <aw-devel@meterriblecrew.net>
2011-01-07player_thread: discard empty chunks while cross-fadingMax Kellermann1-0/+13
When a music_chunk to be crossfaded consists only of a tag, cross-fading is not possible, and led to an assertion failure. This patch just discards those, as if cross-fading was not enabled.
2011-01-07output_thread: fix double lockMax Kellermann1-3/+0
During the whole output thread, the audio_output object is locked, and it is only unlocked while waiting for the GCond and while running a plugin method. The error handler in ao_play_chunk() attempted to lock the object again, which was code from MPD 0.15.x which should have been removed a long time ago.
2011-01-07player_thread: fix assertion failure due to early seekMax Kellermann1-0/+4
Until the decoder plugin has called decoder_initialized(), the player may not submit seek commands. This however could occur with a slow decoder and a CUE file with a virtual song offset. This patch adds another check.
2011-01-07player_thread: make variables more localMax Kellermann1-36/+19
2011-01-07encoder/lame: explicitly configure the output sample rateMax Kellermann1-0/+7
When you don't explicitly set an output sample rate, liblame tries to guess an output sample rate from the input sample rate. You would think that this "guessing" consists of just setting both equal, but that is not the case. For 44.1kHz at 96kbit/s, liblame chooses 32kHz. This patch explicitly configures the output sample rate, to stop the bad guessing.
2011-01-07output/httpd: define G_LOG_DOMAIN in httpd_client.cMax Kellermann1-0/+3
2011-01-07output/osx: fix up audio format first, then apply it to deviceMax Kellermann1-9/+10
This is a MPD 0.16 regression: when playing a 24 bit file, the switch to 16 bit was made only partially, after mBytesPerPacket and mBytesPerFrame had already been applied. That means mBytesPerFrame referred to 24 bit, and mBitsPerChannel referred to 16 bits. Of course, that cannot work.
2010-12-21directory: fix warning "comparison between signed and unsigned"Max Kellermann1-2/+2
Cast the constant to dev_t, not to unsigned.
2010-12-21zeroconf-bonjour: use g_htons() instead of htons()Max Kellermann1-1/+1
Fixes the gcc warning "implicit declaration of function 'htons'".
2010-12-21add void casts to suppress "result unused" warnings (clang)Max Kellermann2-3/+3
2010-12-21decoder/mad: work around build failure on SolarisAlex Viskovatoff1-2/+2
Rename the "version" struct, because it seems to be a reserved name on Solaris: "src/decoder/mad_decoder_plugin.c", line 550: (enum) tag redeclared: version cc: acomp failed for src/decoder/mad_decoder_plugin.c
2010-12-21output/solaris: add missing parameter to open_cloexec() callAlex Viskovatoff1-1/+1
2010-12-21audio_check: fix parameter in prototypeAlex Viskovatoff1-1/+1
2010-12-07tag_id3: support multiple valuesMax Kellermann1-10/+36
Loop over all frames with a specific id, and import all of them - not just the first one (index 0).
2010-12-07command: don't error when sticker list is run on song with no stickersAnton Khirnov1-7/+3
this is inconsistent with other commands (e.g. find) and seems wrong -- a song with no stickers attached is a perfectly valid state and an empty list of stickers is also perfectly valid.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 17:20:13 +0000