Commit message (Collapse) | Author | Files | Lines | ||
---|---|---|---|---|---|
2015-01-21 | thread/Name: include stdio.h if HAVE_PRCTL | Max Kellermann | 1 | -1/+4 | |
Caused a build failure with uClibc because snprintf() was not available. | |||||
2015-01-06 | input/async: reset the "open" flag after seeking successfully | Max Kellermann | 1 | -0/+5 | |
Fixes a problem with the "curl" input plugin: IsEOF() always returns true because the "open" flag was cleared by CurlInputStream::RequestDone() when end-of-stream was reached. This flag stays false even when seeking to another position has succeeded. This patch resets the "open" flag to true after seeking successfully. | |||||
2015-01-06 | thread/Name: disable pthread_setname_np() on NetBSD | Max Kellermann | 1 | -2/+6 | |
NetBSD's pthread_setname_np() prototype is incompatible with the rest of the world, and it requires to pass the string argument as a non-const pointer. Instead of working around this misdesign, I hereby disable the feature on NetBSD. | |||||
2015-01-06 | thread/Name: enable FormatThreadName() with prctl() | Max Kellermann | 1 | -1/+5 | |
Add macro HAVE_THREAD_NAME which is set when any method to set the thread name is available. Use that macro in FormatThreadName() instead of just checking for HAVE_PTHREAD_SETNAME_NP. | |||||
2015-01-06 | thread/Name: indent preprocessor commands | Max Kellermann | 1 | -3/+3 | |
2014-12-26 | db/simple: fix implicit nullptr/bool conversion | Max Kellermann | 3 | -5/+5 | |
Return false on error, not nullptr. | |||||
2014-12-26 | fs/Traits, ...: work around -Wtautological-pointer-compare | Max Kellermann | 5 | -1/+32 | |
New in clang 3.6. | |||||
2014-12-26 | db/lazy, input/mms: add "override" keywords | Max Kellermann | 3 | -4/+6 | |
Fixes -Winconsistent-missing-override (clang 3.6). | |||||
2014-12-26 | db/proxy, output/shout: fix implicit nullptr/bool conversion | Max Kellermann | 2 | -4/+4 | |
Return false on error, not nullptr. | |||||
2014-12-26 | db/{simple,proxy}, ...: add "override" keywords | Max Kellermann | 7 | -22/+26 | |
Fixes -Winconsistent-missing-override (clang 3.6). | |||||
2014-12-26 | util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compare | Max Kellermann | 10 | -0/+51 | |
New in clang 3.6. | |||||
2014-12-26 | DatabaseGlue: convert nullptr check to assertion | Max Kellermann | 1 | -3/+2 | |
2014-12-26 | util/ASCII: fix indent | Max Kellermann | 1 | -10/+10 | |
2014-12-26 | Compiler.h: add macro CLANG_CHECK_VERSION() | Max Kellermann | 1 | -0/+7 | |
2014-12-26 | Compiler.h: add macro GCC_OLDER_THAN() | Max Kellermann | 2 | -4/+12 | |
2014-12-26 | util/Manual: reimplement GCC_CHECK_VERSION() using GCC_MAKE_VERSION() | Max Kellermann | 1 | -4/+3 | |
2014-12-26 | Compiler.h: add macro GCC_MAKE_VERSION() | Max Kellermann | 1 | -6/+4 | |
2014-12-23 | decoder/ffmpeg: support interleaved floating point | Max Kellermann | 1 | -0/+1 | |
2014-12-23 | input/mms: limit the mmsx_read() size | Max Kellermann | 1 | -0/+7 | |
2014-12-23 | decoder/DsdLib: add missing stdlib.h include | Max Kellermann | 1 | -0/+1 | |
2014-12-23 | DSF ID3 tags hitting 4k size limit | Jan Brittenson | 1 | -6/+12 | |
Here's a change to dynamically allocate the DSD ID3 tag buffer. Pretty much anything with cover art is going to exceed the existing, static 4k limit... Here's a change to dynamically allocate the buffer and sanity check it at some upper limit. I rather arbitrarily pulled 256k out of thin air just to keep a corrupt file from causing it to trying to allocate a buffer larger than available memory. | |||||
2014-12-17 | LogBackend: force-flush stderr on WIN32 | Max Kellermann | 1 | -0/+6 | |
setvbuf() does not seem to have an effect on Windows. | |||||
2014-12-17 | LogInit: make stderr line-buffered | Max Kellermann | 1 | -0/+3 | |
Make sure everything gets logged right away. No delays because stdio's buffer is not yet full. | |||||
2014-12-17 | util/HugeAllocator: enable MEM_COMMIT on Windows | Max Kellermann | 1 | -1/+3 | |
Without MEM_COMMIT, the reserved address space is not accessible, and MPD crashes. | |||||
2014-12-16 | playlist/embcue: fix filename suffix detection | k44 | 1 | -1/+1 | |
The definition of the playlist_plugin struct member of the embcue plugin was incorrect. | |||||
2014-12-15 | storage/nfs: add timeout | Max Kellermann | 2 | -3/+13 | |
2014-12-15 | decoder/ffmpeg: detect and fix negative time stamps | Max Kellermann | 1 | -4/+7 | |
Works around assertion failure due to something that appears to be a (minor) FFmpeg bug. | |||||
2014-12-15 | storage/nfs: clear last_error in SetState() | Max Kellermann | 1 | -0/+1 | |
Fixes bogus assertion failure. | |||||
2014-12-15 | lib/nfs/Connection: unregister socket with SocketMonitor::Steal() | Max Kellermann | 1 | -1/+1 | |
SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event. | |||||
2014-12-15 | lib/nfs/Connection: implement mount timeout | Max Kellermann | 2 | -2/+31 | |
2014-12-15 | lib/nfs/Connection: add debug flag "in_destroy" | Max Kellermann | 2 | -0/+11 | |
2014-12-14 | lib/nfs/Connection: add assertion | Max Kellermann | 1 | -0/+2 | |
2014-12-14 | lib/nfs/Connection: fix reconnect after mount failure | Max Kellermann | 1 | -1/+1 | |
When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect. | |||||
2014-12-14 | lib/nfs/Connection: fix typo in code comment | Max Kellermann | 1 | -1/+1 | |
2014-12-14 | lib/nfs/Connection: fix memory leak (and assertion failure) | Max Kellermann | 3 | -0/+28 | |
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles. | |||||
2014-12-14 | lib/nfs/Connection: move code to Service() | Max Kellermann | 2 | -12/+28 | |
2014-12-14 | lib/nfs/Connection: add assertions | Max Kellermann | 1 | -0/+2 | |
2014-12-14 | lib/nfs/Connection: move code to method InternalClose() | Max Kellermann | 2 | -3/+17 | |
2014-12-14 | lib/nfs/Connection: make in_service and in_event debug-only flags | Max Kellermann | 2 | -0/+11 | |
2014-12-14 | lib/nfs/Connection: fix crash while canceling a failing Open() | Max Kellermann | 1 | -2/+4 | |
The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist. | |||||
2014-12-14 | event/Loop: read the "again" flag while holding mutex | Max Kellermann | 1 | -1/+2 | |
2014-12-14 | lib/nfs/Connection: add assertions | Max Kellermann | 1 | -0/+31 | |
2014-12-12 | util/HugeAllocator: disable MEM_LARGE_PAGES on Windows | Max Kellermann | 1 | -1/+2 | |
MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled. | |||||
2014-12-12 | input/Init: eliminate double colon from log message | Max Kellermann | 1 | -1/+1 | |
2014-12-09 | playlist/Print: don't skip non-existent songs in "listplaylist" | Max Kellermann | 1 | -6/+7 | |
Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print(). | |||||
2014-12-08 | decoder/ffmpeg: support FFmpeg 2.5 | Max Kellermann | 1 | -0/+5 | |
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough. | |||||
2014-12-08 | thread/Id: drop "::" prefix before pthread function names | Max Kellermann | 1 | -2/+2 | |
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl). | |||||
2014-12-01 | Output: start with a null mixer. | Nix | 1 | -0/+1 | |
There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately. | |||||
2014-11-25 | lib/nfs/FileReader: clean up on disconnect | Max Kellermann | 1 | -1/+1 | |
Avoids crash because Close() invokes a call on a destructed NfsConnection. | |||||
2014-11-25 | lib/nfs/FileReader: move code to CancelOrClose() | Max Kellermann | 2 | -0/+16 | |