aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-12-12input/Init: eliminate double colon from log messageMax Kellermann1-1/+1
2014-12-09playlist/Print: don't skip non-existent songs in "listplaylist"Max Kellermann1-6/+7
Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print().
2014-12-08decoder/ffmpeg: support FFmpeg 2.5Max Kellermann1-0/+5
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough.
2014-12-08thread/Id: drop "::" prefix before pthread function namesMax Kellermann1-2/+2
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl).
2014-12-01Output: start with a null mixer.Nix1-0/+1
There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.
2014-11-25lib/nfs/FileReader: clean up on disconnectMax Kellermann1-1/+1
Avoids crash because Close() invokes a call on a destructed NfsConnection.
2014-11-25lib/nfs/FileReader: move code to CancelOrClose()Max Kellermann2-0/+16
2014-11-25lib/nfs/FileReader: reset state in OnNfsConnectionFailed()Max Kellermann1-0/+2
Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already.
2014-11-25lib/nfs/FileReader: update "state" in OnNfsError()Max Kellermann1-0/+24
Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation.
2014-11-25lib/nfs/Manager: defer NfsConnection destructionMax Kellermann2-9/+54
Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning.
2014-11-25lib/nfs/Connection: broadcast error before closing connectionMax Kellermann1-4/+4
During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs.
2014-11-25lib/nfs/Connection: cancel DeferredMonitor on disconnectMax Kellermann1-0/+4
Fixes potential second mount attempt after the old connection to the NFS server was shut down.
2014-11-25lib/nfs/FileReader: include Compiler.h for "final" fallbackMax Kellermann1-0/+1
2014-11-25decoder/mp4v2: remove because of incompatible licenseMax Kellermann3-359/+0
libmp4v2 is licensed under MPL 1.1, which is incompatible with GPLv2. Unfortunately, this means that we must remove the plugin. More information can be found in the Debian bug report: http://bugs.debian.org/767504
2014-11-25event/DeferredMonitor: include cleanupMax Kellermann2-3/+2
2014-11-24archive/zzip: fix inverted error handlerMax Kellermann1-4/+5
Set the Error when zzip_seek()==-1 and not on success. Fixes a crash after seeking.
2014-11-24decoder/{dsdiff,dsf,opus}: fix deadlock while seekingMax Kellermann2-3/+3
2014-11-24Java/File: fix include guardMax Kellermann1-1/+1
2014-11-18QueueCommands: workaround for buggy clients that send "add /"Max Kellermann1-1/+10
2014-11-18Client: assume uid==0 is local socketMax Kellermann2-2/+2
A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected.
2014-11-18event/ServerSocket: fix get_remote_uid() error valueMax Kellermann1-1/+1
Must return -1 on error, not 0. 0 is root.
2014-11-12decoder/opus: add MIME types audio/ogg and application/oggMax Kellermann1-0/+7
2014-11-11Construct a Null AllocatedPath if the filename conversion into UTF8 failedFlorent Le Coz1-1/+5
2014-11-11decoder/opus: support chained streamsMax Kellermann1-1/+36
2014-11-11decoder/opus: move code to HandleEOS()Max Kellermann1-1/+8
2014-11-11decoder/opus: improved error loggingMax Kellermann1-4/+11
2014-11-11decoder/opus: fix mistyped LoadEOSPacket() return valueMax Kellermann1-1/+1
2014-11-11decoder/opus: eliminate flag "found_opus"Max Kellermann1-5/+3
Check opus_decoder!=nullptr instead.
2014-11-11decoder/opus: add constexpr output_buffer_framesMax Kellermann1-8/+10
2014-11-11Main: fix compilation on OS X using non-Apple compilersMisty De Meo1-2/+2
Commit d42c0f1dc5063d50a62817b63a1c2a4507c46071 added an OS X-specific method of calling mpd_main_after_fork(), which uses Grand Central Dispatch. Since this uses a block literal, it breaks compilation on compilers which don't support the block extension, e.g. non-Apple compilers. This affects users on older OS X releases with GCD (which depend on older Clang releases, or Apple GCCs, which don't support the C++11 features MPD needs); or which don't support GCD at all (10.5 and lower). This patch changes the #ifdef so that the non-GCD code is used as it was on OS X before this patch if blocks aren't available, via checking __BLOCKS__ macro.
2014-11-10pcm/SoxrResampler: round output buffer size upMax Kellermann1-1/+2
The old formula calculates the output buffer size with "regular" rounding (to the nearest integer), however sometimes, that is insufficient and the last sample cannot be resampled. This causes audible distortions. By changing the formula to consider the worst case (always round up), this problem is eliminated.
2014-11-10decoder/ffmpeg: support opusMax Kellermann1-1/+2
2014-11-10decoder/audiofile: fix bit rate calculationMax Kellermann1-1/+1
2014-11-10input/curl: ignore ResponseBoundary() while seekingMax Kellermann1-0/+4
While seeking, metadata must not be updated. ResponseBoundary() was added in MPD 0.19.1, but I forgot to add the IsSeeking() check there. This caused the "seekable" flag to reset.
2014-11-08tag/Set: do AlbumArtist/Artist fallback only if AlbumArtist is not disabledMax Kellermann1-0/+2
On "list albumartist", songs that have no AlbumArtist tag will use the Artist tag. However, if AlbumArtist is disabled via "metadata_to_use", the TagBuilder::AddItem() call is ignored, and PrintUniqueTag() attempts to print a nullptr string. This commit fixes the problem by attempting the fallback only if AlbumArtist is not disabled.
2014-11-08db/Count: include cleanupMax Kellermann1-1/+1
2014-11-07decoder/ffmpeg: support opusMax Kellermann1-1/+2
2014-11-07db/upnp: fix valgrind warningMax Kellermann1-0/+1
2014-11-07lib/upnp/ContentDirectoryService: swap uri_apply_base() parametersMax Kellermann1-1/+1
When uri_apply_base() was moved from db/upnp/Util.cpp to util/UriUtil.cpp, the parameter order was changed, however without swapping the parameters in the ContentDirectoryService constructor.
2014-11-07input/AsyncInputStream: set Error when seeking unseekableMax Kellermann1-1/+4
Fixes crash in the "audiofile" decoder while logging the seek error.
2014-11-07input/Open: expose input_domainMax Kellermann3-2/+52
2014-11-02input/curl: forget Content-Length (and more) after redirectMax Kellermann1-0/+26
Fixes playback of redirected streams.
2014-11-02AsyncInputStream: add method ClearTag()Max Kellermann1-0/+4
2014-11-02InputStream: add method ClearMimeType()Max Kellermann1-0/+4
2014-11-02input/curl: fix curl_easy_setopt() parameter typesMax Kellermann1-4/+4
2014-11-02Decoder, Playlist: ignore URI query string for plugin detectionMax Kellermann2-6/+8
Use the new uri_get_suffix() overload that removes the query string.
2014-11-02util/UriUtil: add uri_get_suffix() overload that ignores query stringMax Kellermann2-0/+28
2014-11-02PlaylistFile: don't allow empty playlist nameMax Kellermann1-0/+4
2014-11-02playlist/m3u: recognize the file suffix ".m3u8"Max Kellermann2-1/+3
2014-11-02decoder/faad: remove workaround for ancient libfaad2 ABI bugMax Kellermann1-10/+2
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 11:15:12 +0000