aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-12-26db/simple: fix implicit nullptr/bool conversionMax Kellermann3-5/+5
Return false on error, not nullptr.
2014-12-26fs/Traits, ...: work around -Wtautological-pointer-compareMax Kellermann5-1/+32
New in clang 3.6.
2014-12-26db/lazy, input/mms: add "override" keywordsMax Kellermann3-4/+6
Fixes -Winconsistent-missing-override (clang 3.6).
2014-12-26db/proxy, output/shout: fix implicit nullptr/bool conversionMax Kellermann2-4/+4
Return false on error, not nullptr.
2014-12-26db/{simple,proxy}, ...: add "override" keywordsMax Kellermann7-22/+26
Fixes -Winconsistent-missing-override (clang 3.6).
2014-12-26util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compareMax Kellermann10-0/+51
New in clang 3.6.
2014-12-26DatabaseGlue: convert nullptr check to assertionMax Kellermann1-3/+2
2014-12-26util/ASCII: fix indentMax Kellermann1-10/+10
2014-12-26Compiler.h: add macro CLANG_CHECK_VERSION()Max Kellermann1-0/+7
2014-12-26Compiler.h: add macro GCC_OLDER_THAN()Max Kellermann2-4/+12
2014-12-26util/Manual: reimplement GCC_CHECK_VERSION() using GCC_MAKE_VERSION()Max Kellermann1-4/+3
2014-12-26Compiler.h: add macro GCC_MAKE_VERSION()Max Kellermann1-6/+4
2014-12-23decoder/ffmpeg: support interleaved floating pointMax Kellermann1-0/+1
2014-12-23input/mms: limit the mmsx_read() sizeMax Kellermann1-0/+7
2014-12-23decoder/DsdLib: add missing stdlib.h includeMax Kellermann1-0/+1
2014-12-23DSF ID3 tags hitting 4k size limitJan Brittenson1-6/+12
Here's a change to dynamically allocate the DSD ID3 tag buffer. Pretty much anything with cover art is going to exceed the existing, static 4k limit... Here's a change to dynamically allocate the buffer and sanity check it at some upper limit. I rather arbitrarily pulled 256k out of thin air just to keep a corrupt file from causing it to trying to allocate a buffer larger than available memory.
2014-12-17LogBackend: force-flush stderr on WIN32Max Kellermann1-0/+6
setvbuf() does not seem to have an effect on Windows.
2014-12-17LogInit: make stderr line-bufferedMax Kellermann1-0/+3
Make sure everything gets logged right away. No delays because stdio's buffer is not yet full.
2014-12-17util/HugeAllocator: enable MEM_COMMIT on WindowsMax Kellermann1-1/+3
Without MEM_COMMIT, the reserved address space is not accessible, and MPD crashes.
2014-12-16playlist/embcue: fix filename suffix detectionk441-1/+1
The definition of the playlist_plugin struct member of the embcue plugin was incorrect.
2014-12-15storage/nfs: add timeoutMax Kellermann2-3/+13
2014-12-15decoder/ffmpeg: detect and fix negative time stampsMax Kellermann1-4/+7
Works around assertion failure due to something that appears to be a (minor) FFmpeg bug.
2014-12-15storage/nfs: clear last_error in SetState()Max Kellermann1-0/+1
Fixes bogus assertion failure.
2014-12-15lib/nfs/Connection: unregister socket with SocketMonitor::Steal()Max Kellermann1-1/+1
SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event.
2014-12-15lib/nfs/Connection: implement mount timeoutMax Kellermann2-2/+31
2014-12-15lib/nfs/Connection: add debug flag "in_destroy"Max Kellermann2-0/+11
2014-12-14lib/nfs/Connection: add assertionMax Kellermann1-0/+2
2014-12-14lib/nfs/Connection: fix reconnect after mount failureMax Kellermann1-1/+1
When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
2014-12-14lib/nfs/Connection: fix typo in code commentMax Kellermann1-1/+1
2014-12-14lib/nfs/Connection: fix memory leak (and assertion failure)Max Kellermann3-0/+28
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
2014-12-14lib/nfs/Connection: move code to Service()Max Kellermann2-12/+28
2014-12-14lib/nfs/Connection: add assertionsMax Kellermann1-0/+2
2014-12-14lib/nfs/Connection: move code to method InternalClose()Max Kellermann2-3/+17
2014-12-14lib/nfs/Connection: make in_service and in_event debug-only flagsMax Kellermann2-0/+11
2014-12-14lib/nfs/Connection: fix crash while canceling a failing Open()Max Kellermann1-2/+4
The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist.
2014-12-14event/Loop: read the "again" flag while holding mutexMax Kellermann1-1/+2
2014-12-14lib/nfs/Connection: add assertionsMax Kellermann1-0/+31
2014-12-12util/HugeAllocator: disable MEM_LARGE_PAGES on WindowsMax Kellermann1-1/+2
MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled.
2014-12-12input/Init: eliminate double colon from log messageMax Kellermann1-1/+1
2014-12-09playlist/Print: don't skip non-existent songs in "listplaylist"Max Kellermann1-6/+7
Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print().
2014-12-08decoder/ffmpeg: support FFmpeg 2.5Max Kellermann1-0/+5
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough.
2014-12-08thread/Id: drop "::" prefix before pthread function namesMax Kellermann1-2/+2
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl).
2014-12-01Output: start with a null mixer.Nix1-0/+1
There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.
2014-11-25lib/nfs/FileReader: clean up on disconnectMax Kellermann1-1/+1
Avoids crash because Close() invokes a call on a destructed NfsConnection.
2014-11-25lib/nfs/FileReader: move code to CancelOrClose()Max Kellermann2-0/+16
2014-11-25lib/nfs/FileReader: reset state in OnNfsConnectionFailed()Max Kellermann1-0/+2
Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already.
2014-11-25lib/nfs/FileReader: update "state" in OnNfsError()Max Kellermann1-0/+24
Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation.
2014-11-25lib/nfs/Manager: defer NfsConnection destructionMax Kellermann2-9/+54
Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning.
2014-11-25lib/nfs/Connection: broadcast error before closing connectionMax Kellermann1-4/+4
During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs.
2014-11-25lib/nfs/Connection: cancel DeferredMonitor on disconnectMax Kellermann1-0/+4
Fixes potential second mount attempt after the old connection to the NFS server was shut down.