| Commit message (Collapse) | Author | Files | Lines |
|---|
|
Moved some code to tag_get_value_checked(), to eliminate several NULL
checks.
|
|
Use GMutex/GCond instead of the notify library. Manually lock the
player_control object before accessing the protected attributes. Use
the GCond object to notify the player thread and the main thread.
|
|
Right after seeking and song change, the elapsed_time shows old
information, because the output thread didn't finish a full chunk
yet. This patch re-adds a second elapsed_time variable, and keeps
track of a fallback value, in case the output thread can't provide a
reliable value.
|
|
Return false when there was no chunk in the pipe. If the function
returns true, then audio_output_task() will not wait for a notify from
the player thread. This fixes a race condition.
|
|
Don't set the error in play_chunk(); do all the error handling in the
caller. The errored_song attribute isn't set anymore; it doesn't make
sense for PLAYER_ERROR_AUDIO.
|
|
Call a version of audio_output_close() which doesn't lock recursively.
|
|
|
|
Always keep the audio_output object locked within the output thread,
unless a plugin method is called. This fixes several race conditions.
|
|
drain() is the opposite of cancel(): it waits until all data in the
buffer has finished playing. Instead of implicitly draining in the
close() method like the ALSA plugin has been doing it forever, let the
output thread decide whether to drain or to cancel.
|
|
The recovery is for nothing if we get CLOSE afterwards. Let's not
recover in the cancel() method, and let the next play() call sort it
out.
|
|
Don't call filter_close() right after ao_close().
|
|
This variable was uninitialized and led to crashes.
|
|
libavformat gives us the song artist in the "author" field. Since we
use av_metadata_conv(), we don't need to check for "artist".
|
|
Convert the metadata with the libavformat function av_metadata_conv().
This ensures that canonical tag names are provided by libavformat, and
we can remove the "artist" vs "author" workaround.
|
|
When you disable the "follow_outside_symlinks" or the
"follow_inside_symlinks" setting, the next update should remove the
now-ignored files from the database.
|
|
|
|
|
|
|
|
|
|
|
|
Don't connect to JACK before MPD has daemonized.
|
|
Don't connect to PulseAudio before MPD has daemonized.
|
|
With these methods, an output plugin can allocate some global
resources only if it is actually enabled. The method enable() is
called after daemonization, which allows for more sophisticated
resource allocation during that method.
|
|
Don't let the mixer plugin "override" the libpulse callbacks.
Instead, add a "mixer" attribute to the pulse_output struct, and call
the mixer on all interesting events.
|
|
A mixer is useful enough if it can be read. Setting it may be
found unavailable at runtime.
|
|
If the method get_volume() returns -1 and no error object is set, then
the volume is currently unavailable, but the mixer should not be
closed immediately.
|
|
It's possible to have a mixer implementation which does not explicitly
need the methods open() and close().
|
|
Moved the check from pulse_mixer_open() to pulse_mixer_update().
|
|
|
|
There's no point in clearing the audio format before exiting.
|
|
This way, the function call in the main() function does not need
another pair of #ifdef/#endif.
|
|
|
|
Based on the XSPF playlist plugin.
|
|
Added a missing "break".
|
|
An asterisk means that this attribute should not be enforced, and
stays whatever it used to be. This way, some configuration values
work like masks.
|
|
|
|
This allows more sophisticated audio format selection.
|
|
It's a double pointer.
|
|
The value is always non-NULL.
|
|
|
|
.. and keep up the JACK connection while MPD runs. Allocate the ring
buffers on the first open, and free them at MPD exit.
|
|
JACK doesn't need cancel() because it won't do much anyway. Buffers
are small.
|
|
It's a double pointer.
|
|
Don't disconnect from JACK during pause.
|
|
|
|
This is a complete rewrite of the PulseAudio output plugin. It uses
the asynchronous API, which gives us more control over everything.
Additionally, it connects to the PulseAudio server on startup, and
keeps this connection up while MPD runs. During pause, instead of
closing the stream, it enables "cork".
|
|
This allows the mixer object to access its associated audio output
object.
|
|
Flush the hardware volume cache, and send the MIXER idle event. This
allows mixer plugins to detect volume changes.
|
|
Basically the same as the 0.15.5 patch "check again if output is open
on CANCEL". Same race condition, same fix.
|
|
|
