aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-08-25decoder/vorbis: open file in "binary" modeGunnar Roth1-1/+1
fopen change for win32 in tag dup of vorbis win32 adaption for head changes
2009-08-24output/recorder: new output plugin for recording radio streamsMax Kellermann2-0/+218
The recorder plugin writes audio played by MPD to a file. This may be useful for recording radio streams. This implementation is incomplete, because support for tags is missing, and MPD should be able to record each track to a different file.
2009-08-24conf: removed the deprecated "error_file" optionMax Kellermann2-2/+0
This option was deprecated by the 0.15 release. This patch makes this option invalid.
2009-08-14output/shout: minimize the unpause latencyMax Kellermann1-0/+7
During the pause loop, manually sleep for 500ms if shout_delay() returns a value greater than that. Don't exhaust libshout's buffer.
2009-08-14output: fixed shout stuck pause bugMax Kellermann3-0/+20
Explicitly make the output thread leave the ao_pause() loop. This patch is a workaround, and the "pause" flag is not managed in a thread-safe way, but that's good enough for now.
2009-08-14directory: free empty directories after removing them (memleak)Max Kellermann1-3/+8
dirvec_delete() does not free the object, we have to call directory_free() afterwards.
2009-08-14update: free temporary string in container scan (memleak)Max Kellermann1-2/+6
The return value of map_directory_child_fs() must be freed.
2009-08-14decoder/flac: don't allocate cuesheet twice (memleak)Max Kellermann1-4/+6
The function flac_cue_track() first calls FLAC__metadata_object_new(), then overwrites this pointer with FLAC__metadata_get_cuesheet(). This allocate two FLAC__StreamMetadata objects, but the first pointer is lost, and never freed.
2009-08-14update: free empty path string (memleak)Max Kellermann1-1/+2
When you pass an empty string to directory_update_init(), it was not freed by update_task().
2009-08-13decoder_control: protect command, state with a mutexMax Kellermann6-31/+241
Replace decoder_control.notify with decoder_control.mutex and decoder_control.cond. Lock the mutex on all accesses to decoder_control.command and decoder_control.state.
2009-08-13use daemon() when the C library provides itMike Frysinger1-6/+18
For systems that cannot support fork() (like no-mmu Linux), use daemon() if it is available for the daemonizing code. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2009-08-04tag_id3: moved id3_genre_name() call to tag_id3_import_text()Max Kellermann1-6/+6
The ID3_FRAME_GENRE field is queried only in tag_id3_import_text(). Don't pass the tag type to import_id3_string().
2009-08-04tag_id3: splitted function tag_id3_import_frame()Max Kellermann1-119/+91
Splitted tag_id3_import_frame() into two specialized functions: tag_id3_import_text() and tag_id3_import_comment(). Use id3_frame_field() instead of directly accessing id3_frame.fields.
2009-08-04tag_id3: corrected parameter typesMax Kellermann1-2/+3
Changed "int type" to "enum tag_type". Converted "int is_id3v1" to "bool".
2009-08-04tag_id3: converted tag_is_id3v1() to an inline functionMax Kellermann1-1/+6
Prefer C over CPP.
2009-08-04tag_id3: no CamelCaseMax Kellermann1-57/+64
Renamed functions.
2009-08-03ffmpeg_plugin: convert metadata to generic formatAnton Khirnov1-1/+3
2009-07-29command: moved command_process_list() to client.cMax Kellermann3-35/+30
2009-07-28playlist: CamelCaseIsBadCourtney Cavin11-107/+128
Renamed all playlist functions to non-CamelCase.
2009-07-28input/lastfm: Ensure multiple identical xml entities are decoded.Courtney Cavin1-6/+5
Previously, if two identical entities appeared in one string, only the first would get decoded. This fixes that bug.
2009-07-28client: splitted client.c into several piecesMax Kellermann11-875/+1129
The soure file client.c has nearly 1000 lines, time for splitting it into smaller pieces to improve readability.
2009-07-28client: moved struct client to client_internal.hMax Kellermann2-44/+69
Prepare splitting client.c into several sources.
2009-07-28input/lastfm: use metadataCourtney Cavin1-43/+297
Added a patch to flush out the last.fm input plugin slightly. It basically turns it into a wrapper for the appropriate plugin. Most notably metadata is now extracted.
2009-07-28cmdline: obey $(sysconfdir) for default mpd.conf locationMax Kellermann1-1/+0
Instead of hard-coding the path "/etc/mpd.conf", use the configured $(sysconfdir) path. This can be set with: ./configure --sysconfdir=/etc Note that this changes the default path to "/usr/local/etc/mpd.conf", given the default prefix "/usr/local". This is actually more correct than the old default.
2009-07-23client: moved some code to client_list_X()Max Kellermann1-13/+51
Make the client list management a separate sub-library.
2009-07-23client: don't include socket headersMax Kellermann1-10/+0
The client code uses portable GLib I/O functions and doesn't need the OS specific socket headers.
2009-07-23player_thread: don't use precalculated size_to_timeMax Kellermann2-22/+4
Calculate the total play time with the audio_format object each time, using audio_format_time_to_size(). The function audioFormatSizeToTime() is not needed anymore, and will be removed with this patch.
2009-07-23player_thread: moved code to update_song_tag()Max Kellermann1-19/+27
2009-07-23pcm_convert: use GError for error handlingMax Kellermann10-115/+177
Don't abort the whole MPD process when the conversion fails. This has been a denial-of-service attack vector for years.
2009-07-22pcm_resample_fallback: don't include glib.hMax Kellermann1-1/+0
This library does not use GLib directly.
2009-07-22pcm_resample_fallback: removed G_GNUC_UNUSED attributeMax Kellermann2-6/+3
2009-07-22pcm_channels: num_channels is unsignedMax Kellermann2-12/+12
You cannot have a negative number of channels, let's pass it as uint8_t instead of int8_t.
2009-07-22pcm_byteswap: converted NULL checks to assertionsMax Kellermann2-10/+5
It is illegal to pass a NULL buffer to pcm_byteswap_X(). The result of this is that pcm_byteswap_X() never returns NULL.
2009-07-22pcm_convert: added pcm_convert_state.byteswap_bufferMax Kellermann2-3/+8
Currently, byteswapping is performed on the format_buffer. This can go wrong when this buffer is used twice during one run. Add a separate buffer for swapping the byte order.
2009-07-22filter/volume: check the flag audio_format.reverse_endianMax Kellermann1-0/+7
The volume plugin does not work for reverse_endian samples.
2009-07-22audio_format: added API documentationMax Kellermann1-0/+48
2009-07-22audio_format: initialize reverse_endian in audio_format_init()Max Kellermann1-0/+1
This line was missing in the reverse_endian patch, and led to undefined values and crashes in that attribute.
2009-07-22daemon: daemonize_close_stdin() optimised.Michal Nazarewicz2-12/+7
Changed function to first close standard input (this may fail but we don't care) and then try to open /dev/null (this may fail but it shouldn't on Unix platforms plus we don't know what to do in such case anyways). Since standard input has the "zeroth" descriptor number next "open" will use it. Since there is no "/dev/null" on Windows (It's not even a valid path!) the second step is skipped if WIN32 is defined. As a final touch, since the function consists of merely two function calls it has been moved to header file and declared static inline. [mk: un-inline daemonize_close_stdin()]
2009-07-22cmdline: renamed options.stderr to options.log_stderrEugeny N Dzhurinsky3-6/+6
On FreeBSD, "stderr" is a macro, and using this name for a struct member breaks the build. [mk: renamed _stderr to log_stderr]
2009-07-22decoder/flac: fixed indentation of flac_comment_value()Max Kellermann1-19/+21
2009-07-22decoder/flac: parse all replaygain tagsMax Kellermann1-14/+18
The FLAC replaygain parser used the "||" operator. This made the code stop after the first value which was found.
2009-07-22decoder/flac: return early from flac_find_float_comment()Max Kellermann1-21/+22
When one metadata check fails, return quickly. This removes 2 levels of indent.
2009-07-22decoder/flac: removed misplaced authorship commentMax Kellermann1-1/+0
This belongs into "git annotate" or AUTHORS.
2009-07-22mad: skip ID3 frames when libid3tag is disabledMax Kellermann1-6/+28
When libid3tag is disabled, the libmad decoder plugin is unable to identify ID3 frames. If the file starts with an (unidentified) ID3 frame, it assumes that the file is not a valid MP3 song. This patch solves this by adding minimal stubs for the ID3 functions.
2009-07-19Support wrong-endian ALSA outputDavid Woodhouse1-2/+50
2009-07-19Add reverse_endian field to struct audio_format and handle conversionDavid Woodhouse6-5/+151
2009-07-19tag_ape: simplified the apeItems arrayMax Kellermann1-22/+12
Make "enum tag_type" the array index, and convert apeItems to a sparse array.
2009-07-19tag_ape: moved code to tag_ape_import_item()Max Kellermann1-12/+22
Improve code readability.
2009-07-19tag_ape: converted apeItems and tagItems to global varsMax Kellermann1-20/+20
Don't initialize those arrays each time tag_ape_load() is called.
2009-07-19Add audio_format_init() functionDavid Woodhouse15-53/+39
It makes no difference right now, but we're about to add an endianness flag and will want to make sure it's correctly initialised every time.