| Commit message (Collapse) | Author | Files | Lines |
|---|
|
For systems that cannot support fork() (like no-mmu Linux), use daemon() if
it is available for the daemonizing code.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
|
|
The ID3_FRAME_GENRE field is queried only in tag_id3_import_text().
Don't pass the tag type to import_id3_string().
|
|
Splitted tag_id3_import_frame() into two specialized functions:
tag_id3_import_text() and tag_id3_import_comment(). Use
id3_frame_field() instead of directly accessing id3_frame.fields.
|
|
Changed "int type" to "enum tag_type". Converted "int is_id3v1" to
"bool".
|
|
Prefer C over CPP.
|
|
Renamed functions.
|
|
|
|
|
|
Renamed all playlist functions to non-CamelCase.
|
|
Previously, if two identical entities appeared in one string, only the
first would get decoded. This fixes that bug.
|
|
The soure file client.c has nearly 1000 lines, time for splitting it
into smaller pieces to improve readability.
|
|
Prepare splitting client.c into several sources.
|
|
Added a patch to flush out the last.fm input plugin slightly. It
basically turns it into a wrapper for the appropriate plugin. Most
notably metadata is now extracted.
|
|
Instead of hard-coding the path "/etc/mpd.conf", use the configured
$(sysconfdir) path. This can be set with:
./configure --sysconfdir=/etc
Note that this changes the default path to "/usr/local/etc/mpd.conf",
given the default prefix "/usr/local". This is actually more correct
than the old default.
|
|
Make the client list management a separate sub-library.
|
|
The client code uses portable GLib I/O functions and doesn't need the
OS specific socket headers.
|
|
Calculate the total play time with the audio_format object each time,
using audio_format_time_to_size(). The function
audioFormatSizeToTime() is not needed anymore, and will be removed
with this patch.
|
|
|
|
Don't abort the whole MPD process when the conversion fails. This has
been a denial-of-service attack vector for years.
|
|
This library does not use GLib directly.
|
|
|
|
You cannot have a negative number of channels, let's pass it as
uint8_t instead of int8_t.
|
|
It is illegal to pass a NULL buffer to pcm_byteswap_X(). The result
of this is that pcm_byteswap_X() never returns NULL.
|
|
Currently, byteswapping is performed on the format_buffer. This can
go wrong when this buffer is used twice during one run. Add a
separate buffer for swapping the byte order.
|
|
The volume plugin does not work for reverse_endian samples.
|
|
|
|
This line was missing in the reverse_endian patch, and led to
undefined values and crashes in that attribute.
|
|
Changed function to first close standard input (this may
fail but we don't care) and then try to open /dev/null (this
may fail but it shouldn't on Unix platforms plus we don't
know what to do in such case anyways). Since standard input
has the "zeroth" descriptor number next "open" will use it.
Since there is no "/dev/null" on Windows (It's not even
a valid path!) the second step is skipped if WIN32 is
defined.
As a final touch, since the function consists of merely two
function calls it has been moved to header file and declared
static inline.
[mk: un-inline daemonize_close_stdin()]
|
|
On FreeBSD, "stderr" is a macro, and using this name for a struct
member breaks the build.
[mk: renamed _stderr to log_stderr]
|
|
|
|
|
|
Make "enum tag_type" the array index, and convert apeItems to a sparse
array.
|
|
Improve code readability.
|
|
Don't initialize those arrays each time tag_ape_load() is called.
|
|
It makes no difference right now, but we're about to add an endianness
flag and will want to make sure it's correctly initialised every time.
|
|
Several functions work with the wrong return type, this patch fixes
them.
|
|
|
|
|
|
|
|
The new code is more robust and more flexible. It provides detailed
error information in GError objects.
|
|
On Windows only daemonize_close_stdin() function does
something. Other functions are either empty or generate an
error. Those have been moved to header file and declared
static inline so compiler can remove the call all together.
|
|
The functions were not "const" (they examined values pointed
by arguments passed to them, quoting gcc's doc: "Note that
a function that has pointer arguments and examines the data
pointed to must _not_ be declared 'const'.") but rather
"pure" and still not all of them.
Note also, that even some of the functions declared "pure"
are not pure, however, due to reasons stated in source code
the attribute has been kept.
|
|
The "group" configuration option is similar to "user" as it
sets user set what group MPD shall run as. With "user"
option, MPD changed GID to the GID of the user, however,
more control could be desired.
Moreover, the patch changes the way of checking whether no
setuid(2)/setgid(2) is required -- previously user names
were compered, now UID and GIDs are compered (ie. the one we
already have (getuid(2)/getgid(2)) with the one we want to
change to).
|
|
The GLib functions are more portable.
|
|
Added another glue function in main().
|
|
The glue_*() functions act as a glue between MPD's main() function and
its libraries. They handle disabled features, and pass validated
configuration options.
|
|
No CamelCase.
|
|
Since version 0.14, MPD has been logging to standard error instead of
standard output. The option name should reflect that. The old option
continues to work, we will remove it in a future MPD release.
|
|
Renamed type, variables and functions.
|
|
Add the "const" attribute to functions when their return value only
depends on parameters. This allows gcc to eliminate some function
calls.
|
