aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-02-25output/jack: rename variable sample_size to jack_sample_sizeMax Kellermann1-5/+6
2011-02-15Insure proper initialization of stack-allocated struct.Christopher Brannon1-1/+4
Version 1.0.0 of the libao library added a new field to the ao_sample_format struct. It is a char * named matrix. When an ao_sample_format is allocated on the stack, this field contains garbage. The proper course is to insure that is initialized to NULL. NULL indicates that we do not want any mapping. The struct is now initialized using a static initializer, and this technique is compatible with all known versions of libao.
2011-01-31update: log all file permission problemsMax Kellermann1-0/+6
2011-01-14Fix NDEBUG testAndreas Wiese1-1/+1
<stdbool.h> needs to be included unconditionally from definition of NDEBUG, since »bool« doesn't get defined otherwise. Signed-off-by: Andreas Wiese <aw-devel@meterriblecrew.net>
2011-01-07encoder/lame: explicitly configure the output sample rateMax Kellermann1-0/+7
When you don't explicitly set an output sample rate, liblame tries to guess an output sample rate from the input sample rate. You would think that this "guessing" consists of just setting both equal, but that is not the case. For 44.1kHz at 96kbit/s, liblame chooses 32kHz. This patch explicitly configures the output sample rate, to stop the bad guessing.
2011-01-07output/httpd: define G_LOG_DOMAIN in httpd_client.cMax Kellermann1-0/+3
2010-12-21directory: fix warning "comparison between signed and unsigned"Max Kellermann1-2/+2
Cast the constant to dev_t, not to unsigned.
2010-12-21zeroconf-bonjour: use g_htons() instead of htons()Max Kellermann1-1/+1
Fixes the gcc warning "implicit declaration of function 'htons'".
2010-11-08output/shout: artist comes first in stream titleMax Kellermann1-1/+1
After popular demand, I've switched the order of "artist" and "title" in the stream title. There is no standard, and there is no reliable way to parse those from the stream title.
2010-11-08input/rewind: fix assertion failureMax Kellermann1-1/+1
The assertion added in MPD 0.15.14 was too much, it failed when the MIME type of a stream was NULL.
2010-11-05player_thread: fix assertion failure due to wrong music pipe on seekMax Kellermann1-0/+8
When one song is played twice, and the decoder is working on the second "instance", but the first should be seeked, the check in player_seek_decoder() may assume that it can reuse the decoder without exchanging pipes. The last thing was the mistake: the pipe pointer was different, which led to an assertion failure. This patch adds another check which exchanges the player pipe.
2010-11-05decoder_control: pass music_pipe to dc_start()Max Kellermann3-12/+18
More abstraction for decoder_control.pipe.
2010-11-05player_thread: add helper function player_dc_at_next_song()Max Kellermann1-6/+33
Some abstraction for decoder_control.pipe access.
2010-11-05pipe: add helper function music_pipe_empty()Max Kellermann3-4/+10
2010-11-05input/rewind: remove redundant NULL check before g_free() callMax Kellermann1-2/+1
2010-11-05input/rewind: add two assertionsMax Kellermann1-0/+3
2010-11-05input/rewind: fix double free bugMax Kellermann1-0/+1
Duplicate the "mime" attribute of the inner input_stream object, instead of copying the pointer.
2010-11-05decoder/{mp4ff,ffmpeg}: add extension ".m4b" (audio book)Max Kellermann2-2/+10
Same as ".m4a".
2010-11-04output_thread: fix assertion failure due to race condition in OPENMax Kellermann1-1/+9
Change the assertion on "fail_timer==NULL" in OPEN to a runtime check. This assertion crashed when the output thread failed while the player thread was calling audio_output_open().
2010-11-04output_internal: protect attribute "fail_timer" with mutexMax Kellermann2-1/+7
2010-11-04output_control: lock object in audio_output_open()Max Kellermann1-6/+19
Protect the attributes "open" and "fail_timer".
2010-11-04output_control: lock object in audio_output_close()Max Kellermann1-2/+28
Protect the attributes "open" and "fail_timer".
2010-10-03output/httpd: MIME type audio/ogg for Ogg VorbisMax Kellermann1-1/+1
RFC 5334 10.3 defines the MIME type "audio/ogg". We could use "application/ogg" as well, but we know for sure that we only emit audio data.
2010-09-28input/rewind: enable for MMSThomas Jansen1-2/+10
2010-09-23rewind_input_plugin: Update MIME not only onceThomas Jansen1-3/+4
The assumption that MIME type is set only once is not valid with CURL, as URL redirections may update the MIME type. This fixes bug #3044.
2010-09-08Correctly terminate stream_title.Qball Cow1-0/+1
This caused random data to be send via icy-server if the played song had no tags.
2010-09-07input/curl: fix version check for curl_multi_timeout()Max Kellermann1-1/+1
According to the CURL web site, curl_multi_timeout() was added in version 7.15.4: http://curl.haxx.se/libcurl/c/curl_multi_timeout.html
2010-08-19output_thread: fix race condition after CANCEL commandMax Kellermann1-0/+10
Clear the notification before finishing the CANCEL command, so the notify_wait() after that will always wait for the right notification, sent by audio_output_all_cancel().
2010-08-19notify: add function notify_clear()Max Kellermann2-0/+12
2010-07-20input/curl: remove assertion after curl_multi_fdset()Max Kellermann1-2/+0
Some users reported that MPD crashes when using a new CURL version with the threaded DNS resolver enabled. It seems that curl_multi_fdset() returns no file descriptor when the DNS resolver runs in another thread, so MPD does not have any event to wait for. On the CURL mailing list, somebody suggested to sleep for a fixed amount of time. This is not an elegant solution, because daemons should never have to sleep without waiting for an event. I hope the CURL developers will review the API and remove the threaded DNS resolver. Meanwhile, I'm removing the assertion in question, to allow those unfortunate users running the latest CURL version to continue using MPD.
2010-07-20input/curl: query timeout from CURLMax Kellermann1-1/+18
Use curl_multi_timeout() to determine the select() timeout, instead of hard-coding one second.
2010-07-20tag_rva2: set "gain", not "peak"Max Kellermann1-2/+2
RVA2 tags only store the "gain" value, there is no "peak" attribute.
2010-07-20decoder/mad: parse_rva2() returns boolMax Kellermann1-9/+8
2010-07-20decoder/wildmidi: support version 0.2.3Max Kellermann1-0/+4
In libwildmidi 0.2.3, the function WildMidi_SampledSeek() was removed, without changing the SO name. This patch adds an autoconf check for that function. Fall back to WildMidi_FastSeek() if WildMidi_SampledSeek() is not available anymore.
2010-06-30decoder/ffmpeg: fix libavformat 0.6 by using av_open_input_stream()Max Kellermann1-82/+52
libavformat 0.6 does not pass the original URI pointer to the "open" method, which leads to a crash because MPD was using a dirty hack to pass a pointer to that method. This patch switches to av_open_input_stream() with a custom ByteIOContext class, instead of doing the URI string hack with av_open_input_file(). Loosely based on a patch from Jasper St. Pierre.
2010-06-30decoder/ffmpeg: manual format probingMax Kellermann1-4/+47
Use the libavformat function av_probe_input_format() to probe the AVInputFormat, instead of letting av_open_input_file() do it implicitly. We will switch to av_open_input_stream() very soon, which does not have the probing code. Loosely based on a patch from Jasper St. Pierre.
2010-06-30decoder/ffmpeg: free URI, fix memory leakMax Kellermann1-1/+3
Free the string allocated by decoder_get_uri().
2010-06-30decoder/vorbis: handle uri==NULLMax Kellermann1-0/+3
This fixes a theoretical crash, which has never occurred in practice.
2010-06-30ffmpeg: read more metadata.Anton Khirnov1-1/+10
2010-06-30decoder/ffmpeg: free AVFormatContext on errorMax Kellermann1-0/+4
Fix a memory leak in some code paths.
2010-06-30pcm_buffer: make the buffer pointer "void"Max Kellermann1-1/+1
2010-06-30decoder/mp4ff: support tag "album artist"Max Kellermann1-0/+1
We already supported "albumartist", but it seems some folks also use "album artist" (with a space).
2010-06-30Make get_remote_uid() work on BSDAndreas Vögele1-1/+7
I've attached a patch that will make file URIs work on operating systems that provide the getpeereid() function call to check the user ID of the peer connected to a UNIX domain socket.
2010-06-30playlist: emit IDLE_OPTIONS when resetting single modeMax Kellermann1-0/+3
2010-06-30directory_print: return voidMax Kellermann2-7/+3
There is no useful return value here.
2010-06-30decoder/mikmod: fix memory leakMax Kellermann1-2/+4
The return value of Player_LoadTitle() is allocated with malloc(), and must be freed by the caller.
2010-06-30decoder/mp4ff: remove duplicate entries in the tag name tableMax Kellermann1-9/+5
Reuse the function tag_name_parse_i().
2010-06-30decoder/mp4ff: moved code to mp4ff_tag_name_parse()Max Kellermann1-1/+7
2010-06-30tag_ape: remove duplicate entries in the tag name tableMax Kellermann1-7/+5
Reuse the function tag_name_parse_i().
2010-06-30tag: added function tag_name_parse()Max Kellermann3-12/+60
Convert a string into a tag_type enum.