aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2010-03-17player_thread: postpone song tags during cross-fadeMax Kellermann1-0/+27
Previously, tags of the new song being cross-faded in were sent immediately. That can cause wrong information being displayed, because the "previous" song might send its tag at the end again, overriding the "next" song's tag. This patch saves & merges the tag of the next song, and sends it when cross-fading is finished, and the next song really starts.
2010-03-17tag: added function tag_merge_replace()Max Kellermann3-21/+26
Like tag_merge(), but can deal with NULL parameters, and frees both tag objects.
2010-03-17decoder/mpcdec: fix negative shift on fixed-point samplesPiotr Gozdur1-1/+1
"There is a bug in fixed-point musepack (musepack_src_r435) playback. In floating-point audio is OK but in fixed audio is distorted. I have made a patch for this"
2010-03-07playlist: fix single+repeat in random modeMax Kellermann1-1/+2
With single+repeat enabled, it is expected that MPD repeats the current song over andd over. With random mode also enabled, this didn't work, because the song order was shuffled internally. This patch adds a special check for this case.
2010-02-27decoder/mad: fix crash when seeking at end of songMax Kellermann1-4/+0
Removed the decoder_command_finished() call at the end of mp3_decode(). This is invalid, because decoder_command_finished() has already been called in mp3_read().
2010-01-17decoder/ffmpeg: added more MIME typesMax Kellermann1-0/+6
Taken from the ffmpeg sources.
2010-01-17decoder/ffmpeg: append file name suffix to virtual stream URLMax Kellermann1-4/+28
To allow libavformat to detect the format of the input file, append the suffix of the input file to the URL of the virtual stream. This specifically enables the "shorten" codec, which is supported by libavformat/raw.c, detected only by the suffix.
2010-01-16queue: don't repeat current song in consume modeMax Kellermann1-2/+2
Check consume mode in queue_next_order(), because the current song would be deleted as soon as it's finished; it cannot be played again.
2010-01-16decoder_thread: fix CUE track playbackMax Kellermann1-5/+10
The patch "input/file: don't fall back to parent directory" introduced a regression: when trying to play a CUE track, decoder_run_song() tries to open the file as a stream first, but this fails, because the path is virtual. This patch fixes decoder_run_song() (instead of reverting the previous patch) to accept input_stream_open() failures if the song is a local file. It passes the responsibility to handle non-existing files to the decoder's file_decode() method.
2010-01-02dbUtils: return empty tag value only if no value was foundMax Kellermann1-1/+4
This fixes a regression in the patch "return multiple tag values per song": even when the song has values for the specified tag type, the empty string gets added to the set, because the "return" was removed. This patch adds a flag which remembers whether at least one value was found.
2009-12-30input/curl: removed the built-in rewinding codeMax Kellermann1-181/+10
This has been reimplemented in the "rewind" input plugin.
2009-12-29input/rewind: new input_stream wrapper to allow stream rewindingMax Kellermann5-0/+312
This replaces the rewinding buffer code from the CURL input plugin. It is more generic, and allows rewinding even when the server sends Icy-Metadata (which would have been too difficult to implement within the CURL plugin). This is a rather complex patch for the stable branch (v0.15.x), but it fixes a serious problem: the "vorbis" decoder plugin was unable to play streams with Icy-Metadata, because it couldn't rewind the stream after detecting the codec (Vorbis vs. FLAC).
2009-12-29decoder/{ffmpeg,flac,vorbis}: added more flac/vorbis MIME typesMax Kellermann4-4/+22
Support deprecated MIME types such as "audio/x-ogg". Support new types such as "audio/flac".
2009-12-27dbUtils: return multiple tag values per songMax Kellermann1-1/+0
When collecting tag values for the result set, add all of a song's tag values of the searched type. This affects the "list" command. Previously, "list" only considered the first tag value of a song.
2009-12-26decoder_thread: eliminate jitter after seek failureMax Kellermann1-1/+5
Don't clear the music pipe when seeking has failed - check the "seeking" flag instead of "command==SEEK". Clear the "seeking" flag in decoder_seek_error().
2009-12-26decoder/wavpack: allow fine-grained seekingMax Kellermann1-3/+2
First multiply the floating point return value of decoder_seek_where(), then cast to integer.
2009-12-15iso, zip: fixed memory leak in destructorMax Kellermann2-2/+4
Free the "context" pointer in the method archive_plugin.close().
2009-12-15archive: close archive when stream is closedMax Kellermann4-0/+9
Fixes a memory leak: the "archive" input plugin opens the archive, but never closes it. This patch moves the responsibility for doing that to archive_plugin.open_stream(). This is an slight internal API change, but it is the simplest and least intrusive fix for the memory leak.
2009-12-15archive/bz2: removed NULL check before g_free()Max Kellermann1-2/+2
g_free(NULL) is allowed.
2009-12-15input/archive: close the archive file on errorMax Kellermann1-0/+1
Fixed memory leak in error handler.
2009-12-15input/file: don't fall back to parent directoryMax Kellermann1-18/+3
This code has never made any sense, and has broken some of the archive plugin.
2009-12-11decoder/wavpack: don't use the nonstandard "uchar" typeMax Kellermann1-1/+1
Use the signed C99 type int8_t instead.
2009-12-08mixer: explicitly close all mixers on shutdownMax Kellermann1-0/+4
Mixers with the "global" flag set aren't closed automatically when the output device is closed. Thus, they might still be open when MPD shuts down.
2009-12-08mapper: apply filesystem_charset to playlistsMax Kellermann4-11/+36
This fixes an inconsistency in the stored playlist subsystem: when obtaining the list of playlists (listplaylist, listplaylistinfo), the file names in the playlist directory are converted to UTF-8 (according to filesystem_charset), but when saving or loading playlists, the filesystem_charset setting was ignored.
2009-12-08command: verify playlist name in the "rm" commandMax Kellermann1-0/+3
Call spl_valid_name() in spl_delete().
2009-12-08mapper: fix memory leak when playlist_directory is not setMax Kellermann1-2/+2
Don't allocate the file name before the playlist_dir==NULL check.
2009-11-30tag_id3: fix ID3v1 charset conversionsvitoos1-1/+1
If we define id3v1_encoding, then the tags are not added to the database.
2009-11-30ffmpeg: don't try to force stereoMax Kellermann1-4/+0
The plugin code tried to force libavcodec to supply stereo samples. That however has never actually worked. By removing this code, we are able to play surround files for the first time.
2009-11-19decoder/flac: fixed compiler warningMax Kellermann1-3/+1
Removed the "vtrack" local variable (which triggered a gcc warning because it was after the newly introduced NULL check), and run strtol() on the original parameter.
2009-11-18decoder/flac: fixed NULL pointer dereference in CUE codeMax Kellermann1-0/+2
The function flac_vtrack_tnum() was missing a strrchr()==NULL check.
2009-11-15id3: allow 4 MB RIFF/AIFF tagsMax Kellermann1-1/+1
Allow RIFF/AIFF ID3 tags up to 4 MB (old limit was 256 kB). This might still be too small for some users, and when somebody complains, we might do something more clever (like streaming the data into libid3tag?).
2009-11-15decoder/ffmpeg: align the output bufferMax Kellermann1-5/+24
On some platforms, libavcodec wants the output buffer aligned to 16 bytes (because it uses SSE/Altivec internally). It will segfault when you don't obey this rule.
2009-11-11decoder/flac: fixed CUE seeking range checkMax Kellermann1-14/+8
If flac_container_decode() gets a seek destination which is out of range, it ignores the SEEK command (never finishes it). This leads to MPD lockup, because the player thread waits for completion.
2009-11-11oggflac: rewind stream after FLAC detectionMax Kellermann1-0/+8
The oggflac plugin has been completely broken for quite a while and nobody has noticed - maybe we should remove it?
2009-11-10sticker: added fallback for sqlite3_prepare_v2()Max Kellermann1-0/+4
This function was not present in SQLite < 3.4.
2009-11-10input/lastfm: fixed variable name in GLib<2.16 code pathMax Kellermann1-1/+1
Should be "lastfm_user", not "lastfm_username".
2009-11-01song_save: increased maximum line length to 32 kBMax Kellermann1-3/+7
The line buffer had a fixed size of 5 kB, and was allocated on the stack. This was too small for some users. As a hotfix, we're increasing the buffer size to 32 kB now, allocated on the heap. In MPD 0.16, we'll switch to dynamic allocation.
2009-10-31decoder_control: removed unused DECODE_TYPE macrosMax Kellermann1-3/+0
2009-10-28decoder/ffmpeg: convert metadataMax Kellermann1-4/+4
Convert the metadata with the libavformat function av_metadata_conv(). This ensures that canonical tag names are provided by libavformat, and we can remove the "artist" vs "author" workaround.
2009-10-27update: delete ignored symlinks from databaseMax Kellermann1-1/+5
When you disable the "follow_outside_symlinks" or the "follow_inside_symlinks" setting, the next update should remove the now-ignored files from the database.
2009-10-21output_thread: check again if output is open on PAUSEMax Kellermann1-0/+9
Basically the same as the 0.15.5 patch "check again if output is open on CANCEL". Same race condition, same fix.
2009-10-16decoder/flac: fixed two memory leaks in the CUE tag loaderMax Kellermann1-2/+3
Don't initialize "vc" and "cs" with FLAC__metadata_object_new(); that value is overwritten by FLAC__metadata_get_tags() and FLAC__metadata_get_cuesheet().
2009-10-16update: fixed memory leak during container scanMax Kellermann1-3/+6
The return value of map_directory_child_fs() must be freed.
2009-10-16update: song_file_new() cannot failMax Kellermann1-3/+0
Removed the NULL check. If that NULL check was correct, that would have been a memory leak (vtrack).
2009-10-16output_thread: check again if output is open on CANCELMax Kellermann1-1/+2
When the player thread unpauses, it sends CANCEL to the output thread, after having checked that the output is still open. Problem is when the output thread closes the device before it can process the CANCEL command - race condition. This patch adds another "open" check inside the output thread.
2009-10-13input/curl: fixed endless loop during bufferingMax Kellermann1-1/+1
When the connection is lost while buffering, the CURL input plugin may enter an endless loop, because it does not check the EOF condition. This patch makes fill_buffer() return success only if there's at least one buffer, which is enough of a check.x
2009-10-11riff, aiff: fixed "limited range" gcc warningMax Kellermann2-10/+10
On 32 bit systems with large file support enabled (i.e. "sizeof(off_t) > sizeof(size_t)") gcc emits a warning because a size_t cast to off_t can never become negative.
2009-10-11decoder_thread: change the fallback decoder name to "mad"Max Kellermann1-1/+1
When there is no Content-Type response header, try the "mad" decoder plugin. It uesd to be named "mp3", and we forgot to change the fallback name in decoder_thread.c.
2009-10-11input/curl: don't abort if a packet has only metadataMax Kellermann1-20/+22
When a received chunk of data has only icy-metadata, there was no usable data left for input_curl_read() to return, and thus it returned 0 bytes. "0" however is a special value for "end of file" or "error". This patch makes input_curl_read() read more data from the socket, until the read request can be fulfilled (or until there's really EOF).
2009-10-11input/curl: moved code to fill_buffer()Max Kellermann1-27/+40