aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-10-13input/curl: fixed endless loop during bufferingMax Kellermann1-1/+1
When the connection is lost while buffering, the CURL input plugin may enter an endless loop, because it does not check the EOF condition. This patch makes fill_buffer() return success only if there's at least one buffer, which is enough of a check.x
2009-10-11riff, aiff: fixed "limited range" gcc warningMax Kellermann2-10/+10
On 32 bit systems with large file support enabled (i.e. "sizeof(off_t) > sizeof(size_t)") gcc emits a warning because a size_t cast to off_t can never become negative.
2009-10-11decoder_thread: change the fallback decoder name to "mad"Max Kellermann1-1/+1
When there is no Content-Type response header, try the "mad" decoder plugin. It uesd to be named "mp3", and we forgot to change the fallback name in decoder_thread.c.
2009-10-11input/curl: don't abort if a packet has only metadataMax Kellermann1-20/+22
When a received chunk of data has only icy-metadata, there was no usable data left for input_curl_read() to return, and thus it returned 0 bytes. "0" however is a special value for "end of file" or "error". This patch makes input_curl_read() read more data from the socket, until the read request can be fulfilled (or until there's really EOF).
2009-10-11input/curl: moved code to fill_buffer()Max Kellermann1-27/+40
2009-09-30decoder/ffmpeg: use the "artist" tag if "author" is not presentMax Kellermann1-2/+5
Usually, we read our "artist" tag from ffmpeg's "author" tag. In some cases however (e.g. APE), this tag is named "artist". This patch implements a fallback: if no "author" is found, MPD tries to use "artist".
2009-09-30decoder/faad: skip assertion failure on large ID3 tagsMax Kellermann1-2/+6
When the ID3 tag in an AAC file is larger than the current buffer, the function decoder_buffer_consume() aborts. By using the new function decoder_buffer_skip() instead, we can safely skip the ID3 tag.
2009-09-30decoder_buffer: added function decoder_buffer_skip()Max Kellermann2-0/+36
2009-09-20input/mms: fix G_LOG_DOMAIN valueSerge Ziryukin1-1/+1
2009-09-20output/osx: fix the OS X 10.6 buildPatrik Weiskircher1-0/+1
Include CoreServices/CoreServices.h.
2009-09-10decoder/vorbis: revert "faster tag scanning with ov_test_callback()"Max Kellermann1-1/+1
This patch made ov_time_total() unusable, and MPD did not know the duration of songs.
2009-08-24decoder/vorbis: faster tag scanning with ov_test_callback()Rasmus Steinke1-1/+1
using ov_test_callback with function CALLBACKS_STREAMONLY will cause scanning to stop after the comment field. ov_open (and ov_test) default to CALLBACKS_DEFAULT which scans the file structure causing a huge slowdown. The speed improvement is huge: It scanned my files around 10x faster This procedure has been recommended by monthy (main vorbis developer) and was said to be safe for scanning files.
2009-08-19update: don't re-read unchanged container filesIgor Kuzmin1-1/+2
MPD checks if every flac (possibly other types as well) file contains cuesheet on every update, which produces unneeded I/O. My music collection is on NFS share, so it's quite noticeable. IMHO, it shouldn't re-read unchanged files, so I wrote simple patch to fix it.
2009-08-18output_init: initialize the "pause" flagMax Kellermann1-0/+1
Fix stuttering due to uninitialized variable.
2009-08-14output/shout: minimize the unpause latencyMax Kellermann1-0/+7
During the pause loop, manually sleep for 500ms if shout_delay() returns a value greater than that. Don't exhaust libshout's buffer.
2009-08-14output: fixed shout stuck pause bugMax Kellermann3-0/+20
Explicitly make the output thread leave the ao_pause() loop. This patch is a workaround, and the "pause" flag is not managed in a thread-safe way, but that's good enough for now.
2009-08-14directory: free empty directories after removing them (memleak)Max Kellermann1-3/+8
dirvec_delete() does not free the object, we have to call directory_free() afterwards.
2009-08-14update: free temporary string in container scan (memleak)Max Kellermann1-2/+6
The return value of map_directory_child_fs() must be freed.
2009-08-14decoder/flac: don't allocate cuesheet twice (memleak)Max Kellermann1-4/+6
The function flac_cue_track() first calls FLAC__metadata_object_new(), then overwrites this pointer with FLAC__metadata_get_cuesheet(). This allocate two FLAC__StreamMetadata objects, but the first pointer is lost, and never freed.
2009-08-14update: free empty path string (memleak)Max Kellermann1-1/+2
When you pass an empty string to directory_update_init(), it was not freed by update_task().
2009-07-22decoder/flac: fixed indentation of flac_comment_value()Max Kellermann1-19/+21
2009-07-22decoder/flac: parse all replaygain tagsMax Kellermann1-14/+18
The FLAC replaygain parser used the "||" operator. This made the code stop after the first value which was found.
2009-07-22decoder/flac: return early from flac_find_float_comment()Max Kellermann1-21/+22
When one metadata check fails, return quickly. This removes 2 levels of indent.
2009-07-22decoder/flac: removed misplaced authorship commentMax Kellermann1-1/+0
This belongs into "git annotate" or AUTHORS.
2009-07-22mad: skip ID3 frames when libid3tag is disabledMax Kellermann1-6/+28
When libid3tag is disabled, the libmad decoder plugin is unable to identify ID3 frames. If the file starts with an (unidentified) ID3 frame, it assumes that the file is not a valid MP3 song. This patch solves this by adding minimal stubs for the ID3 functions.
2009-07-19ape: added protection against large memory allocationsMax Kellermann1-0/+3
The function tag_ape_load() retrieves a 32 bit unsigned integer from the input file, and passes it to g_malloc(). This is dangerous, and may be used for a denial of service attack on MPD.
2009-07-19tag_ape: removed redundant length checkMax Kellermann1-3/+4
Extend the tagLen check after reading it. Removed the second (redundant) check after the subtraction.
2009-07-18ape: check the tag size (fixes integer underflow)Max Kellermann1-1/+1
The expression "tagLen - size > 0" may result in an integer underflow and a buffer overflow, when "size" is larger than "tagLen". "size" is read from the input file, and must not be trusted. This patch changes the expression to "tagLen > size", which is a lot safer.
2009-07-14output/httpd: removed duplicate sys/types.h includeMax Kellermann1-4/+0
The first patch by Patrick didn't work, because his "#ifdef HAVE_OSX" line would have required config.h.
2009-07-06decoder/flac: fix assertion failure in tag_free() callMax Kellermann1-2/+1
Initialize flac_data.tag right after flac_data_init(). This way, the "goto fail" won't jump to the point where tag_free(NULL) can be called.
2009-07-06output/httpd: include sys/types.hMax Kellermann1-0/+1
On Mac OS X, the httpd plugin cannot be compiled, because OS X's system headers do nto include sys/types.h, although they use u_int32_t.
2009-07-06song: initialize mtime in song_alloc()Max Kellermann1-0/+1
2009-07-05log: fix double free() bug during shutdownMax Kellermann1-6/+2
Don't free an internal configuration value in log_init(). Call config_get_path() instead of manually calling parsePath().
2009-06-30database: fixed NULL pointer dereference after charset changeMax Kellermann1-4/+5
When the filesystem_charset is changed in mpd.conf, MPD should discard the old database. In this error branch, MPD did not fill the GError object properly, and logged a warning message instead, which caused a segmentation fault.
2009-06-29output_thread: don't play next chunk after command==PAUSEMax Kellermann1-1/+5
When the PAUSE loop ends, re-check the next command before calling ao_play() again.
2009-06-29output_all: don't resume playback when stopping during pauseMax Kellermann1-2/+0
When MPD was paused, and the client sent the "stop" command (or "clear"), a glitch caused MPD to continue playback for a split second. This was because audio_output_all_cancel() calls audio_output_all_update(), which reopens all output devices, and re-ignites the playback loop.
2009-06-19decoder_thread: reopen the stream after file_decode() has failedMax Kellermann1-0/+11
When decoding a local file, the decoder thread tries to run all matching decoders, until one succeeds. Both file_decode() and stream_decode() can decode a stream, but MPD closes the stream before calling file_decode(). Problem is: when this decoder fails, and the next's stream_decode() method is invoked, the input_stream is still closed. This patch reopens it.
2009-06-10listen: bind() failure on secondary address is non-fatalMax Kellermann1-3/+25
Several users had problems with binding MPD to "localhost". The cause was duplicate /etc/hosts entries: the resolver library returns 127.0.0.1 twice, and of course, MPD attempts to bind to "both" of them. This patch makes failures non-fatal, given that at least one address was bound successfully. This is a workaround; users should rather fix their /etc/hosts file.
2009-06-10listen: renamed "error" to "error_r" in listen_add_host()Max Kellermann1-4/+4
2009-06-10listen: print debug message before bind()Max Kellermann1-0/+7
Dump each socket address before binding to it.
2009-06-08ffmpeg: moved code to ffmpeg_copy_metadata()Max Kellermann1-33/+18
2009-06-08ffmpeg: removed "new metadata api" warningMax Kellermann1-2/+0
This warning is useless. I assume the author added it for debugging purposes.
2009-06-04client: check "expired" flag again in client_write_output()Max Kellermann1-0/+3
When client_defer_output() aborts the connection to the client, client_write_output() called client_write_deferred() anyway. This caused an assertion failure. Fix it by checking for the "expired" flag again after client_defer_output() returns.
2009-06-04client: added assertions on channel!=NULLMax Kellermann1-0/+10
I'm hunting down a bug where client->channel==NULL during I/O operations. These new assertions help avoid this kind of bug in the future.
2009-06-04decoder_plugin: corrected outdated API documentationMax Kellermann1-21/+22
2009-06-03conf: make config_param.num_block_params unsignedMax Kellermann2-5/+3
2009-06-03conf: eliminated CamelCaseMax Kellermann4-21/+22
Renamed all remaining CamelCase functions.
2009-06-02player_thread: check pipe size again before exitingMax Kellermann1-1/+5
When the decoder is finished, break out of the player loop only after another player.pipe check. We did check the pipe size a few lines above, but that check was kind of racy.
2009-06-02player_thread: don't leak empty music_chunksMax Kellermann1-1/+3
When a music_chunk only contains a tag but no PCM data, play_chunk() returns true without freeing the chunk. The caller now assumes that the chunk is moved into some music_pipe and does not bother to free it either.
2009-05-29player_thread: reinitialize music_buffer in !NDEBUGMax Kellermann1-0/+9
To check for leaked music_chunk objects, free the music buffer on CLOSE_AUDIO. This invokes an assertion check which ensures that all chunks have been returned to the buffer.