aboutsummaryrefslogtreecommitdiffstats
path: root/src/update.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* event_pipe: added pipe_event enum and callbacksMax Kellermann2009-01-011-3/+6
| | | | | | | | | Make the event_pipe (formerly main_notify) send/receive a set of events, with a callback for each one. The default event PIPE_EVENT_SIGNAL does not have a callback. It is still there for waking up the main thread, when it is waiting for the player thread.
* event_pipe: renamed functions from main_notify_* to event_pipe_*Max Kellermann2009-01-011-2/+2
| | | | Continuing the previous patch.
* main_notify: renamed source to event_pipe.cMax Kellermann2009-01-011-1/+1
| | | | | | We are going to migrate away from the concept of notifying the main thread. There should be events sent to it instead. This patch starts a series to implement that.
* update: use GLib loggingMax Kellermann2008-12-291-18/+21
|
* removed os_compat.hMax Kellermann2008-12-291-0/+7
| | | | | Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
* update: fixing empty filenames in archivesViliam Mateicka2008-12-291-0/+4
|
* update & main_notify: migrate from pthread to glib threadsThomas Jansen2008-12-281-10/+11
|
* disable archive API without pluginsMax Kellermann2008-12-271-0/+7
| | | | | When there are no archive plugins, we do not need the archive API at all. Drop all its overhead.
* Merge branch 'experimental' of git://git.musicpd.org/metyl/mpdMax Kellermann2008-12-271-1/+64
|\ | | | | | | | | | | | | | | Conflicts: configure.ac src/ls.h src/output/shout_plugin.c
| * update: adding archive updating related codeViliam Mateicka2008-12-161-1/+64
| |
* | update: default to follow all symlinksAvuton Olrich2008-12-081-1/+1
|/ | | | | | MPD 0.13 and older followed all symbolic links. Although this can be a security problem (as it has always been), 0.14 should offer the same default behaviour as 0.13.
* update: added options which control symlink behaviourRaphaël Rigo2008-11-281-7/+33
| | | | | | | | | The configuration options "follow_outside_symlinks" and "follow_inside_symlinks" let the user control whether MPD should follow symbolic links in the music directory. [mk: converted variables to "bool"; moved configuration to update_global_init()]
* update: added update_global_init() and update_global_finish()Max Kellermann2008-11-271-0/+8
| | | | | | Those two functions are called when MPD starts and exits. It allows the update library to perform global initialization and deinitialization. The implementations are currently empty.
* update.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-1/+1
|
* update: fixed shadow warning on "basename"Max Kellermann2008-11-221-6/+6
| | | | | Renamed the local variable "basename", which shadows the POSIX function basename().
* update: pass UTF-8 path to skip_symlink()Konstantin Sobolev2008-11-201-3/+2
| | | | | | skip_symlinks() expects an UTF-8 encoded file name, but updateDirectory() passed ent->d_name (in file system encoding) to it. Convert it to UTF-8 first.
* update: check return valuesMax Kellermann2008-10-311-2/+6
| | | | | Nearly all mapper functions can fail and will then return NULL. Add checks to all callers.
* path: replaced mpd_basename() with g_path_get_basename()Max Kellermann2008-10-201-5/+16
| | | | | | GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
* update: don't skip hidden filesMax Kellermann2008-10-151-3/+5
| | | | | Skip only the special directory entries "." and "..", don't skip all other "hidden" files.
* command: added command "idle"Max Kellermann2008-10-141-1/+4
| | | | | | "idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
* update: don't follow relative symlinksMax Kellermann2008-10-141-1/+44
| | | | | | Don't follow relative symlinks which point into the music directory. This allows you to organize music with symbolic links, without MPD managing separate copies of each song.
* mapper: new song-to-filesystem mapper libraryMax Kellermann2008-10-141-23/+43
| | | | | | The mapper library maps directory and song objects to file system paths. With this central library, the code mixture in path.c should be cleaned up, and we will be able to add neat features like aliasing.
* update: always look up parent directory in updatePath()Max Kellermann2008-10-131-20/+10
| | | | | | | By always creating the parent directory, we can use delete_name_in() without further lookups. The parents which may non exist will be pruned later. An update request for a non-existing or empty directory should be quite unusual, so this doesn't add any measurable overhead.
* update: pass base file name to updateInDirectory()Max Kellermann2008-10-131-9/+24
| | | | | | In order to optimize buffer usage, pass only the base file name to updateInDirectory(). This way, updateInDirectory() may choose when to allocate a larger buffer for the full path.
* update: moved code to make_subdir()Max Kellermann2008-10-131-4/+13
|
* update: added delete_name_in()Max Kellermann2008-10-131-1/+18
| | | | | delete_name_in() is similar to delete_path(), but it does not need to look up the parent directory.
* update: allow music_root updates to be queuedEric Wong2008-10-131-3/+2
| | | | | | Previously only updates with subdirectories being specified could be queued. No harm in queueing full updates.
* update: replaced update_return with global "modified" flagMax Kellermann2008-10-091-65/+41
| | | | | | | There is only once update thread at a time. Make the "modified" flag global and remove the return values of most functions. Propagating an error is only useful for updateDirectory(), since updateInDirectory() will delete failed subdirectories.
* update: make the variable "progress" staticMax Kellermann2008-10-091-1/+1
|
* update: don't print debug message when song was not modifiedMax Kellermann2008-10-091-4/+5
| | | | | When a song file was not modified, MPD printed the debug message "not a directory or music", because the first "if" branch did not return.
* update: fix memory leak in directory_update_init()Max Kellermann2008-10-091-1/+4
| | | | | When the update queue is full, directory_update_init() did not free the path argument.
* update: make the job id unsignedMax Kellermann2008-10-091-5/+7
| | | | Since the return value cannot be -1 anymore, we can make it unsigned.
* update: job ID must be positiveMax Kellermann2008-10-091-2/+2
| | | | | | | The documentation for directory_update_init() was incorrect: a job ID must be positive, not non-negative. If the update queue is full and no job was created, it makes more sense to return 0 instead of -1, because it is more consistent with the return value of isUpdatingDB().
* update: check progress!=IDLE in reap_update_task()Max Kellermann2008-10-091-0/+3
| | | | | When the update task is idle, there is no need to check for deleted songs. Return early from reap_update_task().
* update: fixed stack corruption due to pthread_join() callMax Kellermann2008-10-091-1/+3
| | | | | | pthread_join() expects a "pointer to a pointer" parameter, but it got a "pointer to an enum". On AMD64, an enum is smaller than a pointer, leading to a buffer overflow.
* updated: always call removeDeletedFromDirectory()Max Kellermann2008-10-091-3/+1
| | | | | Removed the local variable "was_empty": don't remember if the directory is new. Always call removeDeletedFromDirectory().
* update: eliminated addSubDirectoryToDirectory()Max Kellermann2008-10-091-27/+8
| | | | | | In updateInDirectory(), add new directories immediately and delete them when they turn out to be empty. This simplifies the code and allows us to eliminate addSubDirectoryToDirectory().
* update: make the "song" variable more localMax Kellermann2008-10-091-3/+2
|
* update: do the recursive directory check only onceMax Kellermann2008-10-091-8/+6
| | | | | The recursive checks were performed in several functions, and sometimes a directory was checked twice.
* update: copy stat to new directoryMax Kellermann2008-10-091-1/+3
| | | | | | When reading a new directory, copy the stat data (which we have anyway) to the directory struct. This may save a stat() in the future.
* update: avoid duplicate stat() callsMax Kellermann2008-10-091-27/+35
| | | | Pass a pointer to the stat struct to more functions.
* update: rewrote updatePath() using updateInDirectory()Max Kellermann2008-10-091-68/+21
| | | | | | updatePath() duplicated a lot of code from the more generic updateInDirectory(). Eliminate most of updatePath() and call updateInDirectory().
* update: don't export updateDirectory()Max Kellermann2008-10-091-1/+10
| | | | | | | | If the user requests database update during startup, call directory_update_init(). This should be changed to fully asynchronous update later. For this to work, main_notify has to be initialized before db_init().
* update: pass const pointer to addSubDirectoryToDirectory()Max Kellermann2008-10-091-1/+1
| | | | The stat struct isn't going to be modified, make it const.
* update: never pass root path to updatePath()Max Kellermann2008-10-091-6/+1
| | | | | update_task() already checks if it has got a root path. Extend this check and in turn remove a check in the inner function updatePath().
* database: renamed get_get_song() to db_get_song()Max Kellermann2008-10-091-1/+1
| | | | Search'n'replace typo..
* update: don't sanitize the path againMax Kellermann2008-10-091-13/+3
| | | | | directory_update_init() has to be called with a path that is already sanitized. Don't call sanitizePathDup() again in updatePath().
* update: merged addDirectoryPathToDB() into addParentPathToDB()Max Kellermann2008-10-091-25/+3
| | | | | | | The algorithm in addDirectoryPathToDB() can be simplified further if it is combined with the function addParentPathToDB(). Since there is no other caller of addDirectoryPathToDB(), we can do that. This saves another large stack buffer.
* update: make addDirectoryPathToDB() non-recursiveMax Kellermann2008-10-091-11/+15
| | | | | | This recursive function is very dangerous because it allocates a large buffer on the stack in every iteration. That may be misused to generate a stack overflow.
* update: delete directory after failed updateMax Kellermann2008-10-091-1/+8
| | | | | When a directory cannot be updated, there must be something wrong with it, and the database contains stale data. Remove it.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-03 01:14:24 +0000