aboutsummaryrefslogtreecommitdiffstats
path: root/src/update.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-10-31update: check return valuesMax Kellermann1-2/+6
Nearly all mapper functions can fail and will then return NULL. Add checks to all callers.
2008-10-20path: replaced mpd_basename() with g_path_get_basename()Max Kellermann1-5/+16
GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
2008-10-15update: don't skip hidden filesMax Kellermann1-3/+5
Skip only the special directory entries "." and "..", don't skip all other "hidden" files.
2008-10-14command: added command "idle"Max Kellermann1-1/+4
"idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
2008-10-14update: don't follow relative symlinksMax Kellermann1-1/+44
Don't follow relative symlinks which point into the music directory. This allows you to organize music with symbolic links, without MPD managing separate copies of each song.
2008-10-14mapper: new song-to-filesystem mapper libraryMax Kellermann1-23/+43
The mapper library maps directory and song objects to file system paths. With this central library, the code mixture in path.c should be cleaned up, and we will be able to add neat features like aliasing.
2008-10-13update: always look up parent directory in updatePath()Max Kellermann1-20/+10
By always creating the parent directory, we can use delete_name_in() without further lookups. The parents which may non exist will be pruned later. An update request for a non-existing or empty directory should be quite unusual, so this doesn't add any measurable overhead.
2008-10-13update: pass base file name to updateInDirectory()Max Kellermann1-9/+24
In order to optimize buffer usage, pass only the base file name to updateInDirectory(). This way, updateInDirectory() may choose when to allocate a larger buffer for the full path.
2008-10-13update: moved code to make_subdir()Max Kellermann1-4/+13
2008-10-13update: added delete_name_in()Max Kellermann1-1/+18
delete_name_in() is similar to delete_path(), but it does not need to look up the parent directory.
2008-10-13update: allow music_root updates to be queuedEric Wong1-3/+2
Previously only updates with subdirectories being specified could be queued. No harm in queueing full updates.
2008-10-09update: replaced update_return with global "modified" flagMax Kellermann1-65/+41
There is only once update thread at a time. Make the "modified" flag global and remove the return values of most functions. Propagating an error is only useful for updateDirectory(), since updateInDirectory() will delete failed subdirectories.
2008-10-09update: make the variable "progress" staticMax Kellermann1-1/+1
2008-10-09update: don't print debug message when song was not modifiedMax Kellermann1-4/+5
When a song file was not modified, MPD printed the debug message "not a directory or music", because the first "if" branch did not return.
2008-10-09update: fix memory leak in directory_update_init()Max Kellermann1-1/+4
When the update queue is full, directory_update_init() did not free the path argument.
2008-10-09update: make the job id unsignedMax Kellermann1-5/+7
Since the return value cannot be -1 anymore, we can make it unsigned.
2008-10-09update: job ID must be positiveMax Kellermann1-2/+2
The documentation for directory_update_init() was incorrect: a job ID must be positive, not non-negative. If the update queue is full and no job was created, it makes more sense to return 0 instead of -1, because it is more consistent with the return value of isUpdatingDB().
2008-10-09update: check progress!=IDLE in reap_update_task()Max Kellermann1-0/+3
When the update task is idle, there is no need to check for deleted songs. Return early from reap_update_task().
2008-10-09update: fixed stack corruption due to pthread_join() callMax Kellermann1-1/+3
pthread_join() expects a "pointer to a pointer" parameter, but it got a "pointer to an enum". On AMD64, an enum is smaller than a pointer, leading to a buffer overflow.
2008-10-09updated: always call removeDeletedFromDirectory()Max Kellermann1-3/+1
Removed the local variable "was_empty": don't remember if the directory is new. Always call removeDeletedFromDirectory().
2008-10-09update: eliminated addSubDirectoryToDirectory()Max Kellermann1-27/+8
In updateInDirectory(), add new directories immediately and delete them when they turn out to be empty. This simplifies the code and allows us to eliminate addSubDirectoryToDirectory().
2008-10-09update: make the "song" variable more localMax Kellermann1-3/+2
2008-10-09update: do the recursive directory check only onceMax Kellermann1-8/+6
The recursive checks were performed in several functions, and sometimes a directory was checked twice.
2008-10-09update: copy stat to new directoryMax Kellermann1-1/+3
When reading a new directory, copy the stat data (which we have anyway) to the directory struct. This may save a stat() in the future.
2008-10-09update: avoid duplicate stat() callsMax Kellermann1-27/+35
Pass a pointer to the stat struct to more functions.
2008-10-09update: rewrote updatePath() using updateInDirectory()Max Kellermann1-68/+21
updatePath() duplicated a lot of code from the more generic updateInDirectory(). Eliminate most of updatePath() and call updateInDirectory().
2008-10-09update: don't export updateDirectory()Max Kellermann1-1/+10
If the user requests database update during startup, call directory_update_init(). This should be changed to fully asynchronous update later. For this to work, main_notify has to be initialized before db_init().
2008-10-09update: pass const pointer to addSubDirectoryToDirectory()Max Kellermann1-1/+1
The stat struct isn't going to be modified, make it const.
2008-10-09update: never pass root path to updatePath()Max Kellermann1-6/+1
update_task() already checks if it has got a root path. Extend this check and in turn remove a check in the inner function updatePath().
2008-10-09database: renamed get_get_song() to db_get_song()Max Kellermann1-1/+1
Search'n'replace typo..
2008-10-09update: don't sanitize the path againMax Kellermann1-13/+3
directory_update_init() has to be called with a path that is already sanitized. Don't call sanitizePathDup() again in updatePath().
2008-10-09update: merged addDirectoryPathToDB() into addParentPathToDB()Max Kellermann1-25/+3
The algorithm in addDirectoryPathToDB() can be simplified further if it is combined with the function addParentPathToDB(). Since there is no other caller of addDirectoryPathToDB(), we can do that. This saves another large stack buffer.
2008-10-09update: make addDirectoryPathToDB() non-recursiveMax Kellermann1-11/+15
This recursive function is very dangerous because it allocates a large buffer on the stack in every iteration. That may be misused to generate a stack overflow.
2008-10-09update: delete directory after failed updateMax Kellermann1-1/+8
When a directory cannot be updated, there must be something wrong with it, and the database contains stale data. Remove it.
2008-10-09update: moved code to directory_make_child_checked()Max Kellermann1-22/+25
The branching looks a bit complicated in addDirectoryPathToDB() - improve its readability by moving code to a simplified separate function.
2008-10-09update: clear root after errorMax Kellermann1-0/+1
When the root directory fails to update, its contents are invalid. Clear it then.
2008-10-09update: locked delete after update errorMax Kellermann1-1/+40
When a directory failed to update, it was removed from the database, without freeing all children and songs (memory leak), and without locking (race condition). Introduce the functions clear_directory() and delete_directory(), which do both.
2008-10-09update: removed addToDirectory()Max Kellermann1-39/+12
Use updateInDirectory() instead of addToDirectory(). Eliminate a duplicate stat() in updateInDirectory() by calling song_file_update() directly.
2008-10-09directory: added inline wrappers for accessing childrenMax Kellermann1-6/+5
Some tiny utilities... wrappers like these may become helpful when we introduce locking.
2008-10-09directory: moved dirvec struct declaration to dirvec.hMax Kellermann1-1/+0
No idea why it was created in directory.h, but it should be in dirvec.h.
2008-10-08directory: fix update in root directoryMax Kellermann1-1/+1
Commit 0bfe7802 broke update for new files in the root directory, because music_root->path was an empty string and not NULL. There were some NULL tests missing. Change them to !isRootDirectory(path) instead of path!=NULL.
2008-10-08update: fix deadlock in delete_song()Max Kellermann1-1/+1
Due to a merge error, reap_update_task() called cond_signal_async() with a locked mutex. That always fails. Use cond_signal_sync() instead.
2008-10-08directory: eliminate CamelCaseMax Kellermann1-6/+6
CamelCase is ugly, rename the functions.
2008-10-08database: renamed functions, "db_" prefix and no CamelCaseMax Kellermann1-7/+7
Yet another CamelCase removal patch.
2008-10-08directory: moved code to database.cMax Kellermann1-0/+1
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
2008-10-08song: song_file_update() returns boolMax Kellermann1-2/+2
Instead of returning 0 or -1, return true on success and false on failure. This seems more natural, and when the C library was designed, there was no "bool" data type.
2008-10-08song: removed CamelCaseMax Kellermann1-7/+7
CamelCase is ugly... rename all functions.
2008-10-08song: replaced all song constructorsMax Kellermann1-1/+1
Provide separate constructors for creating a remote song, a local song, and one for loading data from a song file. This way, we can add more assertions.
2008-10-08song: converted typedef Song to struct songMax Kellermann1-7/+9
Again, a data type which can be forward-declared.
2008-10-08directory: converted typedef Directory to struct directoryMax Kellermann1-20/+27
The struct can be forward-declared by other headers, which relaxes the header dependencies.