aboutsummaryrefslogtreecommitdiffstats
path: root/src/update.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-10-11directory: fix update in root directoryMax Kellermann1-1/+1
Commit 0bfe7802 broke update for new files in the root directory, because music_root->path was an empty string and not NULL. There were some NULL tests missing. Change them to !isRootDirectory(path) instead of path!=NULL.
2008-10-11directory: eliminate CamelCaseMax Kellermann1-6/+6
CamelCase is ugly, rename the functions. [ew: "directory_get_directory" was too confusing, using "directory_get_subdir" instead (old function was named "getSubDirectory")]
2008-10-11database: renamed functions, "db_" prefix and no CamelCaseMax Kellermann1-7/+7
Yet another CamelCase removal patch.
2008-10-11directory: moved code to database.cMax Kellermann1-1/+1
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
2008-10-11song: song_file_update() returns booleanMax Kellermann1-2/+2
Instead of returning 0 or -1, return true on success and false on failure. This seems more natural, and when the C library was designed, there was no "bool" data type. [ew: changing to bool semantics but sticking with integer type since bool is C99 and I don't require a C99 compiler, and I don't feel like writing compatibility wrappers to support it. _Bool is usually (always?) a signed int anyways. ]
2008-10-11song: removed CamelCaseMax Kellermann1-7/+7
CamelCase is ugly... rename all functions.
2008-10-11song: replaced all song constructorsMax Kellermann1-1/+1
Provide separate constructors for creating a remote song, a local song, and one for loading data from a song file. This way, we can add more assertions.
2008-10-11song: converted typedef Song to struct songMax Kellermann1-7/+7
Again, a data type which can be forward-declared. [ew: * used "struct mpd_song" instead to avoid token duplication (like I did with "struct mpd_tag") as there's no good abbreviation for "song" and identical tokens on the same line don't read well * rewritten using perl -i -p -e 's/\bSong\b/struct mpd_song/g' src/*.[ch] since it was too hard to merge * also, I don't care much for forward declarations ]
2008-10-11directory: converted typedef Directory to struct directoryMax Kellermann1-20/+22
The struct can be forward-declared by other headers, which relaxes the header dependencies.
2008-10-11update: merged exploreDirectory() into updateDirectory()Max Kellermann1-47/+13
exploreDirectory() duplicates some code in updateDirectory(). Merge both functions, and use directory_is_empty() to determine whether update or explore mode should be used.
2008-10-11directory: moved code to update.cMax Kellermann1-781/+245
The source directory.c mixes several libraries: directory object management, database management and database update, resulting in a 1000+ line monster. Move the whole database update code to update.c.
2008-10-07directory: fix return value in removeDeletedFromDirectoryEric Wong1-1/+1
oops :x
2008-10-07directory: serialize song deletes from playlist during updateEric Wong1-3/+27
This makes the update code thread-safe and doesn't penalize the playlist code by complicating it with complicated and error-prone locks (and the associated overhead, not everybody has a thread-implementation as good as NPTL). The update task blocks during the delete; but the update task is a slow task anyways so we can block w/o people caring too much. This was also our only freeSong call site, so remove that function. Note that deleting entire directories is not fully thread-safe, yet; as their traversals are not yet locked.
2008-10-07directory: use songvec_for_each for iteratorsEric Wong1-30/+56
Get rid of songvec_write so we can enforce proper locking
2008-10-07dbUtils/directory: traverseAllIn forEachSong returns -1 on errorEric Wong1-12/+9
Being consistent with most UNIX functions...
2008-10-05Assert if we don't have song or song->url setEric Wong1-2/+2
song objects cannot exist without a path or URL
2008-10-05song: stop storing song_typeEric Wong1-1/+1
We already know if a song is a URL or not based on whether it has parentDir defined or not. Hopefully one day in the future we can drop HTTP support from MPD entirely when an HTTP filesystem comes along and we can access streams via open(2).
2008-10-05song: use flex arrays to store song->urlEric Wong1-1/+1
Reduce the number of allocations we make, so there's less pressure on the allocator and less overhead to keep track of the allocations in.
2008-10-05directory: fix writeDirectoryDBEric Wong1-2/+4
Wow, I must have been halfway asleep when I did that...
2008-10-04directory: reuse existing directory if found on updateEric Wong1-4/+9
Instead of allocating a new one, just reuse an existing one if one is found when rereading the DB. This is a small makes the previous commit work on subdirectories of the root music directory. [1] "song: better handling of existing songs when rereading DB"
2008-10-03directory: simplify list update handling logicEric Wong1-59/+61
Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
2008-10-03directory: streamline deletesEric Wong1-17/+15
Instead of relying on the shortname, just pass the song pointer to prevent redundant lookups during deletes.
2008-09-29directory: remove redundant sanitizePathDupEric Wong1-15/+7
We already sanitize and duplicated our paths before calling updateInit() to get pre-pthread_create() error-checking along with heap allocation reduction because we don't have to redupe because our parent stack went away.
2008-09-29update: move path sanitation up the stack to avoid extra copiesEric Wong1-12/+26
Remove yet another use of our old malloc-happy linked list implementation and replace it with a simple array of strings. This also implements more eager error handling of invalid paths (still centralized in updateInit) so we can filter out bad paths before we spawn a thread. This also does its part to fix the "update" command inside list mode which lost its static variable in ada24f9a921ff95d874195acf253b5a9dd12213d (although it was broken and requires the fix in 769939b62f7557f8e7c483223d68a8b39af43e37, too).
2008-09-28clean up updateInit calling and error handlingEric Wong1-8/+4
Move error reporting to command.c so directory.c does not deal with client error handling any more.
2008-09-28directory: isRootDirectory() is a one-linerEric Wong1-4/+1
Improving the signal to noise ratio...
2008-09-28directory: writeDirectoryInfo propagates errorsEric Wong1-28/+19
If a write failed, it's a good sign subsequent writes will fail, too, so propgate errors all the way up the stack.
2008-09-28directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong1-1/+1
A long time ago in an mpd far away...
2008-09-28directory: remove "Mp3" referencesEric Wong1-17/+17
MPD has supported more audio formats than just MP3 for over five years...
2008-09-28directory: remove shortname arguments everywhereEric Wong1-79/+40
It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
2008-09-28directory: replace DirectoryList with dirvecEric Wong1-195/+96
Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
2008-09-28directory: remove unused CPP definesEric Wong1-4/+0
We no longer for for updates
2008-09-28songvec_free => songvec_destroyEric Wong1-1/+1
"free" implies the songvec structure itself is freed, which is not the case.
2008-09-28directory.c: kill unnecessary includesEric Wong1-4/+0
2008-09-28directory: update playlist version if updatedEric Wong1-1/+6
If we updated the mpd metadata database; then there's a chance some of those songs in the playlist will have updated metadata. So be on the safe side and increment the playlist version number if _any_ song changed (this is how all released versions of mpd did it, too). This bug was introduced recently when making "update" threaded. Thanks to stonecrest for the bug report.
2008-09-23Revert "directory: serialize freeSong() within the main thread"Eric Wong1-9/+1
This reverts commit efefaee1f9535012be2fbfea8f0f870904daad5d. Conflicts: src/directory.c
2008-09-23directory: use songvec_free to prevent memory leaks.Eric Wong1-2/+1
2008-09-23directory: fix leak introduced with threaded updateEric Wong1-1/+1
Use freeList() instead of free() to free all elements in the list.
2008-09-23directory: serialize freeSong() within the main threadEric Wong1-1/+10
It's possible the playlist will be accessing a song that is to be freed in the update thread. Rather than going through the complexity (and potential to make mistakes) of locking the playlist (as well as losing CPU cycles/pipelining due to barriers with mutexes), we'll just line up all songs to be freed in the main thread. It's relatively uncommon to call freeSong() heavily (as it is to update); so the extra, temporary memory usage won't be very noticeable. Additionally, if a song is renamed and it contains unique tag item; this has the additional side effect of preventing unnecessary fragmentation where an item is freed and shortly reallocated.
2008-09-22Remove EINTR checking for open(2)Eric Wong1-2/+1
open(2) should only interrupt on "slow" devices, afaik...
2008-09-22directory: don't leak file handles if we get a corrupt dbEric Wong1-1/+1
2008-09-22directory: update do its work inside a threadEric Wong1-108/+50
A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
2008-09-22directory: use enum update_return for return valuesEric Wong1-72/+49
This way we avoid having to document -1, 0, 1
2008-09-20workaround race condition on updates with broken signal blockingEric Wong1-39/+50
pthreads with our existing signal blocking/handling is broken, for now just sleep a bit in the child to prevent the CHLD handler from being called too early. Also, improve error reporting when handling SIGCHLD by storing the status to be called in the main task (which can be logged, since we can't do logging inside the sig handler).
2008-09-20Replace SongList with struct songvecEric Wong1-47/+47
Our linked-list implementation is wasteful and the SongList isn't modified enough to benefit from being a linked list. So use a more compact array of song pointers which saves ~200K on a library with ~9K songs (on x86-32).
2008-09-20directory: remove unused updateMp3Directory() functionEric Wong1-18/+0
It hasn't been used in many years commit 3a89afdd80f228139554372a83a9d74486acf691 Author: Warren Dukes <warren.dukes@gmail.com> Date: Sat Nov 20 20:28:32 2004 +0000 remove --update-db option (SVN r2719)
2008-09-20start using prefixcmp()Eric Wong1-15/+8
LOC reduction and less noise makes things easier for tired old folks to follow.
2008-09-20Oops, open() with O_CREAT is nicer with a modeEric Wong1-1/+1
Respect the user's umask (and the number of the beast!)
2008-09-18Move away from fprintf() when writing DB/state_fileEric Wong1-16/+21
I have serious trust issues when using stdio to write to the FS. So it's best to clean this code out so I can start figuring out what's wrong with Rasi's box not updating... None of these writes take place in a performance-critical setting anyways...
2008-09-18Directory: don't allocate stat information dynamicallyEric Wong1-44/+19
This should save a few thousand ops. Not worth it to malloc for such a small (3-words on 32-bit ARM and x86) structures. Signed-off-by: Eric Wong <normalperson@yhbt.net>