aboutsummaryrefslogtreecommitdiffstats
path: root/src/tag_id3.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2010-12-07tag_id3: support multiple valuesMax Kellermann1-10/+36
Loop over all frames with a specific id, and import all of them - not just the first one (index 0).
2010-05-20tag_{id3,ape}: explicitly open files in binary modeMax Kellermann1-1/+1
Add the flag "b" to fopen(). Windows compatibility.
2009-12-31Update copyright notices.Avuton Olrich1-1/+1
2009-11-30tag_id3: fix ID3v1 charset conversionsvitoos1-1/+1
If we define id3v1_encoding, then the tags are not added to the database.
2009-11-15id3: allow 4 MB RIFF/AIFF tagsMax Kellermann1-1/+1
Allow RIFF/AIFF ID3 tags up to 4 MB (old limit was 256 kB). This might still be too small for some users, and when somebody complains, we might do something more clever (like streaming the data into libid3tag?).
2009-11-12include config.h in all sourcesMax Kellermann1-0/+1
After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
2009-10-13tag: removed the "_ITEM_" suffix from the enum namesMax Kellermann1-13/+13
2009-08-04tag_id3: moved id3_genre_name() call to tag_id3_import_text()Max Kellermann1-6/+6
The ID3_FRAME_GENRE field is queried only in tag_id3_import_text(). Don't pass the tag type to import_id3_string().
2009-08-04tag_id3: splitted function tag_id3_import_frame()Max Kellermann1-119/+91
Splitted tag_id3_import_frame() into two specialized functions: tag_id3_import_text() and tag_id3_import_comment(). Use id3_frame_field() instead of directly accessing id3_frame.fields.
2009-08-04tag_id3: corrected parameter typesMax Kellermann1-2/+3
Changed "int type" to "enum tag_type". Converted "int is_id3v1" to "bool".
2009-08-04tag_id3: converted tag_is_id3v1() to an inline functionMax Kellermann1-1/+6
Prefer C over CPP.
2009-08-04tag_id3: no CamelCaseMax Kellermann1-57/+64
Renamed functions.
2009-07-09Implement ArtistSort tagBart Nagel1-1/+7
2009-07-07tag_id3: revised "performer" tag supportMax Kellermann1-4/+2
According to the ID3 2.4 documentation, "TOPE" is "Original artist/performer", not "performer". Removed "TOPE" support. Instead, map TPE3 ("Conductor/performer refinement") and TPE4 ("Interpreted, remixed, or otherwise modified by") to "performer".
2009-07-07tag: added tag "AlbumArtistSort"Max Kellermann1-1/+2
The tag_id3.c library supports both the documented "TSO2" tag, and the inofficial TXXX/ALBUMARTISTSORT. The Vorbis/FLAC decoder automatically supports the new tag, without further change.
2009-05-06tag_id3: added support for the UFID frameMax Kellermann1-0/+40
If the UFID frame's owner is "http://musicbrainz.org", assume its value is the MusicBrainz track id.
2009-03-13all: Update copyright header.Avuton Olrich1-6/+7
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
2009-03-02tag_id3: parse ID3 tags in AIFF filesMax Kellermann1-3/+6
Added a small AIFF parser library, code copied from the RIFF parser (big-endian integers). Look for an "ID3" chunk, and let libid3tag parse it.
2009-03-02tag_id3: parse ID3 tags in RIFF/WAV filesMax Kellermann1-0/+32
Added a small RIFF parser library. Look for an "id3" chunk, and let libid3tag parse it.
2009-01-24tag_id3: added MusicBrainz tag supportMax Kellermann1-0/+79
Added support for the MusicBrainz TXXX tags, documented on: http://musicbrainz.org/doc/MusicBrainzTag
2009-01-24tag_id3: always allocate tag objectMax Kellermann1-30/+27
Save some code: always allocate the tag object, and free it when it turns out to be empty.
2009-01-17conf: replaced getConfigParamValue() with config_get_string()Max Kellermann1-2/+2
Don't return a writable pointer.
2009-01-14tag_id3: added support for the "album artist" tagDaniele Sluijters1-0/+12
Read the id3 tags "TPE2" and "TSO2" into the "album artist" tag.
2009-01-04path, tag: don't allocate GError for charset conversionMax Kellermann1-4/+1
Pass NULL instead of &error to g_convert(). We're not interested in the error object.
2009-01-03tag_id3: use GLib instead of utils.hMax Kellermann1-9/+12
2008-12-29tag_id3: use GLib loggingMax Kellermann1-12/+19
2008-12-29tag_id3: strip leading and trailing whitespace from ID3 tagsThomas Jansen1-2/+6
Fix for bug #1491.
2008-12-02replaced mpd_likely/mpd_unlikely by G_LIKELY/G_UNLIKELYThomas Jansen1-2/+2
We want to remove gcc.h eventually. This takes care of all the G_LIKELY/G_UNLIKELY macros.
2008-10-17Makefile.am: don't compile disabled sourcesMax Kellermann1-21/+1
If a feature is disabled, don't compile the source file at all, disable it completely in Makefile.am instead.
2008-10-15path, tag_id3: use g_convert() instead of charConv.cMax Kellermann1-5/+10
GLib provides an easier API for character set conversion than iconv(). Use g_convert() / g_convert_with_fallback() for all character conversions. We should optimize the path.h API later to return a newly allocated buffer, so we can just pass GLib's return value.
2008-10-15tag_id3: fix indentationMax Kellermann1-28/+28
Indentation was broken in tag_id3.c: it used 4 spaces instead of tabs.
2008-08-29const pointersMax Kellermann1-1/+1
Yet another patch which converts pointer arguments to "const".
2008-08-29tag: moved code to tag_id3.cMax Kellermann1-374/+5
The ID3 code uses only the public tag API, but is otherwise unrelated. Move it to a separate source file.
2008-08-29tag: renamed functions, no CamelCaseMax Kellermann1-24/+24
2008-08-29tag: renamed MpdTag and MpdTagItem to struct tag, struct mpd_tag_itemMax Kellermann1-22/+23
Getting rid of CamelCase; not having typedefs also allows us to forward-declare the structures.
2008-08-28const pointersMax Kellermann1-2/+2
The usual bunch of pointer arguments which should be const.
2008-08-28unsigned integers and size_tMax Kellermann1-4/+3
Use "unsigned int" whenever negative values are not meaningful. Use size_t whenever we are going to describe buffer sizes.
2008-08-26converted MpdTagItem.type to an enumMax Kellermann1-3/+5
Don't use CPP macros when you can use C enum... this also allows better type checking.
2008-04-12clean up CPP includesMax Kellermann1-4/+0
Try to only include headers which are really needed. We should particularly check all "headers including other headers". The long-term goal is to have a manageable, small API for plugins (decoders, output) without so many mpd internals cluttering the namespace. git-svn-id: https://svn.musicpd.org/mpd/trunk@7319 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-04-12yet more unsigned integersMax Kellermann1-2/+1
git-svn-id: https://svn.musicpd.org/mpd/trunk@7287 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-04-12whitespace cleanupMax Kellermann1-67/+67
git-svn-id: https://svn.musicpd.org/mpd/trunk@7286 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26use size_tMax Kellermann1-4/+4
When dealing with in-memory lengths, the standard type "size_t" should be used. Missing one can be quite dangerous, because an attacker could provoke an integer under-/overflow, which may provide an attack vector. git-svn-id: https://svn.musicpd.org/mpd/trunk@7205 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26eliminated duplicate initializationMax Kellermann1-5/+5
Local variables which are never read before the first assignment don't need initialization. Saves a few bytes of text. Also don't reset variables which are never read until function return. git-svn-id: https://svn.musicpd.org/mpd/trunk@7199 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-02-05fix -Wconst warningsMax Kellermann1-3/+4
[ew: cleaned up the dirty union hack a bit] Signed-off-by: Eric Wong <normalperson@yhbt.net> git-svn-id: https://svn.musicpd.org/mpd/trunk@7180 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-01-26fixed -Wshadow warningsMax Kellermann1-14/+14
Signed-off-by: Eric Wong <normalperson@yhbt.net> git-svn-id: https://svn.musicpd.org/mpd/trunk@7143 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-01-03Cleanup #includes of standard system headers and put them in one placeEric Wong1-7/+1
This will make refactoring features easier, especially now that pthreads support and larger refactorings are on the horizon. Hopefully, this will make porting to other platforms (even non-UNIX-like ones for masochists) easier, too. os_compat.h will house all the #includes for system headers considered to be the "core" of MPD. Headers for optional features will be left to individual source files. git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-12-28Merge branches/ew r7104Eric Wong1-1/+2
thread-safety work in preparation for rewrite to use pthreads Expect no regressions against trunk (r7078), possibly minor performance improvements in update (due to fewer heap allocations), but increased stack usage. Applied the following patches: * maxpath_str for reentrancy (temporary fix, reverted) * path: start working on thread-safe variants of these methods * Re-entrancy work on path/character-set conversions * directory.c: exploreDirectory() use reentrant functions here * directory/update: more use of reentrant functions + cleanups * string_toupper: a strdup-less version of strDupToUpper * get_song_url: a static-variable-free version of getSongUrl() * Use reentrant/thread-safe get_song_url everywhere * replace rmp2amp with the reentrant version, rmp2amp_r * Get rid of the non-reentrant/non-thread-safe rpp2app, too. * buffer2array: assert strdup() returns a usable value in unit tests * replace utf8ToFsCharset and fsCharsetToUtf8 with thread-safe variants * fix storing playlists w/o absolute paths * parent_path(), a reentrant version of parentPath() * parentPath => parent_path for reentrancy and thread-safety * allow "make test" to automatically run embedded unit tests * remove convStrDup() and maxpath_str() * use MPD_PATH_MAX everywhere instead of MAXPATHLEN * path: get rid of appendSlash, pfx_path and just use pfx_dir * get_song_url: fix the ability to play songs in the top-level music_directory git-svn-id: https://svn.musicpd.org/mpd/trunk@7106 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-11-21When parsing id3_frames take in account that there are different framesQball Cow1-40/+137
and with different field types. This fixes comments for id3v1 and id3v2 git-svn-id: https://svn.musicpd.org/mpd/trunk@7040 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-05-26Changing all calls to ERROR() followed by exit(EXIT_FAILURE) with a singleJ. Alexander Treuman1-2/+1
call to FATAL(). git-svn-id: https://svn.musicpd.org/mpd/trunk@6276 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-04-05The massive copyright updateAvuton Olrich1-1/+1
git-svn-id: https://svn.musicpd.org/mpd/trunk@5834 09075e82-0dd4-0310-85a5-a0d7c8717e4f
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 19:43:01 +0000