aboutsummaryrefslogtreecommitdiffstats
path: root/src/songvec.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-11-12include config.h in all sourcesMax Kellermann1-0/+1
After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
2009-10-31songvec: sort songs by album name first, then disc/track numberMax Kellermann1-1/+30
When the songs of two albums are in the same directory, all songs of an album should be right next to each others.
2009-10-31songvec: simplified compare_tag_item()Max Kellermann1-8/+10
Moved some code to tag_get_value_checked(), to eliminate several NULL checks.
2009-10-13song: renamed attribute "url" to "uri"Max Kellermann1-4/+4
2009-10-13tag: removed the "_ITEM_" suffix from the enum namesMax Kellermann1-2/+2
2009-03-13all: Update copyright header.Avuton Olrich1-0/+19
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
2009-01-15songvec: sort songs by disc and track numberMax Kellermann1-0/+46
Sorting songs by file name does not make much sense. Most of the time, users want to add songs in track order to the playlist.
2009-01-15dirvec, songvec: sort using g_utf8_collate()Max Kellermann1-1/+1
Path names in the directory and song structs are always encoded in UTF-8. Don't use strcmp(), it cannot handle UTF-8 characters properly. Use GLib's UTF-8 aware g_utf8_collate() function for that.
2009-01-03songvec, dirvec: use GLib instead of utils.hMax Kellermann1-8/+9
2008-12-28songvec: migrate from pthread to glib threadsThomas Jansen1-17/+29
2008-12-28Remove xpthread_* wrappersThomas Jansen1-0/+1
2008-10-21update: fix multiple deletes from *vec iteratorsEric Wong1-1/+5
{song,dir}vec_for_each each failed to gracefully handle deleted files when iterating through. While we were thread-safe, we were not safe within the calling thread. If a callback we passed caused sv->nr to shring, our index would still increment; causing files to stay in the database. A way to test this is to remove 10 or so contiguous songs from a >10 song directory.
2008-10-21{dir,song}vec: these structs are constEric Wong1-1/+1
We definitely don't modify them here.
2008-10-14{dir,song}vec: fix off-by-one errors in {dir,song}vec_deleteEric Wong1-7/+6
Found by Valgrind while looking for another bug... Hmm.. I should really just make this code generic since they're duplicated...
2008-10-13songvec: avoid holding nr_lock during free(3)Eric Wong1-3/+5
We only need to lock sv->nr changes to prevent traversals ( why it's called "nr_lock"). free(3) is a "slow" function on my system; so we can avoid unnecessarily holding a lock long for longer than needed.
2008-10-08don't include os_compat.hMax Kellermann1-0/+3
When there are standardized headers, use these instead of the bloated os_compat.h.
2008-10-08song: converted typedef Song to struct songMax Kellermann1-11/+14
Again, a data type which can be forward-declared.
2008-10-07songvec: pass const pointersMax Kellermann1-2/+5
Pass const songvec pointers to songvec_find() and songvec_for_each().
2008-10-07songvec: lock traversals for thread-safe updates/readsEric Wong1-10/+34
Only one lock is used for all songvec traversals since they're rarely changed. Also, minimize lock time and release it before calling iterator functions since they may block (updateSongInfo => stat/open/seek/read). This lock only protects songvecs (and all of them) during traversals; not the individual song structures themselves.
2008-10-07songvec: add songvec_for_each iteratorEric Wong1-0/+13
This is so we can more consistently deal with locking needed for thread-safety in iterator functions.
2008-09-29songvec: songvec_delete takes a const Song pointerEric Wong1-1/+1
We don't modify the Song when we delete it
2008-09-29songvec_free => songvec_destroyEric Wong1-1/+1
"free" implies the songvec structure itself is freed, which is not the case.
2008-09-23songvec: avoid free(NULL)Eric Wong1-2/+4
Potentially broken free() implementations don't like it
2008-09-23songvec: remove songvec_pruneEric Wong1-23/+0
Any pruned files will be noticed during update and pruned from the live database, so this inefficient function can go away and never come back.
2008-09-23Replace SongList with struct songvecEric Wong1-0/+89
Our linked-list implementation is wasteful and the SongList isn't modified enough to benefit from being a linked list. So use a more compact array of song pointers which saves ~200K on a library with ~9K songs (on x86-32).