aboutsummaryrefslogtreecommitdiffstats
path: root/src/screen_search.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Update copyright noticesAvuton Olrich2008-12-311-9/+9
|
* screen_search: use filelist_new() instead of g_malloc0()Max Kellermann2008-11-301-1/+1
| | | | | | Using the advanced search led to a segmentation fault, because with g_malloc0(), the filelist's "entries" array was not allocated. Use the "official" filelist constructor instead.
* list_window: converted "flags" to one "bool" variableMax Kellermann2008-11-271-2/+2
| | | | | | Currently, there is only one known list_window flag ("hide_cursor"). Replace the "flags" bit field with a boolean variable. If we run out of space some day, we can convert that to bool:1.
* list_window: use "bool" instead of "int"Max Kellermann2008-11-271-1/+1
| | | | | For flags and return values, use the "bool" data type instead of "int".
* screen_search.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-5/+4
|
* screen_search: don't include ncurses.h directlyMax Kellermann2008-11-191-1/+0
| | | | | | screen.h has a check whether to include ncursesw/ncurses.h or ncurses.h. screen_search.c doesn't need to include it a second time, and was missing the check.
* screen: method cmd() returns boolMax Kellermann2008-11-181-6/+6
| | | | Return true/false instead of 1/0.
* screen_{file,artist,search}: repaint only if screen is visibleMax Kellermann2008-11-181-1/+2
| | | | | Don't repaint the screen after browser_cmd() if another screen has been selected meanwhile.
* wreadln: return NULL instead of empty stringMax Kellermann2008-11-071-5/+0
| | | | | | No wreadln() caller cares about an empty string. Simplify the callers by returning NULL instead of an allocated empty string. This fixes several memory leaks.
* mpdclient: expect UTF-8 stringsMax Kellermann2008-11-071-3/+5
| | | | | | Don't convert the character set of strings to and from the current locale. This library cannot know what the strings are going to be used for, so it should not mess with them.
* screen_search: fixed 2 memory leaksMax Kellermann2008-11-071-0/+6
| | | | | Free the old pattern before prompting for a new one. Free the old filelist object before retrieving the new one.
* screen: export the global variable "screen"Max Kellermann2008-10-031-10/+10
| | | | | screen_t is a singleton. We do not have to pass it around everywhere. Export the one global variable.
* screen: don't pass mpdclient pointer to method paint()Max Kellermann2008-10-031-3/+3
| | | | | None of the paint() implementations acutally uses the mpdclient pointer. Remove it from the method signature.
* screen_search: array index is tag idMax Kellermann2008-10-031-24/+19
| | | | | Save some bytes again: remove search_tag.id, make the array index equal to the tag id.
* don't import mpdclient_finish_command() twiceMax Kellermann2008-10-031-2/+0
| | | | | mpdclient_finish_command() is already imported by mpdclient.h, don't do it again in the sources.
* screen_search: removed the FUTURE macroMax Kellermann2008-10-031-11/+0
| | | | The future is now!
* moved code to charset.cMax Kellermann2008-10-021-1/+1
| | | | | Move everything which deals with UTF-8 strings and character set conversion to charset.c, header charset.h.
* moved i18n macros to i18n.hMax Kellermann2008-10-021-1/+1
| | | | | Don't make everybody include ncmpc.h just to have generic features. Move generic i18n macros to a separate header.
* removed the debugging function D()Max Kellermann2008-10-021-3/+0
| | | | gdb is for debugging. We don't need D() calls littered all over.
* screen_browser: added browser_cmd()Max Kellermann2008-10-021-47/+1
| | | | Merge a lot of code from the 3 browser screen into browser_cmd().
* screen_browser: added hotkey for adding songMax Kellermann2008-09-251-0/+8
| | | | | CMD_ADD ('a') appends a song to the playlist, no matter if it is already there, i.e. unlike CMD_SELECT, it does not toggle the song.
* screen: replaced get_cur_mode_id() with screen_is_visible()Max Kellermann2008-09-251-1/+1
| | | | | | Screen code shouldn't know anything about the screen ids (which will be eliminated completely later). Instead of comparing ids, compare the screen_functions pointer.
* screen: don't compile disabled sourcesMax Kellermann2008-09-251-5/+0
| | | | | Instead of evaluating macros from config.h in the disabled source, don't start the compiler on it at all.
* filelist: removed attribute "updated"Max Kellermann2008-09-251-4/+0
| | | | | Since all screen updating is now on demand, we don't need this flag anymore.
* screen_search: removed update() methodMax Kellermann2008-09-251-25/+44
| | | | | Repaint the search screen on demand. No need for the update() method anymore.
* screen_search: removed version check from paint() methodMax Kellermann2008-09-251-5/+1
| | | | | The check wasn't actually doing anything, except leaking memory. Remove it.
* screen: don't pass screen pointer to method paint()Max Kellermann2008-09-251-4/+4
| | | | | None of the paint() implementations actually use the screen pointer - remove it from the method signature.
* screen: don't call wrefresh() in methods paint() and update()Max Kellermann2008-09-251-3/+0
| | | | | | screen_paint() and screen_update() are responsible for refreshing the screen. We can remove all wrefresh() and wnoutrefresh() invocations from all paint() and update() method implementations.
* list_window: removed property "clear"Max Kellermann2008-09-251-2/+0
| | | | | Without clearing previous screen contents, there may be corruptions, make this mandatory and optimize screen clearing.
* code style, indent with tabs XMax Kellermann2008-09-251-3/+1
| | | | Follow the same code style als MPD itself.
* browse: ensure that filelist!=NULLMax Kellermann2008-09-211-4/+15
| | | | | There are several places where browser.filelist can become NULL. Catch that everywhere and generate an empty filelist in this case.
* screen_search: free second file listMax Kellermann2008-09-191-0/+1
| | | | Fix a memory leak: the concatened list was never freed.
* filelist: provide more functions for working with a filelistMax Kellermann2008-09-191-14/+8
| | | | Avoid direct accesses to the filelist struct, provide an API for that.
* filelist: drop "mpdclient" prefixMax Kellermann2008-09-191-3/+3
| | | | | The separate filelist library does not depend on mpdclient, so the prefix is superfluous.
* screen_browser: moved code to browser_playlist_changed()Max Kellermann2008-09-181-12/+2
| | | | | Merge code from all 3 browser screens into one generic browser function.
* screen_browser: moved code to screen_browser.cMax Kellermann2008-09-181-10/+7
| | | | Isolate the generic browser code from the directory browser.
* screen_browser: added struct screen_browserMax Kellermann2008-09-181-49/+54
| | | | | We are going to separate the browser functions from screen_file.c. Move all variables which are going to be needed by this code.
* renamed screen_browse.h to screen_browser.hMax Kellermann2008-09-181-1/+1
|
* code style, indent with tabs VIMax Kellermann2008-09-181-218/+204
| | | | Follow the same code style als MPD itself.
* screen: removed empty methodsMax Kellermann2008-09-181-6/+0
| | | | | Declaring empty methods is of no use. If a method is empty, we should set it to NULL in the screen_functions struct.
* make several functions return voidMax Kellermann2008-09-171-3/+4
|
* screen: removed screen_functions.get_lw()Max Kellermann2008-09-171-7/+0
| | | | | | If it is really important to set the curser, we should think of a better way, instead of exporting one non-generic method. For now, just set the cursor to the origin.
* replaced get_screen_X() with static screen_functions variableMax Kellermann2008-09-171-20/+12
| | | | | | Compile time initialization saves resources, compared to run-time initialization. Declare all screen_function structs as global variables, and remove all get functions.
* code style, indent with tabs IIIMax Kellermann2008-09-171-19/+19
| | | | Follow the same code style als MPD itself.
* fix unused parameter warningsMax Kellermann2008-09-151-6/+9
| | | | | Add the "unused" attribute to all function parameters which are indeed going to be ignored.
* use size_t and unsigned integersMax Kellermann2008-09-151-2/+2
|
* fixed mixed declaration + codeMax Kellermann2008-09-151-5/+3
| | | | | Although they are allowedd in C99, try to avoid them. Move variable declarations to the top of the current scope.
* fix shadow warningsMax Kellermann2008-09-151-15/+18
| | | | | Rename local variables and function parameters, so they don't shadow global variables.
* include cleanupMax Kellermann2008-09-151-6/+7
| | | | | | A header should include all headers which he needs. Move local includes on top, and let foo.c include foo.h in the first line, to automatically test its dependencies.
* fix function prototypesMax Kellermann2008-09-151-2/+2
| | | | | | Add missing prototypes, and fix wrong prototypes. Convert lots of functions to "static" when they are only used within the current source file.