aboutsummaryrefslogtreecommitdiffstats
path: root/src/screen_play.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* screen_play: no song means id=-1Max Kellermann2008-09-281-3/+3
| | | | | | "prev_song_id" and "current_song_id" had value 0 if MPD was not playing at all. This way, ncmpc cannot see the difference between "song 0 playing" and "not playing". Change "not playing" to -1.
* screen_play: repaint highlight when mpd starts playingMax Kellermann2008-09-281-1/+2
| | | | | When deciding whether to repaint the current highlight, test if MPD is actually playing. If MPD starts playing, repaint.
* screen_play: repaint if current song has changedMax Kellermann2008-09-261-8/+10
| | | | | | | | The play_update() function was reduced too much: it didn't repaint the screen when the current song changed. Add check for that. Don't repaint the screen in center_playing_item(), make the caller do it.
* screen: replaced get_cur_mode_id() with screen_is_visible()Max Kellermann2008-09-251-1/+1
| | | | | | Screen code shouldn't know anything about the screen ids (which will be eliminated completely later). Instead of comparing ids, compare the screen_functions pointer.
* screen: don't pass screen pointer to method update()Max Kellermann2008-09-251-2/+4
| | | | | play_update() is the only update() implementation left, and it does not use the screen pointer. Remove it from the method signature.
* screen_play: hide cursor with a timerMax Kellermann2008-09-251-20/+45
| | | | | Instead of hiding the cursor in the update() callback, hide it with a glib main loop timeout.
* screen_playlist: don't repaint in update()Max Kellermann2008-09-251-17/+45
| | | | | Repaint the playlist window on demand. Don't repaint it unconditionally in play_update().
* screen: don't pass screen pointer to method paint()Max Kellermann2008-09-251-3/+3
| | | | | None of the paint() implementations actually use the screen pointer - remove it from the method signature.
* screen: don't call wrefresh() in methods paint() and update()Max Kellermann2008-09-251-2/+0
| | | | | | screen_paint() and screen_update() are responsible for refreshing the screen. We can remove all wrefresh() and wnoutrefresh() invocations from all paint() and update() method implementations.
* list_window: removed property "clear"Max Kellermann2008-09-251-10/+3
| | | | | Without clearing previous screen contents, there may be corruptions, make this mandatory and optimize screen clearing.
* code style, indent with tabs XMax Kellermann2008-09-251-166/+161
| | | | Follow the same code style als MPD itself.
* screen_play: use list_window_check_selected()Max Kellermann2008-09-231-5/+1
| | | | Instead of manually adjusting the selection, let list_window.c do it.
* screen: simplified CMD_SCREEN_UPDATE handlersMax Kellermann2008-09-221-3/+2
| | | | | Since screen.c has default code for CMD_SCREEN_UPDATE, return 0 from the command handlers and let screen.c do the rest.
* screen: don't set list_window->repaintMax Kellermann2008-09-221-6/+1
| | | | | | Several screens ignore the attribute list_window->repaint. Don't set it there. It will be replaced with a more intelligent repaint algorithm later.
* screen: moved input_timestamp to screen_play.cMax Kellermann2008-09-221-1/+6
| | | | Since the input_timestamp is only used by screen_play, move it there.
* screen: moved list_window mouse code to list_window.cMax Kellermann2008-09-221-1/+2
| | | | | | Move the portion of screen_get_mouse_event() which handles list_window clicks to list_window.c. The code contained a NULL pointer dereference, which is now fixed.
* playlist: removed "updated" flagMax Kellermann2008-09-181-2/+3
| | | | | The caller may check the playlist.id instead of checking the old "updated" flag.
* screen: check MPD status only if connectedMax Kellermann2008-09-181-4/+7
| | | | | | Fix several segmentation faults: when the connection to the MPD server is lost, there were NULL pointer dereferences because client->status==NULL. Check before accessing it.
* screen: removed NULL checkMax Kellermann2008-09-181-2/+1
| | | | | Since the screen's initialization is guaranteed, we can remove the NULL check in center_playing_item().
* make several functions return voidMax Kellermann2008-09-171-4/+4
|
* playlist: use playlist_get() instead of playlist_get_song()Max Kellermann2008-09-171-2/+3
|
* list_window: don't reset *highlight to 0Max Kellermann2008-09-171-1/+0
| | | | | Since the list_window code sets highlight to 0 before it calls the list_callback, the callback itself doesn't have to reset the flag.
* list_window: added list_window_center()Max Kellermann2008-09-171-8/+3
| | | | | Merge code which used to be duplicated in the screens "play", "help", "lyrics".
* screen: removed screen_functions.get_lw()Max Kellermann2008-09-171-7/+0
| | | | | | If it is really important to set the curser, we should think of a better way, instead of exporting one non-generic method. For now, just set the cursor to the origin.
* replaced get_screen_X() with static screen_functions variableMax Kellermann2008-09-171-19/+12
| | | | | | Compile time initialization saves resources, compared to run-time initialization. Declare all screen_function structs as global variables, and remove all get functions.
* use GArray for playlist instead of GListMax Kellermann2008-09-151-10/+10
| | | | | | Using a doubly linked list for the local playlist copy is a huge waste of both memory and CPU cycles. Use GArray instead of GList, which is much faster in this case.
* fix unused parameter warningsMax Kellermann2008-09-151-9/+10
| | | | | Add the "unused" attribute to all function parameters which are indeed going to be ignored.
* use size_t and unsigned integersMax Kellermann2008-09-151-9/+10
|
* fix shadow warningsMax Kellermann2008-09-151-6/+6
| | | | | Rename local variables and function parameters, so they don't shadow global variables.
* include cleanupMax Kellermann2008-09-151-7/+7
| | | | | | A header should include all headers which he needs. Move local includes on top, and let foo.c include foo.h in the first line, to automatically test its dependencies.
* fix function prototypesMax Kellermann2008-09-151-8/+11
| | | | | | Add missing prototypes, and fix wrong prototypes. Convert lots of functions to "static" when they are only used within the current source file.
* const pointersMax Kellermann2008-09-151-2/+2
| | | | | Convert pointers to const whenever it is possible. Fixes all those -Wconst warnings.
* code style, indent with tabsMax Kellermann2008-09-151-208/+184
| | | | | | | Follow the same code style als MPD itself. This patch only fixes parts of the code which are going to be touched in the following bunch of patches, i.e. there will be more "code style" patches in the future.
* remove unused static functionsMax Kellermann2008-09-151-1/+1
| | | | Also remove some commented code and unused function parameters.
* Removed nested functionsAndreas Obergrusberger2007-08-261-66/+112
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6811 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Dont include panel.hKalle Wallin2005-06-141-1/+0
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@3354 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added a "hide cursor" feature #0000417Kalle Wallin2005-06-031-0/+13
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@3307 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Enable playlist saving on the browse screenKalle Wallin2005-02-131-5/+6
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@2949 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Fixed abort (Ctrl-G) handling in the save playlist promptKalle Wallin2004-12-131-1/+2
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@2794 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added a search screenKalle Wallin2004-11-151-1/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@2668 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Use glib's str functions (g_strlcat, g_strlcpy, g_snprintf, g_strdup_vprintf)Kalle Wallin2004-07-131-3/+4
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1868 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added basic ncurses mouse supportKalle Wallin2004-07-021-0/+43
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1770 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Make shure the list scrolls when moving a songKalle Wallin2004-07-021-0/+2
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1767 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Removed the trim() function, using glib's g_strstrip() insteadKalle Wallin2004-07-011-1/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1751 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Clear the main window on CMD_SCREEN_UPDATEKalle Wallin2004-06-221-0/+3
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1617 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added _utf8 suffix to all functions that take utf8 arguments.Kalle Wallin2004-06-201-5/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1587 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Make shure the list window is repainted after a completion list is displayedKalle Wallin2004-06-191-6/+11
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1569 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* added type argument to gcmp_list_from_path()Kalle Wallin2004-06-191-7/+47
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1567 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added a add command (for adding files or urls to the playlist)Kalle Wallin2004-06-181-0/+78
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1554 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* libmpdclient updated (r1507) - added path to mpdclient_cmd_db_update() Kalle Wallin2004-06-161-0/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/trunk@1508 09075e82-0dd4-0310-85a5-a0d7c8717e4f
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-28 08:56:14 +0000