aboutsummaryrefslogtreecommitdiffstats
path: root/src/player_thread.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-12-28decoder: terminate decoder thread before MPD cleanupMax Kellermann1-0/+1
When MPD exits, it should manually free all resources in use, to allow easy memory leak debugging. Make the decoder thread terminate during that.
2008-11-25player: set elapsed=0 at song changeMarc Pavot1-0/+1
I have found something that looks like a bug in MPD: - When a song is finished, the next one is played and the 'player' event is emitted. - When the client sends the status command just after this event, the songid is the new one but the 'elapsed' time is not reseted to 0. This is problem because I have implemented the solution using a timer on client side to compute the elapsed time but with this bug the elapsed time continues to be incremented on a new song.
2008-11-24player_thread.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen1-1/+3
2008-11-24player: disable music_pipe_check_format()Max Kellermann1-0/+2
The music pipe audio format bugs seem to be fixed (hopefully). Disable music_pipe_check_format() for now, since it consumes a lot of CPU cycles.
2008-11-14player: don't queue song when there are 2 songs in the pipeMax Kellermann1-0/+5
Don't send a "next song" request to the main thread when the current song hasn't started playing yet, i.e. there are already two different songs in the music pipe. This would erase information about the song boundary within the music pipe, and thus triggered an assertion failure. The bug could occur when playing very short songs which fit into the pipe as a whole.
2008-11-14player: wake up decoder before waiting for xfade chunksMax Kellermann1-0/+1
Fix a deadlock: when the decoder waited for buffer space, the player could enter a deadlock situation because it waits for more chunks for crossfading chunks. Signal the decoder before entering notify_wait().
2008-11-13player: chop the tail of the music pipe after CANCELMax Kellermann1-0/+1
When a CANCEL command is received, the player should drop all chunks of the next song. Added new funciton music_pipe_chop() which is used for that.
2008-11-13music_pipe: continuously check the sample format of all chunksMax Kellermann1-0/+6
Provide a debug function which asserts on the sample format of all chunks. Call this function in each iteration of the player main loop.
2008-11-13player: assert that there was no previous "next song chunk"Max Kellermann1-0/+1
When assigning the next_song_chunk variable, it must have been empty. If not, there may be 3 songs overlapping in the music pipe.
2008-11-11player: fix race condition during tag updateMax Kellermann1-2/+4
When a tag is updated, the old tag was freed before the new one was created. Reverse the order to be sure that other threads always see a valid pointer. This still leaves a possible race condition, but it will be addressed later.
2008-11-08decoder: converted dc.error to a dc.state valueMax Kellermann1-2/+2
The player did not care about the exact error value, it only checked whether an error has occured. This could fit well into decoder_control.state - introduce a new state "DECODE_STATE_ERROR".
2008-11-03player: no CamelCaseMax Kellermann1-28/+28
Renamed variables and internal functions. Most of the player_control.h API remains in CamelCase for now.
2008-11-03decoder: no CamelCaseMax Kellermann1-2/+2
Renamed variables and functions.
2008-11-02player: don't play empty chunksMax Kellermann1-0/+3
An empty chunk may happen when it only contains a tag, but no PCM data. Don't call playAudio() then.
2008-11-02player: copy stream tag to the song structMax Kellermann1-5/+19
Non-local songs used to have no tags. If the decoder sends us a tag, we should incorporate it into the song struct. This way, clients can always show the correct song name (if provided by the server).
2008-11-02player: added player.songMax Kellermann1-0/+7
Always remember which song is currently being sent to the audio device.
2008-11-02player: send chunk tag to audio deviceMax Kellermann1-0/+3
If a chunk contains a tag, send it to the audio output device. Few output plugins support this, e.g. shout has support for sending tags.
2008-11-02music_pipe: no CamelCaseMax Kellermann1-4/+4
Rename all variables and struct members.
2008-11-02music_pipe: more wrapper functionsMax Kellermann1-8/+6
Replace all direct music_pipe struct accesses with wrapper functions. The compiled machine code is the same, but this way, we can change struct internals more easily.
2008-11-02decoder: replaced music_pipe.audioFormat with dc.out_audio_formatMax Kellermann1-6/+6
.. and rename dc.audioFormat to dc.in_audio_format. The music pipe does not need to know the audio format, and its former "audioFormat" property indicated the format of the most recently added chunk, which might be confusing when you are reading the oldest chunks.
2008-11-02music_pipe: renamed ob_* functions to music_pipe_*Max Kellermann1-16/+17
Rename all functions to the new prefix.
2008-11-02music_pipe: renamed struct output_buffer to struct music_pipeMax Kellermann1-3/+5
.. and rename ob_chunk to struct music_chunk.
2008-10-30decoder: use bool for return values and flagsMax Kellermann1-4/+4
Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
2008-10-29output: always call cancel() before stop()Max Kellermann1-4/+2
Stopping an audio output device without cancelling its buffer doesn't make sense. Combine the two operations, which saves several cancel calls.
2008-10-29output: use bool for return values and flagsMax Kellermann1-5/+4
Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
2008-10-29player: handle songs shorter than the initial bufferMax Kellermann1-1/+2
When the decoder exited before the buffer has grown big enough ("buffer_before_play"), the player thread waited forever. Add an additional check which disables buffering as soon as the decoder exits.
2008-10-29player: added variable "play_audio_format"Max Kellermann1-2/+4
The local variable "play_audio_format" is updated every time the player starts playing a new song. This way, we always know exactly which audio format is current. The old code broke when a new song had a different format: ob.audio_format is the format of the next song, not of the current one - using this caused breakage for the software volume control.
2008-10-29player: request new song only if there is no pending commandMax Kellermann1-1/+2
Request the next song from the playlist (by clearing pc.next_song) only if the player command is empty. If it is not, the player may be clearing the song that has already been queued, leading to an assertion failure.
2008-10-27player: reset pc.command when decoder startup failsMax Kellermann1-0/+1
When the decoder failed to start, the function do_play() returned, still having pc.command==PLAY. This is because pc.command was reset only when the decoder started up successfully. Add another player_command_finished() call in the error handler.
2008-10-24player: don't clear command before do_play() returnsMax Kellermann1-1/+0
This bug caused the audio output devices to stay open, although MPD wasn't playing: quitDecode() resetted player_control.command, assuming that the command was STOP. This way, player_task() didn't see the CLOSE_AUDIO command, and the device was kept open. Don't clear player_control.command in quitDecode().
2008-10-23player: don't send partial frames of silenceMax Kellermann1-1/+7
Another partial frame fix: the silence buffer was 1020 bytes, which had room for 127.5 24 bit stereo frames. Don't send the partial last frame in this case.
2008-10-21pcm_utils: no CamelCaseMax Kellermann1-2/+2
Renamed all functions which were still in CamelCase.
2008-10-12player: replaced buffered_before_play with buffering flagMax Kellermann1-9/+10
buffered_before_play was copied to struct player because it was used to disable buffering when seeking. Instead of mainaining a copy of this number, move just the flag to the player struct.
2008-10-12player: added commands QUEUE and CANCELMax Kellermann1-29/+48
QUEUE adds a new song to the player's queue. CANCEL clears the queue. These two commands replace the old and complex queueState and queueLockState code.
2008-10-12player: added struct playerMax Kellermann1-48/+75
The player struct holds the local variables which used to be passed to all those helper functions in player_thread.c.
2008-10-11player: removed player_control.fileTimeMax Kellermann1-1/+2
This variable is superfluous, it is only used to copy its value to player_control.totalTime. Since the original source of this value (song->tag->time) will still be available at this point, we can safely remove fileTime.
2008-10-10player: don't wake up decoder after every frameMax Kellermann1-1/+7
The decoder was woken up after each chunk which had been played. That caused a lot of superfluous context switches. Wake up the decoder only when a certain amount of the buffer has been consumed. This formula is somewhat arbitrary, and has to be proven experimentally.
2008-10-10player: added player_control.audio_formatMax Kellermann1-6/+2
This replaces the attributes bits, channels, sampleRate.
2008-10-10audio_format: renamed sampleRate to sample_rateMax Kellermann1-1/+1
The last bit of CamelCase in audio_format.h. Additionally, rename a bunch of local variables.
2008-10-08song: removed CamelCaseMax Kellermann1-2/+2
CamelCase is ugly... rename all functions.
2008-10-08use the "bool" data type instead of "int"Max Kellermann1-4/+4
"bool" should be used in C99 programs for boolean values.
2008-10-08song: converted typedef Song to struct songMax Kellermann1-0/+1
Again, a data type which can be forward-declared.
2008-09-29audio_output: added method pause()Max Kellermann1-1/+1
pause() puts the audio output into pause mode: if supported, it may perform a special action, which keeps the device open, but does not play anything. Output plugins like "shout" might want to play silence during pause, so their clients won't be disconnected. Plugins which do not support pausing will simply be closed, and have to be reopened when unpaused. This pach includes an implementation for the shout plugin, which sends silence chunks.
2008-09-26notify: protect notify->pending with the mutexMax Kellermann1-2/+0
There was a known deadlocking bug in the notify library: when the other thread set notify->pending after the according check in notify_wait(), the latter thread was deadlocked. Resolve this by synchronizing all accesses to notify->pending with the notify object's mutex. Since notify_signal_sync() was never used, we can remove it. As a consequence, we don't need notify_enter() and notify_leave() anymore; eliminate them, too.
2008-09-07audio_format: converted typedef AudioFormat to struct audio_formatMax Kellermann1-1/+1
Get rid of CamelCase, and don't use a typedef, so we can forward-declare it, and unclutter the include dependencies.
2008-08-26moved player_command_finished() to player_thread.cMax Kellermann1-0/+8
2008-08-26moved code to pc_init(), dc_init()Max Kellermann1-3/+2
2008-08-26renamed player.c to player_control.cMax Kellermann1-1/+1
Give player.c a better name, meaning that the code is used to control the player thread.
2008-08-26renamed decode.h to decoder_control.hMax Kellermann1-1/+1
2008-08-26moved global variable "pc" to player.hMax Kellermann1-0/+1
This is the last of the three variables. Now we don't need playerData.h anymore in most sources.