aboutsummaryrefslogtreecommitdiffstats
path: root/src/output_init.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-12-13output_init: initialize replay gain filters to NULL in ao_base_init()Denis Krjuchkov1-0/+2
If output plugin fails to init it will try to call ao_base_finish() immediately, which segfaults because replay gain filters are not initialized yet and contain garbage values.
2011-09-19output_plugin: the plugin allocates the audio_output objectMax Kellermann1-67/+101
Pass audio_output objects around instead of void pointers. This will give some more control to the plugin, and prepares for non-blocking audio outputs.
2011-09-01output_thread: reimplement CANCEL synchronizationMax Kellermann1-0/+1
The output thread could hang indefinitely after finishing CANCEL, because it could have missed the signal while the output was not unlocked in ao_command_finished(). This patch removes the wait() call after CANCEL, and adds the flag "allow_play" instead. While this flag is set, playback is skipped. With this flag, there will not be any excess wait() call after the pipe has been cleared. This patch fixes a bug that causes mpd to discontinue playback after seeking, due to the race condition described above.
2011-01-29copyright year 2011Max Kellermann1-1/+1
2011-01-10player_control: removed the global variable "pc"Max Kellermann1-0/+5
Allocate a player_control object where needed, and pass it around. Each "client" object is associated with a "player_control" instance. This prepares multi-player support.
2010-05-02output_thread: call replay gain filter manuallyMax Kellermann1-2/+9
Don't add it to the filter chain, because we need to apply replay gain before cross-fading with the next song. Add a second replay_gain filter which is used for the song being faded in (chunk->other).
2010-05-02player_thread: move cross-fading to output threadMax Kellermann1-0/+2
Remove cross_fade_apply(), and call pcm_mix() in the output thread, mixing the chunk and chunk->other together.
2010-03-10output: added option "always_on" for radio stationsMax Kellermann1-0/+1
Did you ever accidently click "stop" while feeding a radio station? This option sets the output device to "pause" to disable the "close" method. It falls back to "pause" then, which is specific to the plugin. Some plugins implement it by feeding silence.
2010-02-17replay_gain: optionally use hardware mixer to apply replay gainMax Kellermann1-5/+28
Add an option for each audio output which enables the use of the hardware mixer, instead of the software volume code. This is hardware specific, and assumes linear volume control. This is not the case for hardware mixers which were tested, making this patch somewhat useless, but we will use it to experiment with the settings, to find a good solution.
2010-02-17replay_gain: reimplement as a filter pluginMax Kellermann1-0/+11
Apply the replay gain in the output thread. This means a new setting will be active instantly, without going through the whole music pipe. And we might have different replay gain settings for each audio output device.
2009-12-31Update copyright notices.Avuton Olrich1-1/+1
2009-12-25output_init: use the normalize filter pluginMax Kellermann1-0/+11
Use the plugin instead of the glue code in normalize.c. This is used wrapped inside a "autoconv" filter, to enable normalization for all input file formats.
2009-12-14Proper error reporting from filter_configAlbin Eldstål-Damlin1-1/+10
2009-12-14Split filter_config into its own moduleAlbin Eldstål-Damlin1-0/+1
2009-12-14Initial filter chain and filter configuration for outputs.Albin Eldstål-Damlin1-0/+4
2009-11-12include config.h in all sourcesMax Kellermann1-0/+1
After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
2009-10-29output: consistently lock audio output objectsMax Kellermann1-1/+1
Always keep the audio_output object locked within the output thread, unless a plugin method is called. This fixes several race conditions.
2009-10-23output_plugin: added methods enable() and disable()Max Kellermann1-0/+1
With these methods, an output plugin can allocate some global resources only if it is actually enabled. The method enable() is called after daemonization, which allows for more sophisticated resource allocation during that method.
2009-10-21audio_format: wildcards allowed in audio_format configurationMax Kellermann1-3/+2
An asterisk means that this attribute should not be enforced, and stays whatever it used to be. This way, some configuration values work like masks.
2009-10-21output: convert config_audio_format to an audio_format structMax Kellermann1-6/+7
This allows more sophisticated audio format selection.
2009-10-21mixer_plugin: pass audio_output pointer to mixer_plugin.init()Max Kellermann1-4/+5
This allows the mixer object to access its associated audio output object.
2009-10-20mixer_plugin: use GError for error handlingMax Kellermann1-4/+11
2009-10-20output_init: renamed parameter "error" to "error_r"Max Kellermann1-7/+7
It's a double pointer.
2009-08-18output_init: initialize the "pause" flagMax Kellermann1-0/+1
Fix stuttering due to uninitialized variable.
2009-07-06output: use the software mixer pluginMax Kellermann1-6/+52
Do all the software volume stuff inside each output thread, not in the player thread. This allows one software mixer per output device, and also allows the user to configure the mixer type (hardware or software) for each audio output. This moves the global "mixer_type" setting into the "audio_output" section, deprecating the "mixer_enabled" flag.
2009-07-06output_init: moved the "convert" filter at the endMax Kellermann1-5/+9
The "convert" filter must be the last filter in the chain. Ensure that by doing its initialization at the very end of audio_output_init().
2009-07-06output_init: merge two local string variablesMax Kellermann1-11/+9
2009-07-06output_init: parse audio format earlierMax Kellermann1-12/+10
2009-07-06output: attach a filter chain to each audio_outputMax Kellermann1-1/+14
This patch adds initial filter support for audio outputs. Each audio output gets a "filter" attribute, which is used by ao_play_chunk(). The PCM conversion is now performed by convert_filter_plugin. audio_output.convert_state has been removed.
2009-07-05output_init: moved mixer instantiation to separate functionMax Kellermann1-5/+14
2009-04-28output_init: added option to disable the hardware mixerMax Kellermann1-1/+2
Added the per-device option "mixer_enabled" which allows users to disable the hardware mixer of an audio output.
2009-03-26output_plugin: replaced output_plugin.get_mixer() with mixer_pluginMax Kellermann1-0/+6
The mixer core library is now responsible for creating and managing the mixer object. This removes duplicated code from the output plugins.
2009-03-20output: convert audio_output.config_audio_format to booleanMax Kellermann1-5/+6
The config_audio_format used to contain the configured audio format, which is copied to out_audio_format. Let's convert the former to a boolean, which indicates whether out_audio_format was already set. This simplifies some code and saves a few bytes.
2009-03-13all: Update copyright header.Avuton Olrich1-6/+7
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
2009-03-09output: play from a music_pipe objectMax Kellermann1-0/+1
Instead of passing individual buffers to audio_output_all_play(), pass music_chunk objects. Append all those chunks asynchronously to a music_pipe instance. All output threads may then read chunks from this pipe. This reduces MPD's internal latency by an order of magnitude.
2009-03-01output_init: removed getBlockParam()Max Kellermann1-18/+20
Use config_get_block_string() and manual GError handling instead.
2009-03-01output_init: return GError on errorMax Kellermann1-19/+15
Do error handling with GError instead of aborting with g_error().
2009-03-01output_init: moved code to audio_output_detect()Max Kellermann1-16/+26
2009-02-28output: use GTimer instead of time_t for reopen after failureMax Kellermann1-1/+1
time() is not a monotonic timer, and MPD might get confused by clock skews. clock_gettime() provides a monotonic clock, but is not portable to non-POSIX systems (i.e. Windows). This patch uses GLib's GTimer API, which aims to be portable.
2009-02-28output: added option to disable audio outputs by defaultMax Kellermann1-1/+1
The option "enabled" is on by default. If you specify "enabled no" in an audio_output section, then this device is disabled by default.
2009-02-26output_plugin: report errors with GErrorMax Kellermann1-3/+8
Use GLib's GError library for reporting output device failures. Note that some init() methods don't clean up properly after a failure, but that's ok for now, because the MPD core will abort anyway.
2009-02-25output: audio_output_init() returns boolMax Kellermann1-4/+4
Return true/false instead of 1/0.
2009-02-25output: set a GLib log domainMax Kellermann1-0/+3
2009-02-25output_plugin: don't pass audio_output object to method init()Max Kellermann1-1/+1
audio_output_get_name() has been removed, which was the only function left in output_api.h. The output plugin doesn't need the audio_output object at all, remove the parameter from the init() method.
2009-02-16output_plugin: added inline wrapper functionsMax Kellermann1-3/+4
Similar to the decoder plugin API: added wrapper functions to increase code readability.
2009-02-11audio: replaced parseAudioConfig() with audio_format_parse()Max Kellermann1-4/+9
Added audio_format_parse() in a separate library, with a modern interface: return a GError instead of logging errors. This allows the caller to deal with the error.
2009-02-10output_api: no CamelCase in struct audio_outputMax Kellermann1-4/+5
Renamed audio_output struct members.
2009-01-25conf: const pointers in block get functionsMax Kellermann1-1/+1
All config_get_block_*() functions should accept constant config_param pointers.
2009-01-17conf: no CamelCase, part IMax Kellermann1-2/+3
Renamed functions, types, variables.
2009-01-17pcm_convert: return PCM buffer from pcm_convert()Max Kellermann1-3/+0
Removed yet another superfluous buffer layer: return the PCM buffer from pcm_convert() instead of copying PCM data into the caller-supplied buffer.