Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | pulse_mixer: allow mpd to reconnect to the pulse mixer | David Guibert | 2009-03-07 | 1 | -29/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | | This patch follows the commit 21bb10f4b. >From Max Kellermann: > I removed the daemonization changes in main.c. Please explain why you > changed that. If you need it for some reason, make that a separate > patch with a good description of your rationale. > That's the biggest flaw of your code: it opens the mixer device in the > init() method, while the open() method is empty. When the pulse > daemon is not available (either during MPD startup or when it dies > while MPD runs), the plugin will not even attempt to reconnect to > pulse. Please move the code to the open() method, to make that work. I changed the daemonize call as the fork losts the connection to the pulse server. According to your remark, the init() method should be moved to the open() ones. With the modification, mpd is able to reconnect the pulse mixer after restarting the pulseaudio daemon. Signed-off-by: David Guibert <david.guibert@gmail.com> Signed-off-by: Max Kellermann <max@duempel.org> | ||||
* | pulse_mixer: added missing copyright header | Max Kellermann | 2009-03-07 | 1 | -0/+18 |
| | |||||
* | pulse_mixer: added GLib log domain | Max Kellermann | 2009-03-07 | 1 | -14/+16 |
| | | | | Shorten some log messages, let GLib add the "pulse_mixer" prefix. | ||||
* | pulse: clean up includes | Max Kellermann | 2009-03-07 | 1 | -2/+4 |
| | | | | | Don't include output_api.h - this is not an output plugin. Added missing explicit conf.h and string.h includes. | ||||
* | pulse mixer | David Guibert | 2009-03-07 | 1 | -0/+277 |
This patch introduces the mixer for the pulse output. Technically speaking, the pulse index is needed to get or set the volume. You must define callback fonctions to get this index since the pulse output in mpd is done using the simpe api. The pulse simple api does not provide the index of the newly defined output. So callback fonctions are associated to the pulse context. The list of all the sink input is then retreived. Then we select the name of the mpd pulse output and control its volume by its associated index number. Signed-off-by: Patrice Linel <patnathanael@gmail.com> Signed-off-by: David Guibert <david.guibert@gmail.com> [mk: fixed whitespace errors and broke long lines; removed daemonization changes from main.c] |