aboutsummaryrefslogtreecommitdiffstats
path: root/src/mixer/plugins/PulseMixerPlugin.cxx (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-03-05PulseOutputPlugin: avoid locking mainloop object from within mainloop threadPete Beardmore1-5/+14
-fixes regression introduced by: '8d6fedf8177d0d2ced81e6d93d35c368b2ac69db [PATCH] Mixer: add class MixerListener' -listener.OnMixerVolumeChanged() called GetVolume() which attempted to acquire the lock but as per 'pa_threaded_mainloop_lock()' documentation: This function may not be called inside the event loop thread. Events that are dispatched from the event loop thread are executed with this lock held -this patch seperates the underlying action of GetVolume() into a new GetVolumeInternal() function, to be called only when the lock is already held, as is the case for the listener.OnMixerVolumeChanged() call
2014-02-19Mixer: add class MixerListenerMax Kellermann1-7/+8
Use a listener interface instead of GlobalEvents.
2014-02-06mixer/Plugin: pass AudioOutput reference to init()Max Kellermann1-19/+12
Passing a void pointer is unsafe.
2014-02-06MixerPlugin: convert function pointers to Mixer virtual methodsMax Kellermann1-63/+67
2014-02-05Mixer: rename struct mixer_plugin to MixerPluginMax Kellermann1-1/+1
2014-02-05MixerPlugin: add EventLoop& init() parameterMax Kellermann1-1/+2
2014-01-24Mixer*: move to mixer/Max Kellermann1-1/+1
2014-01-23output/*: move to output/plugins/Max Kellermann1-1/+1
2014-01-13copyright year 2014Max Kellermann1-1/+1
2013-11-28include cleanup using iwyuMax Kellermann1-2/+0
2013-10-28*: use nullptr instead of NULLMax Kellermann1-8/+8
2013-10-15Client, ...: remove unnecessary glib.h includeMax Kellermann1-2/+0
2013-10-02Log: new logging library APIMax Kellermann1-7/+7
Prepare to migrate away from GLib. Currently, we're still using GLib as a backend.
2013-09-05conf.h: remove obsolete headerMax Kellermann1-1/+0
Use only ConfigData.hxx in plugin sources to reduce header dependencies.
2013-09-04util/Error: new error passing libraryMax Kellermann1-15/+10
Replaces GLib's GError.
2013-08-04*: use gcc.h macros instead of GLibMax Kellermann1-3/+3
2013-08-04MixerPlugin: pass config_param referenceMax Kellermann1-1/+1
2013-04-16MixerInternal: convert to classMax Kellermann1-7/+7
2013-04-16mixer/Pulse: convert to a classMax Kellermann1-21/+18
2013-04-16output/Pulse: convert to C++Max Kellermann1-4/+4
2013-02-22mixer_plugin: convert to C++Max Kellermann1-1/+1
2013-01-09EventPipe: rename to GlobalEventsMax Kellermann1-3/+3
2013-01-09event_pipe.h: convert to C++Max Kellermann1-1/+1
2013-01-09mixer/{alsa,pulse}: convert to C++Max Kellermann1-11/+13
2011-09-17output/pulse: don't expose internal struct in public headerMax Kellermann1-5/+7
Provide _lock() and _unlock() to wrap all accesses from the mixer plugin.
2011-01-29copyright year 2011Max Kellermann1-1/+1
2009-12-31Update copyright notices.Avuton Olrich1-1/+1
2009-11-12include config.h in all sourcesMax Kellermann1-0/+1
After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
2009-10-23output/pulse: call mixer on state changesMax Kellermann1-127/+40
Don't let the mixer plugin "override" the libpulse callbacks. Instead, add a "mixer" attribute to the pulse_output struct, and call the mixer on all interesting events.
2009-10-22mixer/pulse: don't get volume if stream is not yet readyMax Kellermann1-3/+3
Moved the check from pulse_mixer_open() to pulse_mixer_update().
2009-10-21pulse: code rewrite using the asynchronous libpulse APIMax Kellermann1-209/+126
This is a complete rewrite of the PulseAudio output plugin. It uses the asynchronous API, which gives us more control over everything. Additionally, it connects to the PulseAudio server on startup, and keeps this connection up while MPD runs. During pause, instead of closing the stream, it enables "cork".
2009-10-21mixer_plugin: pass audio_output pointer to mixer_plugin.init()Max Kellermann1-1/+1
This allows the mixer object to access its associated audio output object.
2009-10-20mixer_plugin: use GError for error handlingMax Kellermann1-13/+34
2009-10-20pulse: renamed source filesMax Kellermann1-2/+2
2009-04-25pulse_mixer: use PULSE's mainloop lock instead of GMutexMax Kellermann1-27/+13
Using two different kinds of locks may result in a race condition with a deadlock. The libpulse callbacks need no locks at all, because the mainloop object can be assumed to be already locked.
2009-03-27pulse_mixer: protect the struct with a mutexMax Kellermann1-1/+29
There are numerous race conditions between the libpulse thread (pulse_mixer.c callbacks) and the rest of MPD. Protect the volatile attributes of the pulse_mixer struct with a mutex to fix that.
2009-03-27pulse_mixer: return if mixer is offlineMax Kellermann1-29/+27
Eliminate one indent level. Also remove several debug useless debug messages.
2009-03-27pulse_mixer: removed superfluous G_GNUC_UNUSED attributesMax Kellermann1-4/+4
Those parameters are used after all.
2009-03-27pulse_mixer: use local pa_cvolume variable for set_volume()Max Kellermann1-2/+3
Don't mess with pulse_mixer.volume for setting the volume. This variable should only be used to transfer the current volume from sink_input_vol() to pulse_mixer_get_volume().
2009-03-27pulse_mixer: wait for get_volume() operation to completeMax Kellermann1-1/+34
The pa_context_get_sink_input_info() function is asynchronous, and after it returns, libpulse does not guarantee that the operation has completed yet; in fact, it is not likely. Explicitly wait for the operation to complete. The code for the new pulse_wait_for_operation() function was inspired by mplayer and xine code.
2009-03-27pulse_mixer: adapted code styleMax Kellermann1-27/+52
Use the same code style as the rest of MPD.
2009-03-26pulse_mixer: removed superfluous initializationsMax Kellermann1-7/+2
Don't initialize attributes which are only used in an open mixer. As long as nobody accesses them, their values are uninitialized and undefined.
2009-03-26pulse_mixer: allocate "volume" staticallyMax Kellermann1-10/+6
The pm->volume attribute was allocated in pulse_mixer_init(), but is never freed. This leaks memory. Instead of adding the g_free() call to pulse_mixer_finish(), let's just make "volume" a static attribute of the pulse_mixer struct. That is easier to deal with.
2009-03-26pulse_mixer: removed superfluous NULL checks in close()Max Kellermann1-12/+4
When the MPD core knows that the pulse mixer is open, pm->mainloop and pm->context must be non-NULL.
2009-03-26pulse_mixer: initialize "online" and "index" in open()Max Kellermann1-2/+5
The attributes "online" and "index" were not properly reinitialized after a close/open cycle.
2009-03-26pulse: make configuration strings constMax Kellermann1-6/+6
Nobody needs to modify these strings. We can make them const, and convert config_dup_block_string() to config_get_block_string(). This also fixes memory leaks in the pulse mixer.
2009-03-26pulse: don't check config_param!=NULLMax Kellermann1-6/+3
The conf.h functions deal well with config_param==NULL and will return the specified default value then.
2009-03-26pulse_mixer: free libpulse objects on failureMax Kellermann1-0/+6
When the mixer initialization fails, we have to free the libpulse objects we have already created, to prevent resource leaks.
2009-03-26pulse_mixer: unlock the mainloop on failureMax Kellermann1-0/+2
It's illegal to return from pulse_mixer_setup() without unlocking the main loop. In the error handling, that unlock() call was missing.
2009-03-26pulse_mixer: moved code to pulse_mixer_setup()Max Kellermann1-15/+26
Prepare for adding proper error handling.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 16:18:32 +0000