aboutsummaryrefslogtreecommitdiffstats
path: root/src/log.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-03-15log: removed DEBUG() and FATAL()Max Kellermann1-24/+0
Use GLib the logging functions g_debug(), g_error() instead.
2009-03-13all: Update copyright header.Avuton Olrich1-6/+7
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
2009-02-19added G_LOG_DOMAIN macros to several librariesMax Kellermann1-0/+3
Define the GLib logging domain in the following libraries: conf, daemon, event_pipe, log.
2009-02-19log: added log_early_init() for early debug messagesMax Kellermann1-0/+9
2009-01-25conf: const pointers in block get functionsMax Kellermann1-3/+2
All config_get_block_*() functions should accept constant config_param pointers.
2009-01-17conf: no CamelCase, part IMax Kellermann1-3/+3
Renamed functions, types, variables.
2009-01-15log, pcm_convert: added return statements after g_error()Max Kellermann1-1/+3
gcc doesn't know that g_error() never returns. Work around the gcc warning.
2009-01-03log: don't call closelog() on !HAVE_SYSLOGMax Kellermann1-0/+2
2008-12-29log: removed unused logging wrappersMax Kellermann1-4/+0
Removed GLib logging wrappers which are not used anymore.
2008-12-29log: automatically append newlineMax Kellermann1-4/+19
If a log message does not include a newline character, append it.
2008-12-28Include <pthread.h> where it is necessary onlyThomas Jansen1-1/+0
2008-12-28log: use GLib loggingMax Kellermann1-13/+13
2008-12-28log: don't keep log file openMax Kellermann1-14/+15
The log file is duped to STDOUT_FILENO and STDERR_FILENO. No need to keep another copy of it in out_fd all the time. We only need it once once in setup_log_output().
2008-12-28log: support syslog()Max Kellermann1-6/+103
Allow logging to syslog if log_file is configured to "syslog".
2008-12-28log: moved code to log_init_file()Max Kellermann1-15/+27
Added log_init_file() and log_init_stdout(), preparing for other logging targets.
2008-12-28log: merged initLog() and open_log_files().Max Kellermann1-6/+1
The logging library currently has 3 constructor functions: initLog(), open_log_files(), setup_log_output(), called in this order. Merged the first two.
2008-12-28log: moved code to parse_log_level()Max Kellermann1-15/+17
2008-12-28log: use the GLogLevelFlags typeMax Kellermann1-3/+3
Declare log_threshold as GLogLevelFlags.
2008-12-28log: don't manipulate the umaskMax Kellermann1-9/+1
If the user wants the log files with a specific mode, he has to start MPD with the correct umask. Don't hard-code that. This fixes a bug: when log cycling failed, MPD would not restore the old umask.
2008-12-28log: moved code to open_log_file()Max Kellermann1-12/+19
Merged code from open_log_files() and cycle_log_files().
2008-12-28log: deprecated "error_file" optionMax Kellermann1-26/+2
Removed the "error_file" option. There is only one log file now. If a user wants to see only the errors, he should configure a log_level.
2008-12-20log: map log level "SECURE" to GLib's "INFO"Max Kellermann1-3/+3
Make "secure" a log level different from "default". "secure" should be right between "default" and "verbose". Map "default" to Glib's "MESSAGE" log level.
2008-12-02replaced mpd_printf etc by G_GNUC_PRINTFThomas Jansen1-2/+2
We want to remove gcc.h eventually. This takes care of all the G_GNUC_PRINTF macros.
2008-12-02replaced mpd_noreturn by G_GNUC_NORETURNThomas Jansen1-1/+1
We want to remove gcc.h eventually. This takes care of all the G_GNUC_NORETURN macros.
2008-11-21log: print the log_domainMax Kellermann1-2/+6
2008-11-14log: check the log threshold in log_func()Max Kellermann1-0/+3
The threshold was only checked in the deprecated logging functions (ERROR(), WARNING(), ...). Add the check to the GLib logging handler.
2008-11-09log: properly check log_thresholdDaniel Schömer1-1/+1
2008-11-05log: check if log_charset is setMax Kellermann1-5/+8
When logging to a file, log_charset would be NULL and g_convert() would abort.
2008-11-05log: convert messages to system charsetMax Kellermann1-0/+14
When logging to the terminal, we should print messages in the system character set. Convert all messages in this case.
2008-11-05log: use boolMax Kellermann1-5/+5
Use the bool data type for flags.
2008-11-05log: provide a GLib logging handlerMax Kellermann1-0/+15
Install a default handler which writes to stdout or stderr, and prepends a time stamp. This looks just like the 0.13.x logger.
2008-11-05log: use GLib message loggingMax Kellermann1-20/+15
The logging functions from log.h are deprecated, and the code should use GLib logging instead. Make ERROR(), WARNING() etc. call g_logv() internally.
2008-11-05log: no CamelCaseMax Kellermann1-6/+8
Renamed the variable "logLevel" to "log_threshold".
2008-11-05log: removed warning bufferMax Kellermann1-76/+2
The warning buffer is a complex piece of code for no good reason. Remove it and find a better solution, e.g. open the log file earlier.
2008-10-29log: don't use utils.hMax Kellermann1-5/+17
Prefer GLib over utils.h.
2008-10-08don't include os_compat.hMax Kellermann1-1/+7
When there are standardized headers, use these instead of the bloated os_compat.h.
2008-09-06include cleanupMax Kellermann1-1/+0
As usual, include only headers which are really needed.
2008-08-28log.c: thread-safety for warning logEric Wong1-4/+12
I'm really no fan of the warning log, it's too complex for how little it gets used; but fixing it is another problem.
2008-04-12fix sign compare warningsMax Kellermann1-1/+1
Do explicit casts before comparing signed with unsigned. The one in log.c actually fixes another warning: in the expanded macro, there may be a check "logLevel>=0", which is always true. git-svn-id: https://svn.musicpd.org/mpd/trunk@7230 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26zero is a valid file descriptorMax Kellermann1-4/+4
Although it may not happen in mpd code, it is perfectly possible for a newly allocated file descriptor to be zero. For theoretical correctness, allow 0. git-svn-id: https://svn.musicpd.org/mpd/trunk@7194 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-01-03Cleanup #includes of standard system headers and put them in one placeEric Wong1-6/+1
This will make refactoring features easier, especially now that pthreads support and larger refactorings are on the horizon. Hopefully, this will make porting to other platforms (even non-UNIX-like ones for masochists) easier, too. os_compat.h will house all the #includes for system headers considered to be the "core" of MPD. Headers for optional features will be left to individual source files. git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-09-05Redirect stdin *before* we establish a listen socketEric Wong1-29/+0
This way we'll avoid listening on fd=0 and have a better chance of having fd=0 as /dev/null git-svn-id: https://svn.musicpd.org/mpd/trunk@6852 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-09-04log: oops, fix a syntax errorEric Wong1-1/+1
(yes, it helps to actually compile code before committing it) git-svn-id: https://svn.musicpd.org/mpd/trunk@6851 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-09-04log: better bug avoidance for libraries incorrectly handling fd=0Eric Wong1-2/+16
We redirect stdin to /dev/null to work around a libao bug, but this bug has been fixed in libao since 2003 (according to jat). However, there are likely other bugs in other libraries (and even our code!) that handle fd=0 incorrectly and I'd rather not take the risk[1]. So So it's easiest to just keep fd=0==/dev/null for now... [1] - I've seen several of these myself... git-svn-id: https://svn.musicpd.org/mpd/trunk@6849 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-09-02Fix endless loop when mpd is launched from a non-interactive shell.Eric Wong1-1/+5
Thanks to _noth_ for the patch, this fixes Mantis bug #1534 _noth_ wrote: > When MPD is launched from a non-interactive shell, it enters an endless > loop, filling up its error log file with "error accept()'ing" messages. > This is caused by the fact that stdin is already closed when mpd starts > up. listenOnPort() opens up the first of its sockets as fd 0 (the first > empty fd table position). Then, setup_log_output()->redirect_stdin() > overwrites fd0 (fd=open("/dev/null",...); dup2(fd, STDIN_FILENO);) > without checking if it corresponds to the actual standard input (or if > it is open in the first place). This means that listenSockets[0].fd now > is a fd for /dev/null, thus doIOForInterfaces()->getConnections() can't > accept(2) on it and fails with the above error. The attached patch fixes > this for me. git-svn-id: https://svn.musicpd.org/mpd/trunk@6843 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-08-28log: cleanup: avoid "magic" numbersEric Wong1-6/+8
We used a bare '15' in several places and it's not immediately obvious where it came from. This makes it more obvious git-svn-id: https://svn.musicpd.org/mpd/trunk@6829 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-06-29log: flush the warning log after redirecting stderr to the log filesJ. Alexander Treuman1-0/+1
Previously, the warning log was only flushed if creating the db or logging to stdout. This meant that under normal circumstances (no db creation, logging to files) the warning log was never flushed. This caused a bug when a warning was printed for each call to the status command where the warning buffer would grow endlessly, eventually using more and more CPU to reallocate it. git-svn-id: https://svn.musicpd.org/mpd/trunk@6660 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-04-05The massive copyright updateAvuton Olrich1-1/+1
git-svn-id: https://svn.musicpd.org/mpd/trunk@5834 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-02-19More (v)snprintf-related buffer over-allocations removedEric Wong1-1/+1
Also took out an unnecessary memset in getPlayerErrorStr git-svn-id: https://svn.musicpd.org/mpd/trunk@5396 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2007-02-18Re-adding a fix to log.c that got pulled with the localization reversion.J. Alexander Treuman1-5/+4
git-svn-id: https://svn.musicpd.org/mpd/trunk@5374 09075e82-0dd4-0310-85a5-a0d7c8717e4f
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 22:38:08 +0000