aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-12-26fs/Traits, ...: work around -Wtautological-pointer-compareMax Kellermann1-0/+6
New in clang 3.6.
2014-12-15storage/nfs: add timeoutMax Kellermann2-3/+13
2014-12-15lib/nfs/Connection: unregister socket with SocketMonitor::Steal()Max Kellermann1-1/+1
SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event.
2014-12-15lib/nfs/Connection: implement mount timeoutMax Kellermann2-2/+31
2014-12-15lib/nfs/Connection: add debug flag "in_destroy"Max Kellermann2-0/+11
2014-12-14lib/nfs/Connection: add assertionMax Kellermann1-0/+2
2014-12-14lib/nfs/Connection: fix reconnect after mount failureMax Kellermann1-1/+1
When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
2014-12-14lib/nfs/Connection: fix typo in code commentMax Kellermann1-1/+1
2014-12-14lib/nfs/Connection: fix memory leak (and assertion failure)Max Kellermann3-0/+28
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
2014-12-14lib/nfs/Connection: move code to Service()Max Kellermann2-12/+28
2014-12-14lib/nfs/Connection: add assertionsMax Kellermann1-0/+2
2014-12-14lib/nfs/Connection: move code to method InternalClose()Max Kellermann2-3/+17
2014-12-14lib/nfs/Connection: make in_service and in_event debug-only flagsMax Kellermann2-0/+11
2014-12-14lib/nfs/Connection: fix crash while canceling a failing Open()Max Kellermann1-2/+4
The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist.
2014-12-14lib/nfs/Connection: add assertionsMax Kellermann1-0/+31
2014-11-25lib/nfs/FileReader: clean up on disconnectMax Kellermann1-1/+1
Avoids crash because Close() invokes a call on a destructed NfsConnection.
2014-11-25lib/nfs/FileReader: move code to CancelOrClose()Max Kellermann2-0/+16
2014-11-25lib/nfs/FileReader: reset state in OnNfsConnectionFailed()Max Kellermann1-0/+2
Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already.
2014-11-25lib/nfs/FileReader: update "state" in OnNfsError()Max Kellermann1-0/+24
Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation.
2014-11-25lib/nfs/Manager: defer NfsConnection destructionMax Kellermann2-9/+54
Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning.
2014-11-25lib/nfs/Connection: broadcast error before closing connectionMax Kellermann1-4/+4
During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs.
2014-11-25lib/nfs/Connection: cancel DeferredMonitor on disconnectMax Kellermann1-0/+4
Fixes potential second mount attempt after the old connection to the NFS server was shut down.
2014-11-25lib/nfs/FileReader: include Compiler.h for "final" fallbackMax Kellermann1-0/+1
2014-11-07lib/upnp/ContentDirectoryService: swap uri_apply_base() parametersMax Kellermann1-1/+1
When uri_apply_base() was moved from db/upnp/Util.cpp to util/UriUtil.cpp, the parameter order was changed, however without swapping the parameters in the ContentDirectoryService constructor.
2014-11-02lib/upnp/Discovery: add missing stdlib.h includeMax Kellermann1-0/+1
2014-10-10db/upnp/Util: move caturl() to util/UriUtil.cxxMax Kellermann3-32/+2
2014-10-09storage/nfs: use the libnfs async APIMax Kellermann2-0/+169
Share the NFS connection with the NFS input plugin.
2014-10-09lib/nfs/Connection: reduce Error instance allocationsMax Kellermann1-3/+2
2014-10-09lib/nfs/Glue: add assertionMax Kellermann1-0/+1
2014-10-07lib/nfs/Connection: add methods {Open,Read,Close}Directory()Max Kellermann2-0/+53
2014-10-07lib/nfs/Connection: add method Stat(path)Max Kellermann2-0/+33
2014-10-06lib/nfs/Connection: make GetEventLoop() publicMax Kellermann1-4/+4
2014-10-05lib/nfs/Base: kludge to reduce number of NFS mountsMax Kellermann3-7/+124
Creating a NfsStorage sets its own export_name as the "base". Now NfsFileReader can use this information to derive the export_name to be mounted, instead of guessing. This solves the "too many connection" problem on the NFS server while updating the database.
2014-10-01lib/nfs/FileReader: postpone the nfs_close_async() callMax Kellermann4-6/+92
If an async opertion is in progress, nfs_close_async() will make libnfs crash because the RPC callback will dereference an object that was freed by nfs_close_async().
2014-10-01lib/nfs/Connection: fix memory leak when cancelling Open()Max Kellermann2-5/+23
Close the newly allocated file handle passed to the callback.
2014-10-01lib/nfs/Connection: remove MutexMax Kellermann2-18/+12
All locks are currenly held from only a single thread (the IOThread) and thus we don't need the Mutex.
2014-10-01lib/nfs/Connection: add method GetEventLoop()Max Kellermann2-1/+5
2014-10-01lib/nfs/Connection: remove obsolete flag postponed_destroyMax Kellermann2-18/+2
2014-10-01lib/nfs/Connection: remove deprecated move constructor workaroundMax Kellermann1-16/+0
Not used anymore because NfsManager now uses boost::intrusive::set instead of std::map.
2014-10-01lib/nfs/Manager: use boost::intrusive::mapMax Kellermann2-37/+78
Reduce overhead for storing the key twice, and more overhead while looking up the connection to remove it after a failure.
2014-10-01lib/nfs/Glue: add assertionMax Kellermann1-0/+4
2014-10-01lib/nfs/Glue: destruct the NfsManager in the I/O threadMax Kellermann3-5/+8
This allows eliminating the indirection code from the NfsConnection destructor.
2014-10-01lib/nfs/Glue: eliminate class NfsGlueMax Kellermann1-17/+1
It's just a useless wrapper for class NfsManager.
2014-10-01lib/nfs/Cancellable: use boost::intrusive::listMax Kellermann3-40/+18
Reduce Remove() overhead because we don't have to walk the list to find an iterator by reference.
2014-08-31nfs/Connection: check for disappearing libnfs socketMax Kellermann1-0/+18
2014-08-31nfs/Connection: use only BroadcastError()Max Kellermann1-4/+1
Since BroadcastError() calls BroadcastMountError(), there's no need to check mount_finished here.
2014-08-31nfs/Connection: nfs_get_fd() can return -1Max Kellermann1-0/+3
While reconnecting to the NFS server, the socket is -1, because there is no socket. Fixes a potential crash (assertion failure).
2014-08-31nfs/Connection: use nfs_get_error() for mount errorMax Kellermann1-2/+3
2014-08-31nfs/Connection: fix assertion failureMax Kellermann1-1/+3
2014-08-30*: add missing Compiler.h includesMax Kellermann2-0/+2
Necessary for "final" on gcc 4.6.