aboutsummaryrefslogtreecommitdiffstats
path: root/src/directory_save.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-11-01song_save: load one song at a timeMax Kellermann1-5/+15
Changed songvec_load() to song_load(). Added start and end markers for each song. Removed the "key" line, it's redundant.
2009-11-01directory_save: partially revert the g_str_has_prefix() patchMax Kellermann1-2/+2
2009-11-01database: use strcmp() instead of g_str_has_prefix()Max Kellermann1-3/+3
2009-11-01text_file: allocate line buffers dynamicallyMax Kellermann1-22/+23
Use a single GString buffer object in all functions loading the database. Enlarge it automatically for long lines. This eliminates the maximum line length for tag values. There is still an upper limit of 512 kB to prevent denial of service, but that's reasonable I guess.
2009-11-01directory_save: allocate directory object earlier, assign mtimeMax Kellermann1-12/+13
Allocate the directory object after the "directory:" line. Assign the mtime from the input file to this new object, instead of to the parent directory.
2009-11-01directory_save: free directory on errorMax Kellermann1-1/+3
Fix a minor memory leak in the error handler.
2009-11-01directory_save: abort on duplicate subdirectoryMax Kellermann1-7/+9
The old code tried to recover, but what's the point of that? If a directory is duplicate, something is wrong with the database file.
2009-11-01directory_save: moved code to directory_load_subdir()Max Kellermann1-49/+63
2009-07-05song_save: use GError for error handlingMax Kellermann1-1/+4
2009-07-05song_save: no CamelCaseMax Kellermann1-1/+1
Renamed functions.
2009-03-13all: Update copyright header.Avuton Olrich1-6/+7
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
2009-03-02directory: directory_load() returns GErrorMax Kellermann1-16/+43
Do error reporting with GLib's GError library in this library, too.
2009-02-28directory: added "mtime" propertyMax Kellermann1-2/+9
Remember the modification time of each directory. This is important for archives (which are virtual directories right now), but may also be useful for an automatic update mechanism.
2009-02-27directory: moved DIRECTORY_* string constantsMax Kellermann1-0/+4
Moved some of them to to directory_save.c, and others to database.c.
2009-01-04directory: added directory_is_root()Max Kellermann1-2/+2
directory_is_root() is cheaper than isRootDirectory(directory_get_path()).
2009-01-03don't include utils.h when it isn't usedMax Kellermann1-1/+0
2008-12-29removed os_compat.hMax Kellermann1-0/+3
Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
2008-12-28utils: removed myFgets()Max Kellermann1-4/+6
Replaced myFgets() with fgets() + g_strchomp().
2008-10-28utils: use g_str_has_prefix() instead of prefixcmp()Max Kellermann1-6/+6
Remove duplicated code from MPD.
2008-10-20path: replaced mpd_basename() with g_path_get_basename()Max Kellermann1-1/+4
GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
2008-10-09directory: don't query database during loadMax Kellermann1-2/+2
Don't use db_get_directory() and traverse the full path with every directory being loaded. Just see if the current parent contains the entry. Everything else would be invalid anyway..
2008-10-09directory: check the absolute path of a subdirectory while loadingMax Kellermann1-0/+4
A manipulated database could trigger an assertion failure, because the parent didn't match. Do a proper check if the new directory is within the parent's. This uses FATAL() to bail out, so MPD still dies, but it doesn't crash.
2008-10-09directory: moved dirvec struct declaration to dirvec.hMax Kellermann1-1/+0
No idea why it was created in directory.h, but it should be in dirvec.h.
2008-10-09diretory: moved code to directory_save.c, directory_print.cMax Kellermann1-137/+1
Remove clutter from directory.c. Everything which saves or loads to/from the hard disk goes to directory_save.c, and code which sends directory information to the client is moved into directory_print.c.
2008-10-08directory: path must not be NULLMax Kellermann1-7/+7
For the root directory, let's set path to an empty string. This saves a few checks.
2008-10-08directory: eliminate CamelCaseMax Kellermann1-23/+23
CamelCase is ugly, rename the functions.
2008-10-08database: renamed functions, "db_" prefix and no CamelCaseMax Kellermann1-1/+1
Yet another CamelCase removal patch.
2008-10-08directory: moved code to database.cMax Kellermann1-308/+10
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
2008-10-08directory: converted isRootDirectory() to an inline functionMax Kellermann1-5/+5
The function isRootDirectory() is tiny and can be converted to an inline function. Don't allow name==NULL.
2008-10-08song: removed CamelCaseMax Kellermann1-1/+1
CamelCase is ugly... rename all functions.
2008-10-08song: converted typedef Song to struct songMax Kellermann1-6/+7
Again, a data type which can be forward-declared.
2008-10-08directory: converted typedef Directory to struct directoryMax Kellermann1-28/+33
The struct can be forward-declared by other headers, which relaxes the header dependencies.
2008-10-08update: merged exploreDirectory() into updateDirectory()Max Kellermann1-1/+1
exploreDirectory() duplicates some code in updateDirectory(). Merge both functions, and use directory_is_empty() to determine whether update or explore mode should be used.
2008-10-08directory: added directory_is_empty()Max Kellermann1-1/+1
directory_is_empty() is a tiny inline function which determine if a directory has any child objects (sub directories or songs).
2008-10-08directory: moved code to update.cMax Kellermann1-575/+17
The source directory.c mixes several libraries: directory object management, database management and database update, resulting in a 1000+ line monster. Move the whole database update code to update.c.
2008-10-07directory: fix return value in removeDeletedFromDirectoryEric Wong1-1/+1
oops :x
2008-10-07directory: serialize song deletes from playlist during updateEric Wong1-3/+28
This makes the update code thread-safe and doesn't penalize the playlist code by complicating it with complicated and error-prone locks (and the associated overhead, not everybody has a thread-implementation as good as NPTL). The update task blocks during the delete; but the update task is a slow task anyways so we can block w/o people caring too much. This was also our only freeSong call site, so remove that function. Note that deleting entire directories is not fully thread-safe, yet; as their traversals are not yet locked.
2008-10-07directory: use songvec_for_each for iteratorsEric Wong1-28/+30
Get rid of songvec_write so we can enforce proper locking
2008-10-07dbUtils/directory: traverseAllIn forEachSong returns -1 on errorEric Wong1-12/+9
Being consistent with most UNIX functions...
2008-10-07Assert if we don't have song or song->url setEric Wong1-2/+2
song objects cannot exist without a path or URL
2008-10-06song: stop storing song_typeEric Wong1-1/+1
We already know if a song is a URL or not based on whether it has parentDir defined or not. Hopefully one day in the future we can drop HTTP support from MPD entirely when an HTTP filesystem comes along and we can access streams via open(2).
2008-10-06song: use flex arrays to store song->urlEric Wong1-1/+1
Reduce the number of allocations we make, so there's less pressure on the allocator and less overhead to keep track of the allocations in.
2008-10-06directory: reuse existing directory if found on updateEric Wong1-4/+9
Instead of allocating a new one, just reuse an existing one if one is found when rereading the DB. This is a small makes the previous commit work on subdirectories of the root music directory. [1] "song: better handling of existing songs when rereading DB"
2008-10-06directory: simplify list update handling logicEric Wong1-45/+60
Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
2008-10-06directory: streamline deletesEric Wong1-17/+15
Instead of relying on the shortname, just pass the song pointer to prevent redundant lookups during deletes.
2008-09-29directory: isRootDirectory() is a one-linerEric Wong1-4/+1
Improving the signal to noise ratio...
2008-09-29directory: writeDirectoryInfo propagates errorsEric Wong1-21/+19
If a write failed, it's a good sign subsequent writes will fail, too, so propgate errors all the way up the stack.
2008-09-29directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong1-1/+1
A long time ago in an mpd far away...
2008-09-29directory: remove "Mp3" referencesEric Wong1-17/+17
MPD has supported more audio formats than just MP3 for over five years...
2008-09-29directory: remove shortname arguments everywhereEric Wong1-80/+41
It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.