| Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
g_basename() is deprecated in GLib 2.32.
|
|
Directories are loaded in reverse order when MPD starts. Only fixed
when doing a rescan.
|
|
|
|
Reduce the number of lock/unlock cycles, and make database handling
safer.
|
|
This was the cause of the reversed ordering when loading a database
file.
|
|
This commit fixes a major regression in directory_lookup_directory(),
which broke the deep lookup of directories.
|
|
|
|
|
|
Wrap songvec_find() and other songvec methods.
|
|
Random access is not needed, and a linked list is easier to manage: we
don't need to (re-)allocate the pointer array.
|
|
Pass only the "name" to a directory, instead of the full (relative)
path.
|
|
The protocol mandates that playlist URIs are absolute (i.e. full URI
relative to the music directory, not relative to the parent
directory). This adds the parameter "directory" to the "playlist"
visitor method.
|
|
|
|
|
|
Let the caller decide if the current directory should be visited.
|
|
.. to recurse. A visitor may not have one, but still be interested in
a recursive search.
|
|
Use this struct for db_walk().
|
|
|
|
|
|
Don't open the music directory for each "lsinfo" call. Get the list
of playlist files from the memory database.
|
|
|
|
After we've been hit by Large File Support problems several times in
the past week (which only occur on 32 bit platforms, which I don't
have), this is yet another attempt to fix the issue.
|
|
dirvec_delete() does not free the object, we have to call
directory_free() afterwards.
|
|
Moved code from db_get_song().
|
|
Renamed directory_get_directory() to directory_lookup_directory().
Added API documentation.
|
|
This updates the copyright header to all be the same, which is
pretty much an update of where to mail request for a copy of the GPL
and the years of the MPD project. This also puts all committers under
'The Music Player Project' umbrella. These entries should go
individually in the AUTHORS file, for consistancy.
|
|
On some platforms, g_free() must be used for memory allocated by
GLib. This patch intends to correct a lot of occurrences, but is
probably not complete.
|
|
|
|
directory_free() should free all of its children (subdirectories and
songs). This way, db_finish() properly frees all allocated memory.
|
|
GLib's g_path_get_basename() is much more reliable than
mpd_basename(). The latter could be tricked into an assertion
failure.
|
|
directory_get_name() returns the base name of the directory.
|
|
This way we avoid unnecessary heap allocations.
|
|
Some tiny utilities... wrappers like these may become helpful when we
introduce locking.
|
|
No idea why it was created in directory.h, but it should be in
dirvec.h.
|
|
Remove clutter from directory.c. Everything which saves or loads
to/from the hard disk goes to directory_save.c, and code which sends
directory information to the client is moved into directory_print.c.
|
|
For the root directory, let's set path to an empty string. This saves
a few checks.
|
|
CamelCase is ugly, rename the functions.
|
|
Yet another CamelCase removal patch.
|
|
Taming the directory.c monster, part II: move the database management
stuff to database. directory.c should only contain code which works
on directory objects.
|
|
The function isRootDirectory() is tiny and can be converted to an
inline function. Don't allow name==NULL.
|
|
CamelCase is ugly... rename all functions.
|
|
Again, a data type which can be forward-declared.
|
|
The struct can be forward-declared by other headers, which relaxes the
header dependencies.
|
|
exploreDirectory() duplicates some code in updateDirectory(). Merge
both functions, and use directory_is_empty() to determine whether
update or explore mode should be used.
|
|
directory_is_empty() is a tiny inline function which determine if a
directory has any child objects (sub directories or songs).
|
|
The source directory.c mixes several libraries: directory object
management, database management and database update, resulting in a
1000+ line monster. Move the whole database update code to update.c.
|
|
oops :x
|
|
This makes the update code thread-safe and doesn't penalize
the playlist code by complicating it with complicated and
error-prone locks (and the associated overhead, not everybody
has a thread-implementation as good as NPTL).
The update task blocks during the delete; but the update task is
a slow task anyways so we can block w/o people caring too much.
This was also our only freeSong call site, so remove that
function.
Note that deleting entire directories is not fully thread-safe,
yet; as their traversals are not yet locked.
|
