aboutsummaryrefslogtreecommitdiffstats
path: root/src/decoder_thread.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-05-29decoder_api: log the decoder plugin nameMax Kellermann1-0/+4
2011-10-13decoder_thread: add missing stdio.h includeMax Kellermann1-0/+1
2011-10-09decoder/{pcm,dsdiff}: add missing stdio.h includeMax Kellermann1-0/+1
2011-10-05decoder_control: add attributes start_ms, end_msMax Kellermann1-1/+1
Don't read song.start_ms and song.end_ms, let the player thread manage this logic instead.
2011-09-22decoder_api: emulate SEEK command for initial seek to CUE trackMax Kellermann1-0/+2
When playing a CUE track, the player thread waited for the decoder to become ready, and then sent a SEEK command to the beginning of the CUE track. If that is near the start of the song file, and the track is short enough, the decoder could have finished decoding already at that point, and seeking fails. This commit makes this initial seek more robust: instead of letting the player thread deal with the difficult timings, let the decoder API emulate a SEEK command, and return it to the decoder plugin, as soon as the plugin finishes its initialization.
2011-09-16input_stream: non-blocking I/OMax Kellermann1-24/+20
Add GMutex, GCond attributes which will be used by callers to conditionally wait on the stream. Remove the (now-useless) plugin method buffer(), wait on GCond instead. Lock the input_stream before each method call. Do the same with the playlist plugins.
2011-01-29copyright year 2011Max Kellermann1-1/+1
2011-01-16decoder_thread: fix assertion failure at song endMax Kellermann1-2/+1
Don't finish the current command twice. This bug was never noticed, but was revealed by a new assertion check.
2011-01-10decoder_control: store GCond object, not a player_controlMax Kellermann1-2/+1
Remove the decoder dependency on player_control. All player_control was needed for is to signal the player thread, and we can do that with a simple GCond as well.
2011-01-10decoder_thread: move code to decoder_command_finished_locked()Max Kellermann1-8/+19
2011-01-10player_control: removed the global variable "pc"Max Kellermann1-3/+3
Allocate a player_control object where needed, and pass it around. Each "client" object is associated with a "player_control" instance. This prepares multi-player support.
2010-11-18decoder_thread: load APE replay gain from music filesMax Kellermann1-0/+15
2010-09-25eliminate g_error() usageThomas Jansen1-1/+2
Replaced all occurrences of g_error() with MPD_ERROR() located in a new header file 'mpd_error.h'. This macro uses g_critical() to print the error message and then exits gracefully in contrast to g_error() which would internally call abort() to produce a core dump. The macro name is distinctive and allows to find all places with dubious error handling. The long-term goal is to get rid of MPD_ERROR() altogether. To facilitate the eventual removal of this macro it was added in a new header file rather than to an existing header file. This fixes #2995 and #3007.
2010-05-08mixramp: Adjust MixRamp threshold to account for ReplayGain.Tim Phipps1-0/+2
2010-03-21Add support for MixRamp tagsTim Phipps1-0/+11
Adds mixrampdb and mixrampdelay commands. Reads MIXRAP_START and MIXRAMP_END tags from FLAC files and overlaps instead of crossfading.
2010-02-17replay_gain: reimplement as a filter pluginMax Kellermann1-6/+0
Apply the replay gain in the output thread. This means a new setting will be active instantly, without going through the whole music pipe. And we might have different replay gain settings for each audio output device.
2010-01-17decoder_thread: don't fall back to "mad" unless no plugin matchesMax Kellermann1-1/+2
When all plugins have failed, MPD used to fall back to the "mad" decoder plugin, to handle those radio streams without a Content-Type response header. This however leads to unexpected results (garbage being played) when the stream isn't really mp3. Since we care little about "bad" streams, we shouldn't have hacks which have bad side effects. Let's get rid of this hack now! Only try to "mad" plugin if there was no match at all (Content-Type, path suffix) and no other plugin has been tried.
2010-01-17decoder_thread: don't try a plugin twice (MIME type & suffix)Max Kellermann1-10/+56
Manage a linked list of plugins which were already tried.
2010-01-16decoder_thread: fix CUE track playbackMax Kellermann1-5/+10
The patch "input/file: don't fall back to parent directory" introduced a regression: when trying to play a CUE track, decoder_run_song() tries to open the file as a stream first, but this fails, because the path is virtual. This patch fixes decoder_run_song() (instead of reverting the previous patch) to accept input_stream_open() failures if the song is a local file. It passes the responsibility to handle non-existing files to the decoder's file_decode() method.
2010-01-04replay_gain: moved code to replay_gain_config.cMax Kellermann1-1/+1
2010-01-04replay_gain: moved code to replay_gain_info.cMax Kellermann1-0/+1
2010-01-04replay_gain: refactor API, move code to replay_gain_state.cMax Kellermann1-3/+4
The replay_gain_state struct holds the precalculated scale factor, which is removed from struct replay_gain_info.
2010-01-04decoder_api: added function decoder_replay_gain()Max Kellermann1-0/+5
This function replaces the replay_gain_info parameter for decoder_data(). This allows the decoder to announce replay gain changes, instead of having to pass the same object over and over.
2010-01-01input_stream: return allocated input_stream objectsMax Kellermann1-20/+22
Major API redesign: don't let the caller allocate the input_stream object. Let each input plugin allocate its own (derived/extended) input_stream pointer. The "data" attribute can now be removed, and all input plugins simply cast the input_stream pointer to their own structure (with an "struct input_stream base" as the first attribute).
2009-12-31Update copyright notices.Avuton Olrich1-1/+1
2009-12-26decoder_api: added function decoder_timestamp()Max Kellermann1-0/+1
Remove the data_time parameter from decoder_data(). This patch eliminates the timestamp counting in most decoder plugins, because the MPD core will do it automatically by default.
2009-12-15input_stream: return errors with GErrorMax Kellermann1-3/+13
2009-11-12include config.h in all sourcesMax Kellermann1-0/+1
After we've been hit by Large File Support problems several times in the past week (which only occur on 32 bit platforms, which I don't have), this is yet another attempt to fix the issue.
2009-11-07decoder_thread: close input fileMax Kellermann1-3/+10
An input_stream_close() call was missing after today's code reorganization.
2009-11-07decoder_thread: check for STOP before calling the pluginMax Kellermann1-0/+6
Before calling the plugin's decode method, we should ensure that we didn't receive a STOP command during initialization.
2009-11-07decoder_thread: moved code to decoder_input_stream_open()Max Kellermann1-27/+50
This function opens the stream and waits for it to become ready; meanwhile it checks for STOP commands. It is code moved from decoder_run_stream().
2009-11-07decoder_thread: added local variable "dc" in decoder_run_file()Max Kellermann1-6/+7
Simplify the expressions.
2009-11-07decoder_list: pass previous plugin pointer to lookup functionsMax Kellermann1-6/+4
Remove the static integer hack, that's not thread safe and sucks.
2009-11-07decoder_thread: open input stream on demandMax Kellermann1-72/+59
Moved the global input stream opener to decoder_run_stream(). decoder_run_file() now opens the input stream each time a plugin provides a stream decoder method.
2009-11-07decoder_thread: moved plugin loops to separate functionsMax Kellermann1-82/+127
Tame the large decoder_run_song() function.
2009-11-04decoder_thread: initialize decoder_control.quitMax Kellermann1-0/+2
If left uninitialized, then the decoder thread quits spuriously.
2009-11-03decoder_control: merge next_song and current_songMax Kellermann1-2/+3
These two variables are redundant, we need only one of them.
2009-11-03decoder_thread: unlock the decoder while checking the streamMax Kellermann1-4/+4
This is only a slight change to the previous locking behaviour: keep the decoder unlocked during the loop, and lock it only while checking decoder_control.command.
2009-11-03decoder_thread: open input stream after command finishedMax Kellermann1-5/+10
Return the result to the caller more quickly. This unifies error handling: no error can be reported before the command is finished.
2009-11-03decoder_control: make the song objects constMax Kellermann1-1/+1
They are just informational.
2009-10-31decoder_control: removed the global variable "dc"Max Kellermann1-58/+67
Allocate a decoder_control object where needed, and pass it around. This will allow more than one decoder thread one day.
2009-10-31player_control: protect command, state, error with a mutexMax Kellermann1-9/+3
Use GMutex/GCond instead of the notify library. Manually lock the player_control object before accessing the protected attributes. Use the GCond object to notify the player thread and the main thread.
2009-10-20mapper, update, ...: use g_build_filename(), G_DIR_SEPARATOR, ...Max Kellermann1-1/+1
Try to be as portable as possible, use GLib path name functions and macros.
2009-10-11decoder_thread: removed redundant NULL assignmentsMax Kellermann1-2/+1
The while() clause resets the "plugin" variable. We don't need to reset it at the end of the loop body.
2009-10-11decoder_thread: change the fallback decoder name to "mad"Max Kellermann1-1/+1
When there is no Content-Type response header, try the "mad" decoder plugin. It uesd to be named "mp3", and we forgot to change the fallback name in decoder_thread.c.
2009-08-13decoder_control: protect command, state with a mutexMax Kellermann1-2/+45
Replace decoder_control.notify with decoder_control.mutex and decoder_control.cond. Lock the mutex on all accesses to decoder_control.command and decoder_control.state.
2009-06-19decoder_thread: reopen the stream after file_decode() has failedMax Kellermann1-0/+11
When decoding a local file, the decoder thread tries to run all matching decoders, until one succeeds. Both file_decode() and stream_decode() can decode a stream, but MPD closes the stream before calling file_decode(). Problem is: when this decoder fails, and the next's stream_decode() method is invoked, the input_stream is still closed. This patch reopens it.
2009-04-13decoder_api: submit the song tag to the music pipeMax Kellermann1-0/+5
When a new song starts playing, send its tag (song->tag) to the music pipe. This allows output plugins to render tags for all songs, not only those with embedded tags understood by the decoder plugin.
2009-03-15log: removed DEBUG() and FATAL()Max Kellermann1-2/+1
Use GLib the logging functions g_debug(), g_error() instead.
2009-03-13all: Update copyright header.Avuton Olrich1-7/+7
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.