| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Use boolean true/false instead of 1/0.
|
|
|
|
| |
Renamed functions and variables.
|
|
|
|
| |
Fixed the indent of the switch statement in format_samples_int().
|
|
|
|
|
| |
Eliminate a superfluous decoder_get_command() call. decoder_data()
already returns the command.
|
|
|
|
| |
Removed the duplicate audio_format initialization.
|
|
|
|
|
| |
decoder_read() handles decoder commands, and should be used in decoder
plugins.
|
|
|
|
|
|
| |
We need the decoder object, so we have to begin passing a new struct
to these callbacks, instead of only the pointer to the input_stream
object.
|
|
|
|
| |
Replace deprecated code with GLib.
|
|
|
|
|
|
|
|
| |
The API of mp4_load_tag() was strange: it always returned a tag
object, no matter if a tag was found in the file; the existence of a
tag was indicated with the tag_found integer reference. This flag is
superfluous, since we can simply check whether the tag is empty or
not.
|
|
|
|
|
|
| |
Allocate the mp4ff_callback_t object on the stack. This is easier to
handle, since we don't have to free it. Incidentally, this fixes a
memory leak in mp4_load_tag().
|
|
|
|
| |
Renamed functions and variables.
|
|
|
|
|
|
| |
The function decoder_read() already cares about the decoder command,
and loops until data is available. Reduced mpd_ffmpeg_read() to no
more than the decoder_read() call.
|
|
|
|
|
| |
That variable is never used except during initialization in
ffmpeg_helper().
|
| |
|
|
|
|
| |
Renamed variables.
|
|
|
|
|
|
|
|
|
|
| |
If an input stream provides tags (e.g. from an icecast server), send
them in the decoder_data() and decoder_tag() methods. Removed the
according code from the mp3 and oggvorbis plugins - decoders shouldn't
have to care about stream tags.
This patch also adds the missing decoder_tag() invocation to the mp3
plugin.
|
|
|
|
|
| |
The variables mod_mikModInitiated and mod_mikModInitError were used to
control lazy initialization, but they are superfluous now.
|
|
|
|
|
|
|
| |
The "mod" decoder plugin was being initialized lazily, but was
deinitialized unconditionally. That led to segmentation faults.
Convert mod_initMikMod() to be the global module initialization
method. The MPD core should care about lazy initialization.
|
|
|
|
|
|
| |
ffmpeg_tag() deleted the tag when ffmpeg_helper() returned success.
The return value was interpreted incorrectly, it should return the tag
on success.
|
|
|
|
|
| |
Rewinding the stream here is not useful, but may consume valuable
resources (and time).
|
|
|
|
|
|
|
|
|
| |
The try_decode() method may have read some data from the stream, which
is now lost. To make this data available to other methods, get it
back by rewinding the input stream after each try_decode() invocation.
The ogg and wavpack plugins did this manually and inconsistently; this
code can now be removed.
|
|
|
|
|
| |
decoder_read() checks the decoder command. Without this patch, the
ffmpeg plugin could become unresponsive.
|
|
|
|
|
|
|
| |
Ogg and ffmpeg detection was disabled when the stream was not
seekable, because the detection was too expensive. Since the curl
input stream can now rewind the stream cheaply, we can re-enable
detection on streams.
|
|
|
|
| |
Provide an API for submitting additional tags from the stream.
|
|
|
|
|
| |
Avoid while(true) loops, and convert them to a loop with a proper
condition.
|
|
|
|
|
|
| |
Since the aac and mod plugins have told MPD that they cannot seek, MPD
will never send a SEEK command to them. Removed the SEEK comand
checks from both plugins.
|
|
|
|
|
|
| |
Don't pass the "seekable" flag with every decoder_data() invocation.
Since that flag won't change within the file, it is enough to pass it
to decoder_initialized() once per file.
|
|
|
|
|
| |
The strings were constant, but the pointers weren't. C syntax is
somewhat tricky..
|
|
|
|
|
| |
All decoder_plugin structs are initialized at compile time, and must
never change.
|
| |
|
|
|
|
|
|
|
| |
"LOG_H" is a macro which is also used by ffmpeg/log.h. This is
ffmpeg's fault, because short macros should be reserved for
applications, but since it's always a good idea to choose prefixed
macro names, even for applications, we are going to do that in MPD.
|
|
|
|
|
|
| |
The source _ogg_common.c does not need any symbols from
_flac_common.h, but including it leads to compiler errors when libflac
isn't available.
|
|
|
|
|
| |
Again, I forgot to adapt oggflac to the new API (struct input_stream,
bool return values).
|
|
|
|
|
| |
decoder_data() uses wait times to let the input stream continue its
transfer.
|
|
|
|
|
| |
decoder_data() always returns the current command. If we use this, we
can save a lot of decoder_get_command() calls.
|
|
|
|
| |
Converted the runtime check to an assertion.
|
|
|
|
| |
Remove one indent level.
|
|
|
|
|
| |
Move code from ffmpeg_decode_internal() to make it smaller and more
readable.
|
|
|
|
|
| |
The decoder API provides the function decoder_seek_error() to report
seek errors. Use this function instead of logging the error.
|
|
|
|
|
| |
The function mpdurl_read() is too complicated, and uses the wrong data
types.
|
|
|
|
|
| |
tag objects must be freed with tag_free() to ensure that all resources
are freed.
|
|
|
|
|
| |
The function ffmpeg_tag() already has the variable base.tag, which can
be used for this.
|
|
|
|
|
| |
ffmpeg_try_decode() did not interpret ffmpeg_helper()'s return value
properly; migrate everything to bool to make it consistent.
|
|
|
|
| |
We don't need those anymore, they just fill the log.
|
|
|
|
|
| |
ffmpeg_tag() did not initialize base.decoder, which made valgrind
unhappy, and can lead to a egmentation fault.
|
|
|
|
|
|
| |
Similar to libmad, libmpcdec provides samples with higher quality than
16 bit. Send 24 bit samples to MPD, which allows MPD to apply
dithering just in case the output devices are only 16 bit capable.
|
|
|
|
| |
Don't hard-code the "16 bits" or "2 bytes" in multiple locations.
|
|
|
|
|
| |
The name "s16" implies 16 bit integers. To make the code more
generic, rename it to "dest".
|
|
|
|
|
|
| |
The conversion of integer samples was completely broken, which
presumably didn't annoy anybody because libmpcdec provides float
samples on most installations.
|
|
|
|
|
| |
When input_stream_seek() was converted to return a bool, this wasn't
adjusted in the musepack plugin.
|