| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
|
| |
libwavpack expects the read_bytes() stream method to fill the whole
buffer, and fails badly when we return a partial read (i.e. not enough
data available yet). This caused wavpack streams to break.
Re-implement the buffer filling loop.
|
| |
|
|
| |
The input_stream object is opened and closed by the caller.
|
| |
|
|
|
| |
Instead of checking the stream_types bit set, we can simply check
whether the methods stream_decode() and file_decode() are implemented.
|
| |
|
|
|
| |
The number of tag types is known at compile time. Use the GLib macro
G_N_ELEMENTS instead of having a NULL element at the end.
|
| |
|
|
| |
Don't store tag type values in a plain integer, use the proper enum.
|
| |
|
|
| |
Replace deprecated code with GLib.
|
| |
|
|
|
|
|
|
|
| |
Instead of manually waiting for the input stream to become ready (to
catch server errors), just read the first byte. Since the
wavpack_input has the capability to push back one byte, we can simply
re-feed it. Advantage is: decoder_read() handles everything for us,
i.e. waiting for the stream, polling for decoder commands and error
handling.
|
| |
|
|
| |
Use boolean true/false instead of 1/0.
|
| |
|
|
| |
Renamed functions and variables.
|
| |
|
|
| |
Fixed the indent of the switch statement in format_samples_int().
|
| |
|
|
|
|
|
|
|
| |
The try_decode() method may have read some data from the stream, which
is now lost. To make this data available to other methods, get it
back by rewinding the input stream after each try_decode() invocation.
The ogg and wavpack plugins did this manually and inconsistently; this
code can now be removed.
|
| |
|
|
|
|
| |
Don't pass the "seekable" flag with every decoder_data() invocation.
Since that flag won't change within the file, it is enough to pass it
to decoder_initialized() once per file.
|
| |
|
|
|
| |
The strings were constant, but the pointers weren't. C syntax is
somewhat tricky..
|
| |
|
|
|
| |
All decoder_plugin structs are initialized at compile time, and must
never change.
|
| | |
|
| |
|
|
|
| |
Don't return 0/-1 on success/error, but true/false. Instead of int,
use bool for storing flags.
|
| |
|
|
|
|
|
| |
A decoder_flush() invocation was missing in the FLAC plugin, resulting
in casual assertion failures due to a wrong assumption about the last
chunk's audio format. It's much easier to remove that decoder_flush()
function and make the decoder thread call ob_flush().
|
| |
|
|
|
| |
Call ob_clear() in decoder_command_finished() instead of implementing
that call in every decoder plugin.
|
| |
|
|
|
| |
For boolean values and success flags, use bool instead of integer (1/0
for true/false, 0/-1 for success/failure).
|
| |
|
|
| |
Renamed all functions and variables.
|
| |
|
|
| |
Everybody should use struct input_stream.
|
|
|
These plugins are not input plugins, they are decoder plugins. No
CamelCase in the directory name.
|
