aboutsummaryrefslogtreecommitdiffstats
path: root/src/decoder/FaadDecoderPlugin.cxx (follow)
Commit message (Collapse)AuthorAgeFilesLines
* decoder/faad: remove workaround for ancient libfaad2 ABI bugMax Kellermann2014-11-021-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
* decoder/faad: estimate song duration for remote filesMax Kellermann2014-07-121-0/+22
| | | | | | | | Previously, MPD tried to slurp the whole song file, count the number of frames and calculate the song duration from that. That however is extremely expensive for remote files, and will delay playback for a long time. Workaround: check only the first 128 frames and try to extrapolate from here. Fixes Mantis ticket 0004035.
* decoder/faad: bail out early if sample rate is invalidMax Kellermann2014-07-121-0/+2
|
* decoder/faad: use adts_check_frame() in faad_song_duration()Max Kellermann2014-07-121-2/+1
| | | | Eliminate more duplicate code.
* decoder/faad: test "seekable" after ADTS frame checkMax Kellermann2014-07-121-1/+5
| | | | | Don't bother to check for ADIF just because the stream is not seekable.
* decoder/faad: move code to faad_decoder_new()Max Kellermann2014-07-121-14/+17
| | | | Merge some duplicate code.
* decoder/faad: remove unnecessary readMax Kellermann2014-07-121-2/+0
| | | | Eliminate some overhead when the caller doesn't need the buffer.
* DecoderBuffer: add method _clear()Max Kellermann2014-07-121-8/+3
|
* decoder/faad: check sample_rate, not frames_per_secondMax Kellermann2014-07-111-2/+4
| | | | Checking the integer is faster, easier and more reliable.
* decoder/faad: make variables more localMax Kellermann2014-07-111-71/+49
|
* decoder/faad: use MAX_CHANNELSMax Kellermann2014-07-111-4/+2
| | | | .. instead of declaring a new constant.
* decoder/faad: fix memory leakMax Kellermann2014-01-081-0/+2
|
* Log: add level "DEFAULT"Max Kellermann2013-11-041-7/+7
| | | | | | Map LogLevel::INFO to G_LOG_LEVEL_INFO, and LogLevel::DEFAULT to G_LOG_LEVEL_MESSAGE. Now client connect/disconnect message are only logged on log_level "secure".
* input_stream: rename struct to InputStreamMax Kellermann2013-10-231-9/+9
|
* decoder: rename the struct to "Decoder"Max Kellermann2013-10-211-2/+2
|
* decoder_plugin: rename struct to DecoderPluginMax Kellermann2013-10-211-1/+1
|
* InputStream: use int64_t instead of goffsetMax Kellermann2013-10-171-1/+1
| | | | Decouple some more from GLib.
* Log: new logging library APIMax Kellermann2013-10-021-13/+12
| | | | | Prepare to migrate away from GLib. Currently, we're still using GLib as a backend.
* DecoderCommand: convert to strictly-typed enumMax Kellermann2013-09-271-3/+3
|
* Tag, ...: move to libtag.aMax Kellermann2013-09-051-1/+1
|
* InputLegacy: move functions to the input_stream classMax Kellermann2013-09-051-5/+5
|
* util/Error: new error passing libraryMax Kellermann2013-09-041-20/+13
| | | | Replaces GLib's GError.
* audio_format: convert to C++Max Kellermann2013-08-031-7/+7
|
* tag: convert to C++Max Kellermann2013-07-301-0/+1
|
* audio_check: convert to C++Max Kellermann2013-07-291-1/+1
|
* tag_handler: convert to C++Max Kellermann2013-07-291-1/+1
|
* decoder_api: convert to C++Max Kellermann2013-07-281-1/+1
|
* decoder_buffer: convert to C++Max Kellermann2013-04-171-10/+8
|
* decoder/faad: convert to C++Max Kellermann2013-04-171-0/+504