Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | db/upnp/Device: emplace/move the UPnPService into the vector | Max Kellermann | 2014-01-22 | 1 | -1/+1 |
| | | | | Reduce overhead. | ||||
* | db/upnp/Util: "emplace" items into the list | Max Kellermann | 2014-01-22 | 1 | -3/+3 |
| | | | | Reduce overhead. | ||||
* | db/upnp/Directory: replace std::vector with a simple enum | Max Kellermann | 2014-01-22 | 1 | -20/+34 |
| | | | | Reduce bloat. | ||||
* | db/upnp/Directory: join all CDATA nodes for tag values | Max Kellermann | 2014-01-22 | 1 | -11/+43 |
| | | | | | | Expat can call CharacterData() multiple times if the CDATA contains entity references. We need to collect all of them in one large string. | ||||
* | db/upnp/Directory: make "m_dir" private | Max Kellermann | 2014-01-22 | 1 | -1/+2 |
| | |||||
* | db/upnp: merge duplicate branches in Namei() | Max Kellermann | 2014-01-21 | 1 | -25/+10 |
| | |||||
* | db/upnp: simplify Namei() | Max Kellermann | 2014-01-21 | 1 | -7/+6 |
| | |||||
* | db/upnp: use std::list instead of std::vector | Max Kellermann | 2014-01-21 | 3 | -10/+11 |
| | | | | Reduce overhead. | ||||
* | db/upnp: use iterator in Namei() | Max Kellermann | 2014-01-21 | 1 | -4/+5 |
| | |||||
* | db/upnp: move "objid" declaration down | Max Kellermann | 2014-01-21 | 1 | -2/+2 |
| | | | | Don't allocate the object when it's not needed. | ||||
* | db/upnp: eliminate redundant Namei() parameter "oobjid" | Max Kellermann | 2014-01-21 | 1 | -12/+7 |
| | | | | | The caller should better obtain the object id from the returned UPnPDirObject instance. | ||||
* | db/upnp: remove redundant objid.empty() check from VisitServer() | Max Kellermann | 2014-01-21 | 1 | -4/+0 |
| | | | | If Namei() succeeds, the object id is guaranteed to be set. | ||||
* | db/upnp: use std::move() to extract server name | Max Kellermann | 2014-01-21 | 1 | -1/+1 |
| | | | | Reduce runtime overhead. | ||||
* | db/upnp: use vector::front() instead of [0] | Max Kellermann | 2014-01-21 | 1 | -5/+5 |
| | |||||
* | db/upnp: don't use stringToTokens() in ParseDuration() | Max Kellermann | 2014-01-21 | 1 | -4/+20 |
| | | | Reduce bloat. | ||||
* | db/upnp: don't construct redundant empty vector<string> in Visit() | Max Kellermann | 2014-01-21 | 1 | -1/+1 |
| | | | | We know already that vpath is empty, let's use this instance. | ||||
* | db/upnp: simplify GetSong() | Max Kellermann | 2014-01-21 | 1 | -20/+18 |
| | |||||
* | LightSong: add attribute "real_uri" | Max Kellermann | 2014-01-21 | 1 | -24/+18 |
| | | | | | The UPnP database plugin can now show relative song URIs for remote songs. | ||||
* | db/upnp: fix empty song URI | Max Kellermann | 2014-01-21 | 1 | -3/+6 |
| | | | | Fall back to UPnPDirObject::url if there is no override. | ||||
* | LightSong: new class to be used by DatabasePlugin callbacks | Max Kellermann | 2014-01-19 | 6 | -110/+142 |
| | | | | | Detach the Song class completely from the public API, only to be used by SimpleDatabase and the update thread. | ||||
* | db/proxy: simplify error handling in GetSong() | Max Kellermann | 2014-01-19 | 1 | -11/+9 |
| | | | | | Check mpd_response_finish() before using mpd_song. Don't skip this check even if the mpd_song is non-nullptr. | ||||
* | db/simple: make borrowed_song_count "mutable" | Max Kellermann | 2014-01-19 | 2 | -3/+3 |
| | | | | Simpler to use than const_cast. | ||||
* | Song: embed the Tag object statically into class Song | Max Kellermann | 2014-01-19 | 2 | -2/+2 |
| | | | | | Reduces overhead because we need to manage only one memory allocation. According to valgrind/massif, we save 7%. | ||||
* | db/upnp: move Tag from UPnPDirObject to Song | Max Kellermann | 2014-01-18 | 1 | -11/+14 |
| | | | | | The UPnPDirObject is a temporary object, we can move its contents. This reduces runtime overhead. | ||||
* | db/upnp/Discovery: eliminate attribute "last_seen" | Max Kellermann | 2014-01-18 | 2 | -6/+4 |
| | |||||
* | db/upnp/Discovery: use monotonic clock instead of time() | Max Kellermann | 2014-01-18 | 2 | -10/+18 |
| | |||||
* | db/upnp/Discovery: eliminate full copy in getServer() | Max Kellermann | 2014-01-18 | 2 | -9/+17 |
| | |||||
* | db/upnp: use getServer() in Visit() | Max Kellermann | 2014-01-18 | 1 | -17/+9 |
| | | | | Reduce bloat. | ||||
* | db/upnp/Discovery: eliminate Error attribute | Max Kellermann | 2014-01-18 | 3 | -51/+32 |
| | | | | | Move code to method Start() and add Error& parameters to several methods. | ||||
* | db/upnp: remove unnecessary m_superdir nullptr checks | Max Kellermann | 2014-01-18 | 1 | -3/+3 |
| | |||||
* | db/upnp: pass ContentDirectoryService references | Max Kellermann | 2014-01-18 | 1 | -27/+27 |
| | |||||
* | db/upnp: cache m_path.back() | Max Kellermann | 2014-01-18 | 2 | -16/+18 |
| | |||||
* | db/upnp: add UpnpMakeAction() helper function | Max Kellermann | 2014-01-18 | 2 | -30/+78 |
| | |||||
* | db/upnp/ixmlwrap: getFirstElementValue() returns const char * | Max Kellermann | 2014-01-18 | 5 | -27/+33 |
| | | | | Eliminate the std::string bloat. | ||||
* | db/upnp: merge duplicate nullptr check | Max Kellermann | 2014-01-18 | 1 | -2/+2 |
| | |||||
* | db/upnp: free IXML_Document *request manually | Max Kellermann | 2014-01-18 | 1 | -38/+40 |
| | |||||
* | db/upnp/Device: move code to method Parse() | Max Kellermann | 2014-01-18 | 4 | -31/+39 |
| | | | | Forward the Error to the caller. | ||||
* | db/upnp/Device: use ContentDirectoryDescriptor's move operator | Max Kellermann | 2014-01-18 | 3 | -7/+7 |
| | | | | Reduce bloat. | ||||
* | db/upnp/Discovery: don't copy XML to std::string | Max Kellermann | 2014-01-18 | 3 | -4/+4 |
| | | | | Pass "const char *" to Expat. | ||||
* | db/upnp/Discovery: fix memory leak | Max Kellermann | 2014-01-18 | 1 | -0/+1 |
| | |||||
* | db/upnp: remove unused typedef DevServIt | Max Kellermann | 2014-01-18 | 1 | -2/+0 |
| | |||||
* | db/upnp: use move operator to assign XML CDATA | Max Kellermann | 2014-01-18 | 2 | -12/+12 |
| | | | | Reduce runtime bloat. | ||||
* | db/upnp/Util: trimstring() constructs string from buffer | Max Kellermann | 2014-01-18 | 4 | -17/+15 |
| | | | | | Reduce overhead by omitting the part of the buffer that consists only of whitespace. | ||||
* | db/upnp/Discovery: free the response body | Max Kellermann | 2014-01-18 | 1 | -0/+1 |
| | | | | Memory leak. | ||||
* | db/upnp/Discovery: don't copy the response body | Max Kellermann | 2014-01-18 | 1 | -2/+1 |
| | | | | Bloat. | ||||
* | db/upnp: don't hold mutex while downloading device description | Max Kellermann | 2014-01-18 | 1 | -1/+1 |
| | | | | Must not perform blocking I/O while holding a mutex. | ||||
* | db/upnp: don't use WorkQueue for _ADVERTISEMENT_BYEBYE | Max Kellermann | 2014-01-18 | 2 | -36/+30 |
| | | | | Remove the ContentDirectoryDescriptor right away. Reduces bloat. | ||||
* | db/upnp: include cleanup | Max Kellermann | 2014-01-18 | 1 | -1/+0 |
| | |||||
* | db/upnp: don't use LazyDatabase | Max Kellermann | 2014-01-18 | 1 | -2/+1 |
| | | | | Now that MPD forks early, this workaround is obsolete. | ||||
* | db/upnp/Discovery: move callbacks and data structures into class | Max Kellermann | 2014-01-17 | 3 | -72/+80 |
| | | | | Eliminate global variables. |