Commit message (Collapse) | Author | Files | Lines | ||
---|---|---|---|---|---|
2014-01-22 | db/upnp: check offset<total at end of loop | Max Kellermann | 1 | -16/+7 | |
2014-01-22 | db/upnp: break when zero objects have been returned | Max Kellermann | 1 | -0/+3 | |
2014-01-22 | db/upnp: free responses manually | Max Kellermann | 1 | -21/+6 | |
2014-01-22 | db/upnp: break when count==0 | Max Kellermann | 1 | -6/+3 | |
Make this non-fatal. Just stop reading more objects. | |||||
2014-01-22 | db/upnp: use ParseUnsigned() instead of atoi() | Max Kellermann | 1 | -16/+10 | |
2014-01-22 | db/upnp: pass unsigned integers to readDirSlice() | Max Kellermann | 2 | -17/+17 | |
2014-01-22 | db/upnp: inline ContentDirectoryService::readDirSlice() | Max Kellermann | 1 | -1/+1 | |
2014-01-22 | db/upnp: remove special case for "*" | Max Kellermann | 1 | -3/+1 | |
Passing this to csvToStrings() will do the same. | |||||
2014-01-22 | db/upnp: obtain char* from ixmlwrap::getFirstElementValue() | Max Kellermann | 1 | -9/+13 | |
Fixes crash when there's no SearchCaps element. | |||||
2014-01-22 | db/upnp/Util: pass char* to csvToStrings() | Max Kellermann | 3 | -8/+12 | |
2014-01-22 | db/upnp: require an empty input capability set | Max Kellermann | 1 | -1/+2 | |
2014-01-22 | db/upnp/Util: handle absolute URI paths properly in caturl() | Max Kellermann | 1 | -7/+20 | |
Fixes problems with some UPnP servers. | |||||
2014-01-22 | db/upnp/Util: use string::back(), string::front() | Max Kellermann | 1 | -5/+5 | |
2014-01-22 | db/upnp/Device: clear the "value" pointer on unknown element | Max Kellermann | 1 | -0/+2 | |
Avoid appending to an obsolete string object. | |||||
2014-01-22 | db/upnp/Device: replace std::vector with a std::string pointer | Max Kellermann | 3 | -47/+50 | |
2014-01-22 | db/upnp/Device: remove unused UPnPService attributes | Max Kellermann | 2 | -16/+0 | |
2014-01-22 | db/upnp/Directory: "emplace" items into the vector | Max Kellermann | 1 | -1/+1 | |
2014-01-22 | db/upnp/Device: emplace/move the UPnPService into the vector | Max Kellermann | 1 | -1/+1 | |
Reduce overhead. | |||||
2014-01-22 | db/upnp/Util: "emplace" items into the list | Max Kellermann | 1 | -3/+3 | |
Reduce overhead. | |||||
2014-01-22 | db/upnp/Directory: replace std::vector with a simple enum | Max Kellermann | 1 | -20/+34 | |
Reduce bloat. | |||||
2014-01-22 | db/upnp/Directory: join all CDATA nodes for tag values | Max Kellermann | 1 | -11/+43 | |
Expat can call CharacterData() multiple times if the CDATA contains entity references. We need to collect all of them in one large string. | |||||
2014-01-22 | db/upnp/Directory: make "m_dir" private | Max Kellermann | 1 | -1/+2 | |
2014-01-21 | db/upnp: merge duplicate branches in Namei() | Max Kellermann | 1 | -25/+10 | |
2014-01-21 | db/upnp: simplify Namei() | Max Kellermann | 1 | -7/+6 | |
2014-01-21 | db/upnp: use std::list instead of std::vector | Max Kellermann | 3 | -10/+11 | |
Reduce overhead. | |||||
2014-01-21 | db/upnp: use iterator in Namei() | Max Kellermann | 1 | -4/+5 | |
2014-01-21 | db/upnp: move "objid" declaration down | Max Kellermann | 1 | -2/+2 | |
Don't allocate the object when it's not needed. | |||||
2014-01-21 | db/upnp: eliminate redundant Namei() parameter "oobjid" | Max Kellermann | 1 | -12/+7 | |
The caller should better obtain the object id from the returned UPnPDirObject instance. | |||||
2014-01-21 | db/upnp: remove redundant objid.empty() check from VisitServer() | Max Kellermann | 1 | -4/+0 | |
If Namei() succeeds, the object id is guaranteed to be set. | |||||
2014-01-21 | db/upnp: use std::move() to extract server name | Max Kellermann | 1 | -1/+1 | |
Reduce runtime overhead. | |||||
2014-01-21 | db/upnp: use vector::front() instead of [0] | Max Kellermann | 1 | -5/+5 | |
2014-01-21 | db/upnp: don't use stringToTokens() in ParseDuration() | Max Kellermann | 1 | -4/+20 | |
Reduce bloat. | |||||
2014-01-21 | db/upnp: don't construct redundant empty vector<string> in Visit() | Max Kellermann | 1 | -1/+1 | |
We know already that vpath is empty, let's use this instance. | |||||
2014-01-21 | db/upnp: simplify GetSong() | Max Kellermann | 1 | -20/+18 | |
2014-01-21 | LightSong: add attribute "real_uri" | Max Kellermann | 1 | -24/+18 | |
The UPnP database plugin can now show relative song URIs for remote songs. | |||||
2014-01-21 | db/upnp: fix empty song URI | Max Kellermann | 1 | -3/+6 | |
Fall back to UPnPDirObject::url if there is no override. | |||||
2014-01-19 | LightSong: new class to be used by DatabasePlugin callbacks | Max Kellermann | 6 | -110/+142 | |
Detach the Song class completely from the public API, only to be used by SimpleDatabase and the update thread. | |||||
2014-01-19 | db/proxy: simplify error handling in GetSong() | Max Kellermann | 1 | -11/+9 | |
Check mpd_response_finish() before using mpd_song. Don't skip this check even if the mpd_song is non-nullptr. | |||||
2014-01-19 | db/simple: make borrowed_song_count "mutable" | Max Kellermann | 2 | -3/+3 | |
Simpler to use than const_cast. | |||||
2014-01-19 | Song: embed the Tag object statically into class Song | Max Kellermann | 2 | -2/+2 | |
Reduces overhead because we need to manage only one memory allocation. According to valgrind/massif, we save 7%. | |||||
2014-01-18 | db/upnp: move Tag from UPnPDirObject to Song | Max Kellermann | 1 | -11/+14 | |
The UPnPDirObject is a temporary object, we can move its contents. This reduces runtime overhead. | |||||
2014-01-18 | db/upnp/Discovery: eliminate attribute "last_seen" | Max Kellermann | 2 | -6/+4 | |
2014-01-18 | db/upnp/Discovery: use monotonic clock instead of time() | Max Kellermann | 2 | -10/+18 | |
2014-01-18 | db/upnp/Discovery: eliminate full copy in getServer() | Max Kellermann | 2 | -9/+17 | |
2014-01-18 | db/upnp: use getServer() in Visit() | Max Kellermann | 1 | -17/+9 | |
Reduce bloat. | |||||
2014-01-18 | db/upnp/Discovery: eliminate Error attribute | Max Kellermann | 3 | -51/+32 | |
Move code to method Start() and add Error& parameters to several methods. | |||||
2014-01-18 | db/upnp: remove unnecessary m_superdir nullptr checks | Max Kellermann | 1 | -3/+3 | |
2014-01-18 | db/upnp: pass ContentDirectoryService references | Max Kellermann | 1 | -27/+27 | |
2014-01-18 | db/upnp: cache m_path.back() | Max Kellermann | 2 | -16/+18 | |
2014-01-18 | db/upnp: add UpnpMakeAction() helper function | Max Kellermann | 2 | -30/+78 | |