aboutsummaryrefslogtreecommitdiffstats
path: root/src/command.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* command: fix boolean value parserMax Kellermann2008-10-231-1/+1
| | | | | Due to a logic error, no value was valid for the boolean value parser. Replace "||" with "&&".
* stored_playlist: renamed and moved spl_delete() to stored_playlist.cMax Kellermann2008-10-231-1/+1
| | | | The function deletePlaylist() shouldn't be in playlist.c.
* command: check over/underflows in check_int()Max Kellermann2008-10-231-2/+13
| | | | | The "long" result of strtol() was implicitly casted down to a 32 bit integer. Add some range checking instead.
* command: added check_unsigned() / check_bool()Max Kellermann2008-10-231-13/+57
| | | | | | | Many command arguments must not be negative; add a separate parser/checker function for that. For the same reason, add check_bool(). This eliminates two strange special cases handlers from check_int().
* playlist: unsigned integersMax Kellermann2008-10-231-3/+3
| | | | | | There are some integers which have a "magic" -1 value which means "undefined" or "nothing". All others can be converted to unsigned, since they must not contain a negative number.
* command: use the bool datatype instead of intMax Kellermann2008-10-221-50/+51
| | | | | Instead of returning 0 for success and -1 for failure, return true or false. This seems more natural.
* command: converted COMMAND_RETURN_* macros to enumMax Kellermann2008-10-221-163/+165
| | | | | | | | Also add names for "error" and "ok". I don't like passing anonymous integer codes around. This is not yet complete: lots of functions (e.g. in playlist.c) follow the same convention of -1/0, and these have to be adapted, too.
* command: replaced "goto" with "break"Max Kellermann2008-10-221-2/+2
| | | | http://xkcd.com/292/
* command: no CamelCaseMax Kellermann2008-10-221-227/+247
| | | | Eliminate CamelCase in all public and static functions.
* command: removed CommandHandlerFunction typedefMax Kellermann2008-10-221-3/+1
| | | | | The typedef CommandHandlerFunction is only used once. Move its type into the command struct.
* ack: converted ACK_ERROR_* macros to enumMax Kellermann2008-10-221-2/+2
|
* stored_playlist: send timestampsMax Kellermann2008-10-221-0/+8
| | | | | Send last modification timestamps to the client. This allows the client to see when another client modifies a stored playlist.
* command: added command "listplaylists"Max Kellermann2008-10-221-0/+17
| | | | | "listplaylists" returns a list of all stored playlists. This command seems more elaborate than listing them below "lsinfo".
* command: added print_spl_list()Max Kellermann2008-10-221-2/+18
| | | | | The function print_spl_list() replaces the old function lsPlaylists() from ls.c.
* stored_playlist: de-CamelCase moved functionMax Kellermann2008-10-221-2/+2
| | | | | Rename addToStoredPlaylist() to spl_append_uri(), and remove the clearStoredPlaylist() macro.
* stored_playlist: no CamelCaseMax Kellermann2008-10-221-3/+3
| | | | Renamed all public functions, prefix is "spl_".
* renamed storedPlaylist.c to stored_playlist.cMax Kellermann2008-10-221-1/+1
| | | | No CamelCase in file names.
* command: added "commands" array instead of registering manuallyMax Kellermann2008-10-221-193/+145
| | | | | | The list of commands is known at compile time. Instead of creating a linked list on startup, we can just register all commands in a static sorted array.
* command: make command pointers constantMax Kellermann2008-10-221-12/+13
| | | | | | The command pointers which are passed around aren't being modified - in fact, no command pointer must be modified once it has been added to the commandList.
* command: renamed CommandEntry to struct commandMax Kellermann2008-10-221-12/+10
| | | | No CamelCase and no struct typedefs.
* client: converted permissions to unsignedMax Kellermann2008-10-171-7/+7
| | | | client->permission is a bit set, and should be unsigned.
* command: expect "file:///" url for local filesMax Kellermann2008-10-171-4/+7
| | | | | | When adding a local file, clients have to use the "file" URI schema described in RFC 1738 3.10. By adding this schema to "urlhandlers", a client can detect whether this feature is available.
* command: special case for "add /"Max Kellermann2008-10-161-1/+1
| | | | | The undocumented command "add /" adds the full music database to the playlist. Don't interpret this special path as a local file path.
* playlist: added support for adding songs not in the music databaseMax Kellermann2008-10-151-1/+17
| | | | | Clients which have authenticated via unix socket may add local files to the MPD playlist, provided that they own the file.
* command: print error message on "addid" failureMax Kellermann2008-10-151-1/+1
| | | | | | Returning the playlist_result value from a command handler does not make sense. Call print_playlist_result() there, and forward its return value.
* command: added command "idle"Max Kellermann2008-10-141-0/+12
| | | | | | "idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
* player: added player_get_audio_format()Max Kellermann2008-10-101-2/+3
| | | | | player_get_audio_format() replaces getPlayerSampleRate(), getPlayerBits(), getPlayerChannels().
* player: added player_control.audio_formatMax Kellermann2008-10-101-1/+1
| | | | This replaces the attributes bits, channels, sampleRate.
* update: make the job id unsignedMax Kellermann2008-10-091-1/+1
| | | | Since the return value cannot be -1 anymore, we can make it unsigned.
* update: job ID must be positiveMax Kellermann2008-10-091-15/+11
| | | | | | | The documentation for directory_update_init() was incorrect: a job ID must be positive, not non-negative. If the update queue is full and no job was created, it makes more sense to return 0 instead of -1, because it is more consistent with the return value of isUpdatingDB().
* diretory: moved code to directory_save.c, directory_print.cMax Kellermann2008-10-091-0/+1
| | | | | | Remove clutter from directory.c. Everything which saves or loads to/from the hard disk goes to directory_save.c, and code which sends directory information to the client is moved into directory_print.c.
* Fix error code for "Playlist already exists"Qball Cow2008-10-091-1/+1
| | | | | | | With commit 6dcd7fea (if I am not mistaken) the error returned when you try to save to an existing playlist is wrong. Instead of MPD_ACK_ERROR_EXIST, MPD_ACK_ERROR_NO_EXIST is returned. This is obviously wrong and breaks gmpc.
* database: renamed functions, "db_" prefix and no CamelCaseMax Kellermann2008-10-081-1/+1
| | | | Yet another CamelCase removal patch.
* database: removed printDirectoryInfo()Max Kellermann2008-10-081-1/+5
| | | | The same can be achieved with directory_print(db_get_directory()).
* directory: moved code to database.cMax Kellermann2008-10-081-0/+1
| | | | | | Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
* directory: moved code to update.cMax Kellermann2008-10-081-0/+1
| | | | | | The source directory.c mixes several libraries: directory object management, database management and database update, resulting in a 1000+ line monster. Move the whole database update code to update.c.
* command: fix return statusEric Wong2008-10-061-17/+8
| | | | | | This got broken when listHandlerFunc was removed. Since we no longer need it and it's confusing, remove processCommandInternal and just use process_command.
* command: get rid of specialized list handlersEric Wong2008-10-061-88/+67
| | | | | | | | commands should really not behave differently if they're issued inside a command list or not; so stop having special handler functions to deal with them. "update" was the only command that used this functionality and I changed that in the last commit to serialize access.
* directory: simplify list update handling logicEric Wong2008-10-061-61/+18
| | | | | | | | | | | | | | Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
* switch to C99 types, part IIMax Kellermann2008-09-291-3/+3
| | | | | Do full C99 integer type conversion in all modules which were not touched by Eric's merged patch.
* command: don't clobber next list value when preparsingEric Wong2008-09-291-3/+6
| | | | | | | This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.
* update: send proper response to the clientMax Kellermann2008-09-251-5/+8
| | | | | | Due to a merge error, I broke the function handleUpdate(). It did not do anything for the global update, and it did not send a proper response to the client. This patch fixes both bugs.
* command: fix command "addid"Max Kellermann2008-09-231-1/+1
| | | | | | With patch 8d2830b3, I broke "addid": it did not return the id of the new song, because of a typo in the return condition (== instead of !=).
* directory: update do its work inside a threadEric Wong2008-09-231-41/+6
| | | | | | | | | A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
* playlist: return -1 after assert(0)Max Kellermann2008-09-071-0/+1
| | | | | | | print_playlist_result() had an assert(0) at the end, in case there was an invalid result value. With NDEBUG, this resulted in a function not returning a value - add a dummy "return -1" at the end to keep gcc quiet.
* command: use client_[gs]et_permission()Max Kellermann2008-09-071-78/+83
| | | | | | Don't pass a pointer to client->permission to processCommand(), better let the code in command.c use the new permission getter/setter functions.
* command: don't pass permission as pointer where appropriateMax Kellermann2008-09-071-6/+6
| | | | | Some functions don't want to modify a client's permission set. Pass the permissions to them by value, not by reference.
* audio: don't pass "fd" to printAudioDevices()Max Kellermann2008-09-071-1/+1
| | | | Pass the client struct instead.
* stats: don't pass "fd" to printStats()Max Kellermann2008-09-071-1/+1
| | | | Pass the client struct instead of the raw file descriptor.
* playlist: don't pass "fd" to showPlaylist(), playlistChangesPosId()Max Kellermann2008-09-071-2/+2
| | | | Pass the client struct instead of the raw file descriptor.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 08:39:41 +0000