aboutsummaryrefslogtreecommitdiffstats
path: root/src/client.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-09-17client: check expired after client_process_line()Max Kellermann1-1/+3
The assertion on "!client_is_expired(client)" was wrong, because writing the command response may cause the client to become expired. Replace that assertion with a check.
2008-09-10client: simplified client_read()Max Kellermann1-3/+5
Remove one comparison by changing branch order.
2008-09-10client: client_input_received() returns 0Max Kellermann1-4/+2
Since the caller chain doesn't care about the return value (except for COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is nothing special. This saves one local variable initialization, and one access to it. Also remove one unreachable "return 1" from client_read().
2008-09-10client: check for COMMAND_RETURN_CLOSEMax Kellermann1-15/+14
Don't close the client within client_process_line(), return COMMAND_RETURN_CLOSE instead. This is the signal for the caller chain to actually close it. This makes dealing with the client pointer a lot safer, since the caller always knows whether it is still valid.
2008-09-10client: renamed local variable "selret" to "ret"Max Kellermann1-4/+4
It's easier to reuse the variable if it has a more generic name.
2008-09-10client: moved CLOSE/KILL check after client_process_line()Max Kellermann1-4/+3
Don't update client data if it is going to be closed anyway.
2008-09-07command: use client_[gs]et_permission()Max Kellermann1-3/+1
Don't pass a pointer to client->permission to processCommand(), better let the code in command.c use the new permission getter/setter functions.
2008-09-07client: added client_[gs]et_permission()Max Kellermann1-0/+10
The code in command.c shouldn't mess with a pointer to client->permission. Provide an API for accessing this value.
2008-09-07removed fdprintf() and client_print()Max Kellermann1-25/+0
All callers of fdprintf() have been converted to client_printf() or fprintf(); it is time to remove this clumsy hack now. We can also remove client_print() which took a file descriptor as parameter.
2008-09-07client: removed client_get_fd()Max Kellermann1-8/+0
Now that we have removed all invocations of client_get_fd(), we can safely remove this transitional function. All access to the file descriptor is now hidden behind the interface declared in client.h.
2008-09-07command: added command_success() and command_error()Max Kellermann1-2/+2
These two functions take a client struct instead of the file descriptor. We will now begin passing the client struct around instead of a raw file descriptor (which needed a linear lookup in the client list to be useful).
2008-09-07client: added client_printf()Max Kellermann1-0/+29
Based on client_puts(), client_printf() is the successor of fdprintf(). As soon as all fdprintf() callers have been rewritten to use client_printf(), we can remove fdprintf().
2008-09-07client: added client_write() and client_puts()Max Kellermann1-24/+34
client_write() writes a buffer to the client and buffers it if required. client_puts() does the same for a C string. The next patch will add more tools which will replace fdprintf() later.
2008-09-06include cleanupMax Kellermann1-1/+0
As usual, include only headers which are really needed.
2008-09-06client: don't check FD_ISSET(client->fd) on expired clientMax Kellermann1-1/+2
client->fd becomes -1 when the client expires. Don't use FD_ISSET() with this expired client; doing so would cause a crash due to SIGBUS.
2008-09-06client: removed assert(client->fd)>=0Max Kellermann1-4/+2
Since client->fd==-1 has become our "expired" flag, it may already be -1 when client_close() is called. Don't assert that it is still non-negative, and call client_set_expired() instead.
2008-08-29export the function client_is_expired()Max Kellermann1-8/+1
Instead of passing the pointer to the "expired" flag to processListOfCommands(), this function should use the client API to check this flag. We can now remove the "global_expired" hack introduced recently.
2008-08-29client: pass the client struct to processCommand()Max Kellermann1-2/+10
Start exporting the client struct as an opaque struct. For now, pass it only to processCommand() and processListOfCommands(), and provide a function to extract the socket handle. Later, we will propagate the pointer to all command implementations, and of course to client_print() etc.
2008-08-29client: check "expired" after command executionMax Kellermann1-7/+14
The old code tried to write a response to the client, without even checking if it was already closed. Now that we have added more assertions, these may fail... perform the "expired" check earlier.
2008-08-29client: added global "expired" flagMax Kellermann1-6/+7
Patch bdeb8e14 ("client: moved "expired" accesses into inline function") was created under the wrong assumption that processListOfCommands() could modify the expired flag, which is not the case. Although "expired" is a non-const pointer, processListOfCommands() just reads it, using it as the break condition in a "while" loop. I will address this issue with a better overall solution, but for now provide a pointer to a global "expired" flag.
2008-08-29client: removed superfluous assertionMax Kellermann1-1/+0
client_defer_output() was modified so that it can create the deferred_send list. With this patch, the assertion on "deferred_send!=NULL" has become invalid. Remove it.
2008-08-28client: more assertionsMax Kellermann1-0/+6
2008-08-28client: replace "expired" flag with fd==-1Max Kellermann1-6/+6
Why waste 4 bytes for a flag which we can hide in another variable.
2008-08-28client: moved "expired" accesses into inline functionMax Kellermann1-13/+29
Hiding this flag allows us later to remove it easily.
2008-08-28moved code to sockaddr_to_tmp_string()Max Kellermann1-9/+17
Unclutter the client_new() constructor by moving unrelated complex code into a separate function.
2008-08-28client: no while loop in client_manager_io()Max Kellermann1-32/+26
The last patch removed the "continue" directive, and now the while loop is without function. Remove it. Also make client_manager_io() return 0.
2008-08-28client: select() errors are fatalMax Kellermann1-30/+6
Previously, when select() failed, we assumed that there was an invalid file descriptor in one of the client structs. Thus we tried select() one by one. This is bogus, because we should never have invalid file descriptors. Remove it, and make select() errors fatal.
2008-08-28client: use client_defer_output() in client_write()Max Kellermann1-7/+3
Eliminate duplicated code, call client_defer_output() which we splitted from client_write_output() earlier.
2008-08-28moved code to client_write()Max Kellermann1-26/+28
Move the second part of client_write_output() into a separate function.
2008-08-28client: client_defer_output() can create the first defer bufferMax Kellermann1-5/+5
client_defer_output() was designed to add new buffers to an existing deferred_send buffer. Tweak it and allow it to create a new buffer list.
2008-08-28client: return early on error in client_defer_output()Max Kellermann1-5/+7
Exit the function when an error occurs, and move the rest of the following code one indent level left.
2008-08-28client: moved code to client_defer_output()Max Kellermann1-20/+27
Split the large function client_write_output() into two parts; this is the first code moving patch.
2008-08-28don't free client resources except in client_close()Max Kellermann1-15/+0
All of the client's resources are freed in client_close(). It is enough to set the "expired" flag, no need to duplicate lots of destruction code again and again.
2008-08-28client: allocate clients dynamicallyMax Kellermann1-90/+76
Due to the large buffers in the client struct, the static client array eats several megabytes of RAM with a maximum of only 10 clients. Stop this waste and allocate each client struct from the heap.
2008-08-28client: added function client_by_fd()Max Kellermann1-13/+21
The code becomes less complex and more readable when we move this linear search into a separate mini function.
2008-08-28client: return early in client_new()Max Kellermann1-30/+31
This saves one level of indent.
2008-08-28client: renamed all public functionsMax Kellermann1-6/+6
Functions which operate on the whole client list are prefixed with "client_manager_", and functions which handle just one client just get "client_".
2008-08-28client: renamed internal functions and variablesMax Kellermann1-297/+296
Rename all static functions, variables and macros which have "interface" in their name to something nicer prefixed with "client_".
2008-08-28client: renamed Interface to struct clientMax Kellermann1-19/+19
Second patch: rename the internal struct name. We will eventually export this type as an opaque forward-declared struct later, so we can pass a struct pointer instead of a file descriptor, which would save us an expensive linear lookup.
2008-08-28renamed interface.c to client.cMax Kellermann1-1/+1
I don't believe "interface" is a good name for something like "connection by a client to MPD", let's call it "client". This is the first patch in the series which changes the name, beginning with the file name.
2008-08-28const pointersMax Kellermann1-5/+5
The usual bunch of pointer arguments which should be const.
2008-04-12Fix the problem of songs not advancing without client activityEric Wong1-0/+3
The select() in the main event loop blocks now (saving us many unnecessary wakeups). This interacted badly with the threads that were trying to wakeup the main task via pthread_cond_signal() since the main task was not blocked on a condition variable, but on select(). So now if we detect a need to wakeup the player, we write to a pipe which select() is watching instead of blindly calling pthread_cond_signal(). git-svn-id: https://svn.musicpd.org/mpd/trunk@7347 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-04-12clean up CPP includesMax Kellermann1-2/+3
Try to only include headers which are really needed. We should particularly check all "headers including other headers". The long-term goal is to have a manageable, small API for plugins (decoders, output) without so many mpd internals cluttering the namespace. git-svn-id: https://svn.musicpd.org/mpd/trunk@7319 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-04-12provide switches for TCP and unix socketsMax Kellermann1-0/+4
autoconf flags for enabling and disabling TCP and unix domain socket support. Embedded machines without a TCP stack may be better off without TCP support. git-svn-id: https://svn.musicpd.org/mpd/trunk@7236 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-04-12fix sign compare warningsMax Kellermann1-1/+1
Do explicit casts before comparing signed with unsigned. The one in log.c actually fixes another warning: in the expanded macro, there may be a check "logLevel>=0", which is always true. git-svn-id: https://svn.musicpd.org/mpd/trunk@7230 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26interface: use a saner fdmax for select(2) when closing errored interfacesEric Wong1-1/+2
git-svn-id: https://svn.musicpd.org/mpd/trunk@7218 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26notify: cleanupsEric Wong1-4/+1
* move set_nonblock{,ing}() into utils.c since we use it elsewhere, too * add proper error checking to set_nonblocking() * use os_compat.h instead of individually #includ-ing system headers git-svn-id: https://svn.musicpd.org/mpd/trunk@7217 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26unsigned countersMax Kellermann1-11/+11
Use unsigned variables for storing the count of items or for iteration variables. Since there can never be a negative number of items, it makes sense to use an unsigned data type here. This change is safe because the unsigned values are only used for adddressing array items. git-svn-id: https://svn.musicpd.org/mpd/trunk@7214 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26don't repeat select()Max Kellermann1-5/+2
The interfaces main loop repeats the select() (non-blocking) after an event was handled. I do not see any reason for that, since all events should be handled after the first select(). This double select() does nothing than consume more CPU cycles. git-svn-id: https://svn.musicpd.org/mpd/trunk@7213 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2008-03-26unlimited select() timeoutMax Kellermann1-5/+3
mpd sets a 1s select() timeout for no reason. This makes mpd wake up the CPU, consume some cycles just to see there is nothing to do. We can save that by specifying NULL instead of a timeout. git-svn-id: https://svn.musicpd.org/mpd/trunk@7212 09075e82-0dd4-0310-85a5-a0d7c8717e4f