Commit message (Collapse) | Author | Files | Lines | ||
---|---|---|---|---|---|
2013-11-28 | include cleanup using iwyu | Max Kellermann | 1 | -1/+0 | |
2013-11-08 | PlayerThread: fix stuck MPD after song change (0.18.2 regression) | Max Kellermann | 1 | -4/+8 | |
Commit 77c63511 caused MPD to become stuck right after a song change. The problem was that at some point, the MusicBuffer became full, and the DecoderThread working on the next song waits for the PlayerThread. However, the PlayerThread was stuck in a loop of g_usleep() calls, and never bothered to tell the DecoderThread that the MusicBuffer is not full anymore. This bug is very old, but its chance to occur went from nearly 0% to nearly 100%. The fix is to wake up the DecoderThread before waiting for it. As a side effect, I replaced the g_usleep() call with a Cond::Wait() call. | |||||
2013-11-06 | PlayerThread: reduce the number of DecoderThread wakeups | Max Kellermann | 1 | -2/+14 | |
After the number of decoded chunks has fallen below the threshold, the PlayerThread woke up the DecoderThread over and over. This commit adds a boolean flag that avoids these duplicate wakeups, and thus reduces the number of system calls. | |||||
2013-11-06 | PlayerThread: enable buffering when starting playback | Max Kellermann | 1 | -1/+1 | |
For some reason, this got lost in commit 975deca8. Re-enabling this fixes stuttering at the beginning of radio streams. | |||||
2013-11-04 | Log: add level "DEFAULT" | Max Kellermann | 1 | -1/+1 | |
Map LogLevel::INFO to G_LOG_LEVEL_INFO, and LogLevel::DEFAULT to G_LOG_LEVEL_MESSAGE. Now client connect/disconnect message are only logged on log_level "secure". | |||||
2013-10-30 | PcmMix: use negative value instead of NaN for addition | Max Kellermann | 1 | -3/+1 | |
Avoid NaN to allow -ffast-math. | |||||
2013-10-30 | CrossFade: use negative value for invalid mixramp_delay | Max Kellermann | 1 | -1/+1 | |
Avoid NaN to allow -ffast-math. | |||||
2013-10-29 | PlayerControl: move attributes to struct CrossFadeSettings | Max Kellermann | 1 | -12/+10 | |
2013-10-28 | DecoderControl: convert mutex and client_cond to a reference | Max Kellermann | 1 | -19/+12 | |
Share the Mutex between the DecoderThread and the PlayerThread. This simplifies synchronization between the two threads and fixes a freeze problem: while the PlayerThread waits for the DeocderThread, it cannot answer requests from the main thread, and the main thread will block until the DecoderThread finishes. | |||||
2013-10-28 | player_control: rename to PlayerControl | Max Kellermann | 1 | -9/+9 | |
2013-10-28 | decoder_control: rename to DecoderControl | Max Kellermann | 1 | -4/+4 | |
2013-10-26 | DecoderControl: add MixRamp getters | Max Kellermann | 1 | -2/+2 | |
2013-10-22 | Playlist: copy stream tags from the PlayerThread | Max Kellermann | 1 | -2/+8 | |
Finally restores an important feature that has been broken for several months when the PlayerThread started working with Song copies instead of pointers to the Queue's Song instances (commit e96779d). | |||||
2013-10-21 | Song: pass reference to song_equals() | Max Kellermann | 1 | -1/+1 | |
2013-10-19 | *: use references instead of pointers | Max Kellermann | 1 | -3/+3 | |
2013-10-19 | PlayerThread: Only drop 0 length packets without tags | Ben Boeckel | 1 | -1/+1 | |
Fixes a regression from 752dfb3d95482c562e5d24c6ea839c4815de9a6d which caused the current chunk to be flushed as soon as new replaygain information was found. If this occurs on a tag chunk, it has no data (length 0) and is then skipped before pushing it to all of the outputs. This change allows 0-length chunks through if they contain a tag and they are now appearing in mplayer and mpv properly. | |||||
2013-10-17 | Thread/Thread: replacement library for GThread | Max Kellermann | 1 | -13/+8 | |
2013-10-17 | Song: GetURI() returns std::string | Max Kellermann | 1 | -7/+6 | |
2013-10-02 | Log: new logging library API | Max Kellermann | 1 | -9/+11 | |
Prepare to migrate away from GLib. Currently, we're still using GLib as a backend. | |||||
2013-09-27 | PlayerThread: convert struct player to a class | Max Kellermann | 1 | -14/+17 | |
2013-09-27 | PlayerThread: use strictly typed enum | Max Kellermann | 1 | -14/+14 | |
2013-09-27 | PlayerControl: use strictly typed enums | Max Kellermann | 1 | -44/+44 | |
2013-09-27 | PlayerThread: move code to player_control::CommandFinished() | Max Kellermann | 1 | -21/+12 | |
2013-09-27 | PlayerThread: use nullptr instead of NULL | Max Kellermann | 1 | -37/+37 | |
2013-09-26 | PlayerThread: unlock/lock in player_task() | Max Kellermann | 1 | -8/+3 | |
2013-09-26 | PlayerThread: move code into the player class | Max Kellermann | 1 | -269/+277 | |
2013-09-26 | PlayerThread: use player references | Max Kellermann | 1 | -116/+115 | |
2013-09-26 | PlayerThread: use {decoder,player}_control references | Max Kellermann | 1 | -214/+214 | |
2013-09-26 | PlayerThread: allocate decoder_control on the stack | Max Kellermann | 1 | -5/+5 | |
2013-09-26 | PlayerThread: move global MusicBuffer variable into the player object | Max Kellermann | 1 | -24/+27 | |
2013-09-26 | PlayerThread: simplify "buffer empty" assertion | Max Kellermann | 1 | -7/+1 | |
2013-09-26 | MusicBuffer: expose the C++ API | Max Kellermann | 1 | -19/+18 | |
2013-09-26 | MusicPipe: expose the C++ API | Max Kellermann | 1 | -25/+24 | |
2013-09-05 | Tag, ...: move to libtag.a | Max Kellermann | 1 | -1/+1 | |
2013-09-04 | util/Error: new error passing library | Max Kellermann | 1 | -21/+19 | |
Replaces GLib's GError. | |||||
2013-08-07 | Makefile.am: move sources to libsystem.a | Max Kellermann | 1 | -1/+1 | |
2013-08-07 | FatalError: new library to replace mpd_error.h | Max Kellermann | 1 | -2/+2 | |
2013-08-04 | *: use gcc.h macros instead of GLib | Max Kellermann | 1 | -1/+1 | |
2013-08-03 | audio_format: convert to C++ | Max Kellermann | 1 | -14/+13 | |
2013-07-30 | tag: convert to C++ | Max Kellermann | 1 | -12/+12 | |
2013-07-28 | song: convert header to C++ | Max Kellermann | 1 | -21/+21 | |
2013-04-17 | use g_thread_new() if GLib is recent enough | Max Kellermann | 1 | -0/+4 | |
Fixes deprecation warnings. | |||||
2013-01-25 | PlayerControl: add second Cond object | Max Kellermann | 1 | -1/+1 | |
This fixes a deadlock bug introduced by 18076ac9. After all, the second Cond was necessary. The problem: two threads can wait for a signal at the same time. The player thread waits for the output thread to finish playback. The main thread waits for the player thread to complete a command. The output thread finishes playback, and sends a signal, which unfortunately does not wake up the player thread, but the main thread. The main thread sees that the command is still not finished, and waits again. The signal is lost forever, and MPD is deadlocked. | |||||
2013-01-21 | DecoderControl: move functions into the class | Max Kellermann | 1 | -31/+31 | |
2013-01-20 | PlayerControl: move functions into the class | Max Kellermann | 1 | -61/+61 | |
2013-01-10 | PlayerControl: switch to the Mutex/Cond classes | Max Kellermann | 1 | -1/+1 | |
2013-01-10 | PlayerThread: use pc.cond instead of main_cond | Max Kellermann | 1 | -1/+1 | |
The main_cond variable was completely unnecessary. The pc.cond object can be used for both main->pc and pc->main. | |||||
2013-01-10 | DecoderControl: take ownership of client_cond | Max Kellermann | 1 | -1/+1 | |
Don't let the "client" pass its own GCond. This was not used consistently. | |||||
2013-01-09 | EventPipe: rename to GlobalEvents | Max Kellermann | 1 | -5/+5 | |
2013-01-09 | event_pipe.h: convert to C++ | Max Kellermann | 1 | -4/+1 | |