aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | set the close-on-exec flag on all file descriptorsMax Kellermann2009-11-0717-24/+271
| | | | | | | | | | | | | | | | | | | | | | Added the "fd_util" library, which attempts to use the new thread-safe Linux system calls pipe2(), accept4() and the options O_CLOEXEC, SOCK_CLOEXEC. Without these, it falls back to FD_CLOEXEC, which is not thread safe. This is particularly important for the "pipe" output plugin (and others, such as JACK/PulseAudio), because we were heavily leaking file descriptors to child processes.
* | decoder_thread: close input fileMax Kellermann2009-11-071-3/+10
| | | | | | | | | | An input_stream_close() call was missing after today's code reorganization.
* | log: redirect stdout/stderr to /dev/null if syslog is usedMax Kellermann2009-11-072-1/+5
| | | | | | | | | | Don't hold a file descriptor on root's tty when syslog is used for logging.
* | output/jack: added option "server_name"Max Kellermann2009-11-073-2/+18
| |
* | output_all: automatically attempt to re-enable failed outputsMax Kellermann2009-11-071-0/+1
| | | | | | | | | | | | | | When an output's enable() method has failed, and playback starts, retry to enable it. Without this, the user may be confused, because he sees the device is "enabled" but cannot use it, and currently there is no error message in the log.
* | output/httpd: moved code to httpd_output_bind()Max Kellermann2009-11-071-28/+48
| |
* | exclude: use GPatternSpec instead of fnmatch()Max Kellermann2009-11-071-5/+5
| | | | | | | | GLib's version of fnmatch() is more portable.
* | added missing source file decoder_print.cMax Kellermann2009-11-072-0/+81
| |
* | database: I/O error handling in db_save()Max Kellermann2009-11-073-19/+16
| | | | | | | | Check ferror() instead of the fprintf() return value.
* | update_walk: log new container filesMax Kellermann2009-11-071-1/+4
| |
* | command: added command "decoders"Max Kellermann2009-11-073-0/+31
| | | | | | | | | | This command prints a list of decoder plugins and their suffixes / MIME types.
* | decoder_list: moved print_all_decoders() to cmdline.cMax Kellermann2009-11-073-28/+27
| | | | | | | | | | | | Export the decoder_plugins array. The function decoder_plugin_print_all_decoders() it is UI specific and should not live in this backend library.
* | decoder_thread: check for STOP before calling the pluginMax Kellermann2009-11-071-0/+6
| | | | | | | | | | Before calling the plugin's decode method, we should ensure that we didn't receive a STOP command during initialization.
* | decoder_thread: moved code to decoder_input_stream_open()Max Kellermann2009-11-071-27/+50
| | | | | | | | | | | | This function opens the stream and waits for it to become ready; meanwhile it checks for STOP commands. It is code moved from decoder_run_stream().
* | decoder_thread: added local variable "dc" in decoder_run_file()Max Kellermann2009-11-071-6/+7
| | | | | | | | Simplify the expressions.
* | output/jack: free source port names on exitMax Kellermann2009-11-071-0/+3
| | | | | | | | Make valgrind happy.
* | decoder_list: pass previous plugin pointer to lookup functionsMax Kellermann2009-11-074-19/+40
| | | | | | | | Remove the static integer hack, that's not thread safe and sucks.
* | decoder_list: moved suffix/mime_type checks to decoder_plugin.cMax Kellermann2009-11-074-4/+65
| |
* | decoder_list: back to NULL terminated listMax Kellermann2009-11-071-7/+8
| | | | | | | | A NULL terminated list is easier to iterate.
* | decoder_thread: open input stream on demandMax Kellermann2009-11-071-72/+59
| | | | | | | | | | | | Moved the global input stream opener to decoder_run_stream(). decoder_run_file() now opens the input stream each time a plugin provides a stream decoder method.
* | decoder_thread: moved plugin loops to separate functionsMax Kellermann2009-11-071-82/+127
| | | | | | | | Tame the large decoder_run_song() function.
* | uri: added function attributesMax Kellermann2009-11-071-0/+5
| | | | | | | | Let gcc optimize a little bit more.
* | utils: renamed stringFoundInStringArray()Max Kellermann2009-11-066-30/+35
| | | | | | | | | | No CamelCase. Use bool instead of int. Make both arguments mandatory.
* | output/jack: dynamic source port listMax Kellermann2009-11-063-38/+87
| | | | | | | | | | | | Same as the previous patch: create up to 16 configured source ports. The plugin tries to do its best at guessing the right combination for the given input file, the number of source and destination ports.
* | output/jack: dynamic destination port listMax Kellermann2009-11-061-25/+71
| | | | | | | | | | Support up to 16 configured destination ports, that should really be enough for everybody.
* | output/jack: renamed option "ports" to "destination_ports"Max Kellermann2009-11-063-2/+11
| | | | | | | | Be more clear which kind of port should be configured here.
* | output/jack: renamed "output ports" to "destination ports"Max Kellermann2009-11-062-19/+21
| | | | | | | | Use the same name as in the libjack API documentation.
* | playlist_queue: use playlist plugins to load from playlist_directoryMax Kellermann2009-11-061-0/+33
| | | | | | | | | | | | | | | | This patch allows the client to load a playlist file from the playlist directory with a plugin. This can be used with the "load" command, but the client has to pass the file name including the suffix. We will probably use the music directory in the future, to support playlist files inside the music directory.
* | playlist_queue: moved code to playlist_open_remote_into_queue()Max Kellermann2009-11-061-5/+12
| |
* | playlist_list: added function playlist_list_open_path()Max Kellermann2009-11-062-0/+47
| | | | | | | | Added an interface for loading playlists from a local file.
* | playlist: added extm3u pluginMax Kellermann2009-11-066-1/+198
| | | | | | | | | | This new plugin parses extm3u files. Files without the "#EXTM3U" header are still parsed by the plain old "m3u" plugin.
* | playlist/{m3u,pls}: removed URI checksMax Kellermann2009-11-062-7/+1
| | | | | | | | The caller is responsible for verifying the song URI.
* | playlist_list: rewind the stream before opening the playlistMax Kellermann2009-11-061-0/+9
| | | | | | | | | | | | If one plugin has failed to open the playlist, it may have consumed a part of the stream already. This may lead to a failure in all following plugins. Fix: rewind the stream before each open() call.
* | output/httpd: bind port when output is enabledMax Kellermann2009-11-053-14/+51
| | | | | | | | | | | | Implement the methods enable() and disable(). Bind the HTTP port in the enable() method, but reject all incoming connections until the output is opened.
* | output/jack: support mono inputMax Kellermann2009-11-052-13/+42
| | | | | | | | | | When MPD plays a mono song (audio_format.channel==1), connect only one source port to both destination ports.
* | output/jack: clear ring buffers before activatingMax Kellermann2009-11-052-1/+7
| | | | | | | | | | | | After playback has stopped, the ring buffers may still contain samples. These will be played when playback is started the next time. We should clear the buffers each time.
* | output/jack: use jack_client_open() instead of jack_client_new()Max Kellermann2009-11-054-5/+36
| | | | | | | | | | | | | | | | jack_client_new() is deprecated. This requires libjack 0.100 (released nearly 5 years ago). We havn't been testing older libjack versions anyway. As a side effect, there is the new option "autostart".
* | doc/user: document JACK plugin optionsMax Kellermann2009-11-051-0/+43
| |
* | output/jack: added option "client_name"Max Kellermann2009-11-053-6/+5
| | | | | | | | | | | | Instead of using MPD's audio output name (setting "name"), use a separate configuration option. Change the default to "Music Player Daemon".
* | update_walk: log unrecognized filesMax Kellermann2009-11-051-2/+9
| | | | | | | | | | | | When a song's tags could not be loaded during database update, log this as a debug message. Same for a song being removed because its updated tag could not be read.
* | database: rescan after metadata_to_use changeMax Kellermann2009-11-042-0/+33
| | | | | | | | | | | | Store a list of supported tag items in the database. When loading a database which does not have a matching list, we must rescan in order to get the missing information.
* | tag: added function tag_name_parse()Max Kellermann2009-11-044-26/+61
| | | | | | | | Convert a string into a tag_type enum.
* | song_save: explicitly parse the colonMax Kellermann2009-11-041-18/+27
| | | | | | | | | | Clear the colon. This simplifies all attribute parsers, because they can now use strcmp() instead of strncmp().
* | decoder_thread: initialize decoder_control.quitMax Kellermann2009-11-041-0/+2
| | | | | | | | If left uninitialized, then the decoder thread quits spuriously.
* | Merge branch 'master' of git://git.musicpd.org/romain/mpdMax Kellermann2009-11-042-0/+10
|\ \
| * | sticker comments in code and example configuration fileRomain Bignon2009-11-042-0/+10
| | | | | | | | | | | | Signed-off-by: Romain Bignon <romain@peerfuse.org>
* | | player_thread: on return, reset next_song only if queuedMax Kellermann2009-11-031-3/+7
| | | | | | | | | | | | | | | If no song was queued, then player_control.next_song might contain the value for the next QUEUE command. We must not reset that.
* | | player_thread: detect finished queued songMax Kellermann2009-11-031-1/+2
| | | | | | | | | | | | | | | | | | | | | When the decoder finishes the "queued" song very quickly (before the "current" song finishes playing), an assertion in do_play() fails because it thinks that it should start decoding the queued song, although that has in fact just finished.
* | | player_control: moved pc.next_song assertion into lockMax Kellermann2009-11-031-1/+2
| | | | | | | | | | | | | | | The assertion shouldn't access player_control.next_song without locking it.
* | | player_thread: moved code to decoding_next_song()Max Kellermann2009-11-031-4/+15
| | | | | | | | | | | | Simplify several expressions.