Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | decoder/faad: remove workaround for ancient libfaad2 ABI bug | Max Kellermann | 2014-10-25 | 4 | -50/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround! | |||||
* | | | AllCommands: "commands" returns playlist commands only if playlist_directory ↵ | Max Kellermann | 2014-10-25 | 4 | -0/+25 | |
| | | | | | | | | | | | | configured | |||||
* | | | SongSticker, playlist/soundcloud: add missing stdlib.h include | Max Kellermann | 2014-10-25 | 2 | -0/+2 | |
| | | | | | | | | | | | | For free(). | |||||
* | | | SongSticker: don't use GLib | Max Kellermann | 2014-10-25 | 2 | -6/+3 | |
| | | | ||||||
* | | | decoder/wavpack: don't use GLib | Max Kellermann | 2014-10-25 | 2 | -5/+3 | |
| | | | ||||||
* | | | playlist/SoundCloud: don't use GLib for string allocation | Max Kellermann | 2014-10-25 | 2 | -33/+31 | |
| | | | ||||||
* | | | Util/Alloc: add xstrcatdup(), replacing g_strconcat() | Max Kellermann | 2014-10-25 | 2 | -0/+82 | |
| | | | ||||||
* | | | Set pulseaudio channel map to WAVE-EX | Steven Newbury | 2014-10-25 | 2 | -1/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulseaudio expects clients to specify their channel-map if the default (ALSA) map does not route the audio to the expected speakers. Many Google results suggest dealing with this by re-routing the audio channels with the appropriate ALSA plugin, but this will then simply break any clients which expect the default ALSA mapping. Virtually all media files and codecs, certainly flac, dca, a52, and of course anything based on Microsoft's WAVEFORMAT_EXTENSIBLE specification, assume the layout in the table here: http://en.wikipedia.org/wiki/Surround_sound#Standard_speaker_channels Fortunately, pulseaudio directly addresses this with a built-in channel map for WAVE-EX which can be set automatically in the stream sample-spec. | |||||
* | | | configure.ac: prepare for 0.20 | Max Kellermann | 2014-10-25 | 2 | -3/+5 | |
|/ / | ||||||
* | | configure.ac: update VERSION_REVISION | Max Kellermann | 2014-10-25 | 1 | -1/+1 | |
| | | ||||||
* | | decoder/ffmpeg: recognize MIME type audio/aacp | Steven OBrien | 2014-10-25 | 2 | -0/+3 | |
| | | ||||||
* | | configure.ac: add storage plugin section to result | Max Kellermann | 2014-10-25 | 1 | -0/+4 | |
| | | ||||||
* | | configure.ac: show DSD in result | Max Kellermann | 2014-10-25 | 1 | -0/+1 | |
| | | ||||||
* | | configure.ac: require xmlto for --enable-documentation | Max Kellermann | 2014-10-25 | 2 | -11/+4 | |
| | | ||||||
* | | test/test_archive: don't use GLib | Max Kellermann | 2014-10-25 | 1 | -8/+6 | |
| | | ||||||
* | | fs/Charset: work around clang's -Wunused-const-variable | Max Kellermann | 2014-10-25 | 1 | -1/+2 | |
| | | | | | | | | MPD_PATH_MAX_UTF8 is only used by GLib-specific code currently. | |||||
* | | configure.ac: auto-disable plugins that require GLib when --disable-glib is used | Max Kellermann | 2014-10-24 | 2 | -0/+21 | |
| | | ||||||
* | | configure.ac: improve database dependency checks | Max Kellermann | 2014-10-24 | 2 | -2/+15 | |
| | | | | | | | | | | Abort if --enable-libmpdclient or --enable-upnp are used with --disable-database, instead of ignoring the mismatch silently. | |||||
* | | test/DumpDatabase, ...: no g_thread_init() calls when GLib is disabled | Max Kellermann | 2014-10-24 | 3 | -0/+12 | |
| | | ||||||
* | | OutputThread: close the output plugin after filter failure | Max Kellermann | 2014-10-24 | 2 | -0/+3 | |
| | | | | | | | | Fixes memory leak because ao_plugin_close() never gets called. | |||||
* | | OutputThread: unlock mutex for CloseFilter() | Max Kellermann | 2014-10-24 | 2 | -0/+14 | |
| | | | | | | | | Be consistent. | |||||
* | | output/roar: remove unnecessary "volatile" keyword | Max Kellermann | 2014-10-23 | 1 | -1/+1 | |
| | | | | | | | | | | A mutex acts as a memory barrier, and thus "volatile" is not necessary. | |||||
* | | pcm/ChannelsConverter: fix variable used to generate error message | Max Kellermann | 2014-10-23 | 1 | -1/+1 | |
| | | | | | | | | | | Use the "_format" parameter instead of the (uninitialized) "format" attribute. | |||||
* | | pcm/FormatConverter: move check to Open() | Max Kellermann | 2014-10-23 | 1 | -10/+24 | |
| | | | | | | | | | | Report unsupported format while opening the filter, not later when the first conversion takes place. | |||||
* | | pcm/PcmConvert: assign {src,dest}_format at the end | Max Kellermann | 2014-10-23 | 2 | -12/+14 | |
| | | | | | | | | | | Fixes assertion failure in destructor by not assigning {src,dest}_format when an error occurs. | |||||
* | | pcm/PcmConvert: make AudioFormat parameters "const" | Max Kellermann | 2014-10-23 | 1 | -1/+1 | |
| | | ||||||
* | | configure.ac: prepare for 0.19.2 | Max Kellermann | 2014-10-23 | 2 | -1/+3 | |
| | | ||||||
* | | release v0.19.1 | Max Kellermann | 2014-10-19 | 2 | -3/+3 | |
| | | ||||||
* | | TextInputStream: manually shift the buffer before reading | Max Kellermann | 2014-10-19 | 2 | -0/+3 | |
| | | | | | | | | | | Fixes truncated lines in m3u and cue files (regression by commit 67958f7). | |||||
* | | util/StaticFifoBuffer: make Shift() public | Max Kellermann | 2014-10-19 | 1 | -2/+0 | |
| | | ||||||
* | | playlist/extm3u: strip first line for #EXTM3U detection | Max Kellermann | 2014-10-17 | 2 | -2/+8 | |
| | | ||||||
* | | Makefile.am: distribute systemd/mpd.socket | Max Kellermann | 2014-10-12 | 2 | -0/+2 | |
| | | | | | | | | | | The file systemd/mpd.service.in is being distributed implicitly, but systemd/mpd.socket is not and needs to be added to EXTRA_DIST. | |||||
* | | ThreadInputStream: call ThreadRead() inside the thread instead of Read() | Max Kellermann | 2014-10-11 | 2 | -1/+3 | |
| | | | | | | | | Fixes deadlock bug in the "mms" plugin. | |||||
* | | ThreadInputStream: add assertions | Max Kellermann | 2014-10-11 | 1 | -0/+8 | |
| | | ||||||
* | | NEWS: add missing line | Max Kellermann | 2014-10-11 | 1 | -0/+1 | |
| | | ||||||
* | | NEWS: fix typo in version number | Max Kellermann | 2014-10-11 | 1 | -1/+1 | |
| | | ||||||
* | | util/DynamicFifoBuffer: make the "Range" type public | Max Kellermann | 2014-10-11 | 1 | -0/+1 | |
| | | | | | | | | | | Export it from the protected base class. This fixes a build failure on Mac OS X. | |||||
* | | configure.ac: prepare for 0.19.1 | Max Kellermann | 2014-10-11 | 2 | -1/+3 | |
| | | ||||||
* | | release v0.19 | Max Kellermann | 2014-10-10 | 3 | -4/+4 | |
| | | ||||||
* | | doc: document the mount/neighbor commands | Max Kellermann | 2014-10-10 | 3 | -1/+192 | |
| | | ||||||
* | | doc/protocol: add more markup | Max Kellermann | 2014-10-10 | 1 | -58/+71 | |
| | | ||||||
* | | db/upnp/Util: move caturl() to util/UriUtil.cxx | Max Kellermann | 2014-10-10 | 6 | -32/+39 | |
| | | ||||||
* | | event/IdleMonitor: remove redundant comment | Max Kellermann | 2014-10-10 | 1 | -2/+1 | |
| | | ||||||
* | | ZeroconfBonjour: use htons() instead of g_htons() | Max Kellermann | 2014-10-10 | 1 | -3/+3 | |
| | | ||||||
* | | TagString: implement fix_utf8() without GLib | Max Kellermann | 2014-10-10 | 1 | -22/+34 | |
| | | ||||||
* | | util/UTF8: add SequenceLengthUTF8() | Max Kellermann | 2014-10-10 | 2 | -0/+96 | |
| | | ||||||
* | | util/UTF8: new library | Max Kellermann | 2014-10-10 | 3 | -0/+340 | |
| | | ||||||
* | | TagString: return WritableBuffer<char> | Max Kellermann | 2014-10-10 | 3 | -24/+26 | |
| | | ||||||
* | | TagString: use strndup() for unterminated string | Max Kellermann | 2014-10-10 | 1 | -1/+1 | |
| | | | | | | | | Fixes buffer overflow bug. | |||||
* | | TagString: remove ISO-Latin-1 fallback | Max Kellermann | 2014-10-10 | 2 | -14/+2 | |
| | | | | | | | | | | | | | | | | MPD handles all strings in UTF-8 internally. Those decoders which read Latin-1 tags are supposed to implement the conversion, instead of passing Latin-1 to TagBuilder::AddItem(). FixTagString() is simply the wrong place to do that, and hard-coding Latin-1 is kind of arbitrary. |