aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * directory: remove "Mp3" referencesEric Wong2008-09-283-22/+22
| | | | | | | | | | MPD has supported more audio formats than just MP3 for over five years...
| * playlist: deleteASongFromPlaylist takes a const Song *Eric Wong2008-09-282-2/+2
| | | | | | | | We don't change the song pointer there, either.
| * songvec: songvec_delete takes a const Song pointerEric Wong2008-09-282-2/+2
| | | | | | | | We don't modify the Song when we delete it
| * directory: remove shortname arguments everywhereEric Wong2008-09-281-79/+40
| | | | | | | | | | | | It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
| * path: add mpd_basename() functionEric Wong2008-09-282-0/+20
| | | | | | | | | | | | | | This is like basename(3) but with predictable semantics independent of C library or build options used. This is also much more strict and does not account for trailing slashes (mpd should never deal with trailing slashes on internal functions).
| * directory.h: remove directory_sigChldHandler declEric Wong2008-09-281-2/+0
| | | | | | | | | | We no longer fork for directory updates, so we no longer have children to reap.
| * directory: replace DirectoryList with dirvecEric Wong2008-09-284-197/+175
| | | | | | | | | | Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
| * directory: remove unused CPP definesEric Wong2008-09-281-4/+0
| | | | | | | | We no longer for for updates
| * songvec_free => songvec_destroyEric Wong2008-09-283-3/+3
| | | | | | | | | | "free" implies the songvec structure itself is freed, which is not the case.
| * directory.c: kill unnecessary includesEric Wong2008-09-281-4/+0
| |
* | Merge branch 'mk/flac'Eric Wong2008-09-294-128/+131
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * mk/flac: flac: removed FlacData.chunk_length flac: merged flacSendChunk() into flac_common_write() flac: removed generic sample size support flac: added special functions for 8 and 32 bit flac: added optimized converter for 16 bit flac: use signed integers in flac_convert_stereo16() flac: moved code from flacWrite() to _flac_common.c flac: assume the buffer is empty in flacWrite() II
| * | flac: removed FlacData.chunk_lengthMax Kellermann2008-09-294-9/+3
| | | | | | | | | | | | | | | chunk_length can be converted to a local variable, because it is always reset to 0 after it was used.
| * | flac: merged flacSendChunk() into flac_common_write()Max Kellermann2008-09-291-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since flacSendChunk() is a trivial function and is only used in one location, move the code there. The advantage is that calling decoder_data() directly returns the decoder_command value, so we can eliminate one decoder_get_command() call. [ew: using the terser API in the main branch, it always eliminated the dc_intr()/dc_seek() call, but I agree that killing a camel, err.. camelCase function is a good thing]
| * | flac: removed generic sample size supportMax Kellermann2008-09-291-31/+27
| | | | | | | | | | | | | | | | | | | | | | | | Support for bit rates except 16 bits (and 8 bits on little endian) has always been broken. Since we added optimized functions for 8, 16, 24/32 bits, we can remove the generic flac_convert() function. Instead of removing it, convert it to a wrapper function for flac_convert_*().
| * | flac: added special functions for 8 and 32 bitMax Kellermann2008-09-291-0/+37
| | | | | | | | | | | | | | | Same optimization for 8 and 32 bit files, like the previous patch for 16 bit. Along the way, this patch adds 24 bit FLAC support!
| * | flac: added optimized converter for 16 bitMax Kellermann2008-09-291-0/+17
| | | | | | | | | | | | | | | | | | flac_convert_16() runs a lot faster than the generic (and quite buggy) function flac_convert(). flac_convert_16() is only used for non-stereo files, since there is already flac_convert_stereo16().
| * | flac: use signed integers in flac_convert_stereo16()Max Kellermann2008-09-291-6/+4
| | | | | | | | | | | | | | | | | | By mistake, I casted the sample value to uint16_t, which is wrong. This patch simplifies the code by using a int16_t pointer instead of casting to int16_t* every time.
| * | flac: moved code from flacWrite() to _flac_common.cMax Kellermann2008-09-294-120/+90
| | | | | | | | | | | | | | | | | | | | | There is still a lot of duplicated code in flac_plugin.c and oggflac_plugin.c. Move code from flac_plugin.c to _flac_common.c, and use the new function flac_common_write() also in oggflac_plugin.c, porting lots of optimizations over to it.
| * | flac: assume the buffer is empty in flacWrite() IIMax Kellermann2008-09-291-6/+2
| |/ | | | | | | | | The previous patch on this topic was incomplete: it still added data->chunk_length when calling flac_convert(). Remove this, too.
* | Merge branch 'mk/pcm'Eric Wong2008-09-291-18/+28
|\ \ | | | | | | | | | | | | | | | * mk/pcm: pcm_utils: added pcm_range() pcm_utils: added inline function pcm_dither()
| * | pcm_utils: added pcm_range()Max Kellermann2008-09-291-10/+18
| | | | | | | | | | | | | | | | | | | | | Make the code more readable by moving the range checks to pcm_range(). gcc does quite a good job at optimizing it: the resulting binary is exactly the same, although it contains a parametrized shift instead of hard-coded boundaries.
| * | pcm_utils: added inline function pcm_dither()Max Kellermann2008-09-291-8/+10
| |/ | | | | | | | | Merge some code into an inline function, so we can optimize it later only once.
* / command: don't clobber next list value when preparsingEric Wong2008-09-291-3/+6
|/ | | | | | | This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.
* directory: update playlist version if updatedEric Wong2008-09-281-1/+6
| | | | | | | | | | | | If we updated the mpd metadata database; then there's a chance some of those songs in the playlist will have updated metadata. So be on the safe side and increment the playlist version number if _any_ song changed (this is how all released versions of mpd did it, too). This bug was introduced recently when making "update" threaded. Thanks to stonecrest for the bug report.
* playlist: fix currentsong info after swapping songsEric Wong2008-09-281-0/+4
| | | | | | | | | | We forgot to update the playlist.queued marker if playlist.current changed. Additionally, if the queue cleared in any other mode, attempt to requeue (as it's a harmless no-op otherwise). Thanks to stonecrest for the bug report.
* playlist: reset after we've hit the endEric Wong2008-09-281-0/+6
| | | | | If repeat is off, we reset (and reshuffle in random mode) the playlist.
* advance to the next song on decoder errorsEric Wong2008-09-283-6/+17
| | | | | | Fix this regression introduced in the core rewrite so that we now skip to the next song when we encounter an error with the song we tried to decode.
* COMMANDS: assorted formatting fixesEric Wong2008-09-271-21/+22
| | | | | | * spaces => tabs * long lines wrapped * trailing whitespace killed
* COMMANDS: document moveid with negative _to_ argument, tooEric Wong2008-09-271-1/+3
|
* COMMANDS: document addid with optional position argumentEric Wong2008-09-271-1/+4
|
* song: removed type SongListMax Kellermann2008-09-264-45/+2
| | | | SongList has been superseded by struct songvec.
* doc/COMMANDS: document "addid"Max Kellermann2008-09-261-0/+8
|
* command: fix command "addid"Max Kellermann2008-09-261-1/+1
| | | | | | With patch 8d2830b3, I broke "addid": it did not return the id of the new song, because of a typo in the return condition (== instead of !=).
* properly configure the M4 macro directoryMax Kellermann2008-09-262-0/+2
| | | | | Add information about the M4 macro dir ./m4/ to both configure.ac and Makefile.am.
* Revert "directory: serialize freeSong() within the main thread"Eric Wong2008-09-231-9/+1
| | | | | | | | This reverts commit efefaee1f9535012be2fbfea8f0f870904daad5d. Conflicts: src/directory.c
* songvec: avoid free(NULL)Eric Wong2008-09-231-2/+4
| | | | Potentially broken free() implementations don't like it
* directory: use songvec_free to prevent memory leaks.Eric Wong2008-09-231-2/+1
|
* directory: fix leak introduced with threaded updateEric Wong2008-09-231-1/+1
| | | | | Use freeList() instead of free() to free all elements in the list.
* directory: serialize freeSong() within the main threadEric Wong2008-09-231-1/+10
| | | | | | | | | | | | | | | | | | It's possible the playlist will be accessing a song that is to be freed in the update thread. Rather than going through the complexity (and potential to make mistakes) of locking the playlist (as well as losing CPU cycles/pipelining due to barriers with mutexes), we'll just line up all songs to be freed in the main thread. It's relatively uncommon to call freeSong() heavily (as it is to update); so the extra, temporary memory usage won't be very noticeable. Additionally, if a song is renamed and it contains unique tag item; this has the additional side effect of preventing unnecessary fragmentation where an item is freed and shortly reallocated.
* log: remove umask() calls, just change open(2) argsEric Wong2008-09-221-8/+2
| | | | The umask calls were remants of when we used fopen().
* Remove EINTR checking for open(2)Eric Wong2008-09-222-4/+2
| | | | open(2) should only interrupt on "slow" devices, afaik...
* directory: don't leak file handles if we get a corrupt dbEric Wong2008-09-221-1/+1
|
* Merge branch 'ew/directory'Eric Wong2008-09-228-221/+102
|\ | | | | | | | | | | | | * ew/directory: songvec: remove songvec_prune directory: update do its work inside a thread directory: use enum update_return for return values
| * songvec: remove songvec_pruneEric Wong2008-09-223-27/+0
| | | | | | | | | | | | Any pruned files will be noticed during update and pruned from the live database, so this inefficient function can go away and never come back.
| * directory: update do its work inside a threadEric Wong2008-09-225-125/+56
| | | | | | | | | | | | | | | | | | A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
| * directory: use enum update_return for return valuesEric Wong2008-09-221-72/+49
| | | | | | | | This way we avoid having to document -1, 0, 1
* | Merge branch 'ew/directory'Eric Wong2008-09-2016-253/+318
|\| | | | | | | | | | | | | | | | | | | * ew/directory: Don't try to prune unless we're updating workaround race condition on updates with broken signal blocking Replace SongList with struct songvec directory: remove unused updateMp3Directory() function start using prefixcmp() Add prefixcmp() (stol^H^H^H^Hborrowed from git)
| * Don't try to prune unless we're updatingEric Wong2008-09-201-1/+2
| | | | | | | | | | | | Pruning is very expensive and we won't need it in the future anyways. This brings startup back to previous speeds (before songvec changes).
| * workaround race condition on updates with broken signal blockingEric Wong2008-09-201-39/+50
| | | | | | | | | | | | | | | | | | pthreads with our existing signal blocking/handling is broken, for now just sleep a bit in the child to prevent the CHLD handler from being called too early. Also, improve error reporting when handling SIGCHLD by storing the status to be called in the main task (which can be logged, since we can't do logging inside the sig handler).
| * Replace SongList with struct songvecEric Wong2008-09-208-136/+226
| | | | | | | | | | | | | | Our linked-list implementation is wasteful and the SongList isn't modified enough to benefit from being a linked list. So use a more compact array of song pointers which saves ~200K on a library with ~9K songs (on x86-32).
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-30 21:48:12 +0000