aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* music_buffer: poison unallocated chunksMax Kellermann2009-03-091-0/+5
| | | | | When a music chunk is freed (returned to the buffer), poison its memory.
* poison: added valgrind supportMax Kellermann2009-03-092-0/+15
| | | | | | If the header valgrind/memcheck.h is available, add VALGRIND_MAKE_MEM_NOACCESS() and VALGRIND_MAKE_MEM_UNDEFINED() support, which enables nice warnings in the valgrind memory checker.
* added memory poisoning libraryMax Kellermann2009-03-092-0/+62
| | | | | Memory poisoning is useful for marking memory regions as "undefined". This poisoning only enabled in the debug build (!NDEBUG).
* output_thread: wait 10 seconds before reopening after play failureMax Kellermann2009-03-092-0/+5
| | | | | | This is similar to the MPD 0.14 patch "wait 10 seconds before reopening a failed device", which only covered open() failures. This patch adds the same feature for play().
* Fix remove-flac-song-on-every-updateJochen Keil2009-03-091-7/+7
| | | | | | | Until now every flac file got removed unconditionally (and then re-added) whenever the update command was issued. Now there is a check if we need to that, so the file will only be removed if there is a embedded cuesheet in that file
* Initial support for embedded cue sheets found in flac filesJochen Keil2009-03-094-7/+464
| | | | | | | | | So far only seekpoints are supported, so no proper tagging yet except for track number and track length. Tagging should be done by parsing the cue sheet which is often embedded as vorbis comment in flac files. Furthermore the pathname should be configurable like "%A - %t - %T", where %A means Artist, %t track number and %T Title or so.
* decoder_plugin: added method container_scan()Jochen Keil2009-03-095-20/+136
| | | | | [mk: fixed whitespace errors; use delete_song() instead of songvec_delete()]
* music_chunk: added assertions on the audio formatMax Kellermann2009-03-085-0/+89
| | | | | | | In !NDEBUG, remember which audio_format is stored in every chunk and every pipe. Check the audio_format of every new data block appended to the music_chunk, and the format of every new chunk appended to the music_pipe.
* output_thread: print "closed" debug messageMax Kellermann2009-03-081-0/+2
|
* alsa: determine buffer_time if not already knownMax Kellermann2009-03-081-0/+5
| | | | | | This patch fixes a theoretical (but practically impossible) flaw: the variable "buffer_time" may be uninitialized when it is used. Initialize the variable with snd_pcm_hw_params_get_buffer_time().
* alsa: better period_time default value for high sample ratesMax Kellermann2009-03-082-3/+9
| | | | | | | | | | | | | | | | | | The default values for buffer_time and period_time were both capped by the hardware limits on practically all chips. The result was a period_time which was half as big as the buffer_time. On some chips, this led to lots of underruns when using a high sample rate (192 kHz), because MPD had very little time to send new samples to ALSA. A period time which is one fourth of the buffer time turned out to be much better. If no period_time is configured, see how much buffer_time the hardware accepts, and try to configure one fourth of it as period_time, instead of hard-coding the default period_time value. This is yet another attempt to provide a solution which is valid for all sound chips. Using the SND_PCM_NONBLOCK flag also seemed to solve the underruns, but put a lot more CPU load to MPD.
* output_all: fix boolean short circuit in update()Max Kellermann2009-03-071-2/+2
| | | | | | | Sometimes, audio_output_update() isn't called for the second device when the first one has succeeded. The patch "audio_output_all_update() returns bool" broke it, because the boolean evaluation ended after the first "true".
* player_thread: moved code to player_check_decoder_startup()Max Kellermann2009-03-071-40/+69
|
* configure.ac: fix --enable-bzip2 and --enable-iso9660 variable nameMax Kellermann2009-03-071-14/+14
| | | | Another "remove redundant explicit $enableval assignments" breakage.
* music_pipe: refuse to push empty chunksMax Kellermann2009-03-071-0/+4
| | | | Added two assertions.
* decoder_internal: don't push empty chunk into pipeMax Kellermann2009-03-071-1/+6
| | | | | | When the decoder chunk is empty in decoder_flush_chunk(), don't push it into the music pipe - return it to the music buffer instead. An empty chunk in the pipe wastes resources for no advantage.
* chunk: added music_chunk_is_empty()Max Kellermann2009-03-071-0/+6
|
* music_pipe: poison music_chunk.nextMax Kellermann2009-03-071-0/+5
| | | | | | The value of music_chunk.next is undefined for a chunk returned by music_pipe_shift(). For more pedantic debugging, poison the reference before returning the chunk.
* music_pipe: added music_pipe_peek()Max Kellermann2009-03-072-0/+13
| | | | | music_pipe_peek() is similar to music_pipe_shift(), but doesn't remove the chunk. This allows it to be used with a "const" music_pipe.
* output_all: audio_output_all_update() returns boolMax Kellermann2009-03-073-6/+19
| | | | | audio_output_all_update() returns true when there is at least open output device which is open.
* pulse_mixer: allow mpd to reconnect to the pulse mixerDavid Guibert2009-03-071-29/+24
| | | | | | | | | | | | | | | | | | | | | | | | | This patch follows the commit 21bb10f4b. >From Max Kellermann: > I removed the daemonization changes in main.c. Please explain why you > changed that. If you need it for some reason, make that a separate > patch with a good description of your rationale. > That's the biggest flaw of your code: it opens the mixer device in the > init() method, while the open() method is empty. When the pulse > daemon is not available (either during MPD startup or when it dies > while MPD runs), the plugin will not even attempt to reconnect to > pulse. Please move the code to the open() method, to make that work. I changed the daemonize call as the fork losts the connection to the pulse server. According to your remark, the init() method should be moved to the open() ones. With the modification, mpd is able to reconnect the pulse mixer after restarting the pulseaudio daemon. Signed-off-by: David Guibert <david.guibert@gmail.com> Signed-off-by: Max Kellermann <max@duempel.org>
* AUTHORS: added Romain Bignon, Rasmus SteinkeMax Kellermann2009-03-071-9/+17
| | | | | | Added two new team members. Updated the description of older contributors. Moved José Anarch and Patrik Weiskircher to "former developers".
* pulse_mixer: added missing copyright headerMax Kellermann2009-03-071-0/+18
|
* pulse_mixer: added GLib log domainMax Kellermann2009-03-071-14/+16
| | | | Shorten some log messages, let GLib add the "pulse_mixer" prefix.
* pulse: clean up includesMax Kellermann2009-03-071-2/+4
| | | | | Don't include output_api.h - this is not an output plugin. Added missing explicit conf.h and string.h includes.
* pulse mixerDavid Guibert2009-03-074-0/+295
| | | | | | | | | | | | | | | | | | | | This patch introduces the mixer for the pulse output. Technically speaking, the pulse index is needed to get or set the volume. You must define callback fonctions to get this index since the pulse output in mpd is done using the simpe api. The pulse simple api does not provide the index of the newly defined output. So callback fonctions are associated to the pulse context. The list of all the sink input is then retreived. Then we select the name of the mpd pulse output and control its volume by its associated index number. Signed-off-by: Patrice Linel <patnathanael@gmail.com> Signed-off-by: David Guibert <david.guibert@gmail.com> [mk: fixed whitespace errors and broke long lines; removed daemonization changes from main.c]
* mixer: check for init() failuresMax Kellermann2009-03-071-1/+1
| | | | | When the init() method of a mixer plugin fails, mixer_new() dereferences the NULL pointer.
* configure.ac: fix --enable-X variable namesMax Kellermann2009-03-071-6/+6
| | | | | The patch "remove redundant explicit $enableval assignments" broke several options with non-standard variable names.
* configure: global indention and trim line wc to 80 when practical.Avuton Olrich2009-03-061-70/+113
|
* configure: Move the faad stuff to m4/faad.m4Avuton Olrich2009-03-062-185/+191
|
* configure: No capitalization on beginning of help strings.Avuton Olrich2009-03-062-12/+12
| | | | | Most strings have no capitalization at the beinning, make all strings non-capital.
* configure: specify that faad2 prefix is optional in the help stringAvuton Olrich2009-03-061-1/+1
|
* configure: trim down the line length for the libOggFLAC help stringsAvuton Olrich2009-03-061-4/+16
|
* configure: trim down the line length for the faad help stringsAvuton Olrich2009-03-061-3/+15
|
* configure: trim down the line length for the zeroconf help stringAvuton Olrich2009-03-061-4/+10
|
* configure: trim down the line length for the lame argumentsAvuton Olrich2009-03-061-4/+16
|
* configure: trim down the Tremor AC_ARG_WITH() statementsAvuton Olrich2009-03-061-6/+19
|
* configure: Group libmad stuff together, rename --enable-mp3 --enable-madAvuton Olrich2009-03-061-17/+26
|
* configure: remove redundant explicit $enableval assignments.Avuton Olrich2009-03-061-68/+34
|
* curl: reverse GLIB_CHECK_VERSION()Max Kellermann2009-03-061-1/+1
| | | | | The GLIB_CHECK_VERSION() macro was used improperly, which broke build on GLib < 2.14. Add a "!" for negation.
* socket_util: check if IN6_IS_ADDR_V4MAPPED is definedMax Kellermann2009-03-061-2/+2
| | | | | On some systems, the macro IN6_IS_ADDR_V4MAPPED() is not available. Don't try to convert IPv6 to their IPV4 equivalents in this case.
* configure: remove duplicate LAME report, unify rest under SHOUTcast header.Avuton Olrich2009-03-051-14/+14
|
* configure: make all tests the same, when possible.Avuton Olrich2009-03-051-2/+2
|
* configure: Add 'Streaming Support' section to the configure display.Avuton Olrich2009-03-061-19/+22
| | | | | Add 'Streaming Support section to the configure display, clarify the text and unify with the rest of the display.
* configure: display the status of lastfm protocol supportAvuton Olrich2009-03-061-0/+6
|
* configure: Fix configure warning presented by lastfm radio.Avuton Olrich2009-03-051-1/+1
| | | | | The configure problem was: ./configure: line 6934: ,: command not found
* pipe: added music_buffer, rewrite music_pipeMax Kellermann2009-03-0615-401/+417
| | | | | | | | Turn the music_pipe into a simple music_chunk queue. The music_chunk allocation code is moved to music_buffer, and is now managed with a linked list instead of a ring buffer. Two separate music_pipe objects are used by the decoder for the "current" and the "next" song, which greatly simplifies the cross-fading code.
* music_pipe: added music_pipe_push()Max Kellermann2009-03-067-128/+197
| | | | | | | Added music_pipe_allocate(), music_pipe_push() and music_pipe_cancel(). Those functions allow the caller (decoder thread in this case) to do its own chunk management. The functions music_pipe_flush() and music_pipe_tag() can now be removed.
* playlist_control: fix requeue after seekMax Kellermann2009-03-061-3/+3
| | | | | | The queue update after a seek was wrong: the queued song is cleared by a successful seek. This caused queue/cross-fading problems after a seek.
* flac: explicitly check for STOP commandMax Kellermann2009-03-051-1/+2
| | | | | | After the decoder command was obtained, don't wait until libflac detects EOF (as a side effect), quit the decoder immediately. This check was missing completely.