aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* screen_browser: fix warning when lyrics screen is disabledMax Kellermann2008-10-081-0/+2
| | | | | A local variable was only used by the lyrics screen code. Put #ifdef around its declaration.
* wreadln: support wide charactersMax Kellermann2008-10-061-17/+190
| | | | | | | | | wreadln() didn't distinguish narrow from wide characters, which resulted in display corruption. This patch adds a lot of internal conversions between byte positions, screen positions and character position, which hopefully fixes all these bugs. Since these conversions are quite expensive, the code should be revised and optimized.
* wreadln: wait for complete multibyte sequence in wreadln_insert_byte()Max Kellermann2008-10-061-0/+54
| | | | | | | For multibyte input, we should use wget_wch(), but this function isn't supported properly on some platforms. Add a patch which completes a multibyte character with multiple non-blocking reads. We'll see how portable this hack is...
* wreadln: don't use cursor_move_right() in insert_byte()Max Kellermann2008-10-061-1/+4
| | | | | | After a byte has been inserted, move the cursor right by just one byte, not one character. The byte may have been the first one in a multibyte character.
* configure.ac: added option --disable-wideMax Kellermann2008-10-062-1/+37
| | | | | | The configure option "--disable-wide" disables wide character support. This simplifies lots of internal calculations and makes the ncmpc binary leaner.
* include ncursesw/ncurses.h if availableMax Kellermann2008-10-0615-9/+41
| | | | | When compiling with libncursesw, include <ncursesw/ncurses.h> instead of <ncurses.h> (if available).
* wreadln: optimize wreadln_delete_char() with memmove()Max Kellermann2008-10-061-3/+4
| | | | Let memmove() do the dirty work on overlapping buffers..
* wreadln: moved code to wreadln_delete()Max Kellermann2008-10-061-7/+16
| | | | | Remove some more clutter from wreadln() by merging the duplicate character deletion code to wreadln_delete_char().
* wreadln: return early from cursor movement functionsMax Kellermann2008-10-061-11/+13
| | | | Unclutter these functions by removing one indent level.
* wreadln: use unsigned integers and size_tMax Kellermann2008-10-062-15/+16
| | | | | Declare all screen position variables as "unsigned", and all buffer positions as "size_t". We don't need signed values.
* wreadln: use memcpy() for both casesMax Kellermann2008-10-061-11/+6
| | | | | | | | Use memcpy() even when the cursor is at the end. It copies only the trailing null terminator in this case. The constant "length" is declared here in preparation for the "wide character" patches.
* wreadln: use memmove() instead of an temporary bufferMax Kellermann2008-10-061-7/+2
| | | | | memmove() handles overlapping buffers well, we can use it to get room for the inserted character.
* wreadln: moved code to insert_byte()Max Kellermann2008-10-061-19/+25
| | | | Remove some clutter from wreadln(), isolate some code into a function.
* wreadln: static bufferMax Kellermann2008-10-061-18/+11
| | | | | | Since the buffer size is already known at compile time, don't do a second malloc() for it, declare it statically in struct wreadln. This way, it is going to be allocated on the stack.
* wreadln: added struct wreadlnMax Kellermann2008-10-061-94/+111
| | | | | Don't pass a dozen of parameters to all internal functions; pass a pointer to the wreadln struct instead.
* wreadln: removed parameter "x1"Max Kellermann2008-10-061-15/+11
| | | | | | | Several internal functions calculate the width of the input field by subtracting "x0" from "x1", although the width is already being passed to them. Eliminate the parameter "x1" in all functions, and use "width" instead.
* wreadln: convert public globals to local constantsMax Kellermann2008-10-063-15/+6
| | | | | Convert wrln_max_line_size and wrln_max_history_length to local constants. They have no real use outside of wreadln.c.
* wreadln: import screen_bell() from screen_utils.hMax Kellermann2008-10-061-3/+1
| | | | | Don't use "extern" outside of the headers, include the proper header instead.
* code style, indent with tabs XIIMax Kellermann2008-10-062-64/+61
| | | | Follow the same code style als MPD itself.
* removed my_wgetch(), switch to wgetch()Max Kellermann2008-10-066-24/+3
| | | | | There are no special cases left for my_wgetch() to handle. We can remove it and use the original wgetch() instead.
* disable ncurses raw modeMax Kellermann2008-10-064-30/+0
| | | | | We're better off doing our own signal handling, instead of switching ncurses to raw mode. Anyway, it was commented out and didn't work...
* wreadln: removed the disabled ncursesw codeMax Kellermann2008-10-061-384/+0
| | | | | The wide character version of wreadln() is currently a non-functional mess. Remove it for now, I will reimplement that later.
* screen: declare time constants as GTimeMax Kellermann2008-10-041-2/+2
| | | | | Variables which store integer seconds should be declared as GTime. This fixes a gcc warning.
* Do not include libgen.h, it is unneeded after commit 44ecb.Emanuele Giaquinta2008-10-042-8/+0
|
* use g_basename() instead of basename()Max Kellermann2008-10-041-1/+1
| | | | | Another occurence of the non-portable basename() wasn't converted to glib yet.
* store MPD_UPDATE_TIME as guintMax Kellermann2008-10-031-3/+3
| | | | | | The glib function g_timeout_add() wants the interval as guint in milliseconds. Store the update interval in this form, instead of having to multiply MPD_UPDATE_TIME with 1000.
* don't initialize sigaction struct twiceMax Kellermann2008-10-031-6/+3
| | | | | Don't reset sa_mask and sa_flags after every sigaction() call. Do it once.
* restart system call after SIGWINCHMax Kellermann2008-10-031-1/+1
| | | | | | Set option SA_RESTART for the SIGWINCH handler. The screen resizer function is called by the glib main loop anyway, no need to interrupt any random system call here.
* typo: ignore SIGPIPE instead of SIGWINCHMax Kellermann2008-10-031-2/+2
| | | | | | | Somehow the "ignore SIGPIPE" patch had a fatal typo: instead of ignoring SIGPIPE, it ignored SIGWINCH. Somehow ncurses managed to hide the bug's symptoms, but a recent patch finally broke it. Repair the typo.
* screen: export the global variable "screen"Max Kellermann2008-10-0314-99/+85
| | | | | screen_t is a singleton. We do not have to pass it around everywhere. Export the one global variable.
* screen: don't pass mpdclient pointer to method paint()Max Kellermann2008-10-039-33/+32
| | | | | None of the paint() implementations acutally uses the mpdclient pointer. Remove it from the method signature.
* screen_play: remember playlistMax Kellermann2008-10-031-18/+20
| | | | | | | Remove the last paint() dependency on the mpdclient pointer: remember a pointer to the playlist object, and don't take it from mpdclient every time we paint. Also add the variable "current_song_id" which is calculated in update().
* screen: removed "painted" flagMax Kellermann2008-10-033-14/+10
| | | | Repaint immediately instead of setting "painted=0".
* removed KEY_RESIZEMax Kellermann2008-10-034-31/+0
| | | | | Since we are handling SIGWINCH, we do not need to handle KEY_RESIZE from ncurses. Remove it.
* screen_search: array index is tag idMax Kellermann2008-10-031-24/+19
| | | | | Save some bytes again: remove search_tag.id, make the array index equal to the tag id.
* don't import mpdclient_finish_command() twiceMax Kellermann2008-10-032-4/+0
| | | | | mpdclient_finish_command() is already imported by mpdclient.h, don't do it again in the sources.
* screen_search: removed the FUTURE macroMax Kellermann2008-10-031-11/+0
| | | | The future is now!
* options: don't initialize with memset(0)Max Kellermann2008-10-031-2/+0
| | | | | Global variables are already initialized with zero when the program starts, don't memset(0) again.
* options: don't pass the "options" pointer aroundMax Kellermann2008-10-035-55/+48
| | | | | Just make everybody use the global "options" variable. This eliminates namespace confusion and the NO_GLOBAL_OPTIONS hack.
* colors: make color support optional at compile timeMax Kellermann2008-10-038-0/+69
| | | | | Default is colors disabled. Those who love colorful terminals have the option to enable it with --enable-colors.
* options: print one big string in --version screenMax Kellermann2008-10-031-9/+9
| | | | | | Instead of calling printf() multiple times for every compile time option, build the whole string at compile time and print it with puts().
* colors: color id is the index of the "colors" arrayMax Kellermann2008-10-032-45/+25
| | | | | The color ids are sequential, and we can save some bytes if we use it for the array index.
* colors: added enum color_tMax Kellermann2008-10-032-17/+19
| | | | | Instead of declaring a bunch of CPP macros, use a C enum for identifying colors.
* code style, indent with tabs XIMax Kellermann2008-10-0319-921/+790
| | | | Follow the same code style als MPD itself.
* screen_artist: better screen titleMax Kellermann2008-10-031-7/+13
| | | | | | The artist screen shouldn't be marked "experimental" anymore. Describe the current state of the screen in the title, instead of always writing "Artist".
* list_window: remove list_window_state_tMax Kellermann2008-10-036-90/+78
| | | | | | | | We do not need to save a stack of list window states. When we return to a parent directory, we just have to find the directory which we come from in the parent list. Note that this patch resets the cursor when going to the root directory, but I think it's not that important, and I will deal with that later.
* filelist: added filelist_find_directory()Max Kellermann2008-10-032-0/+22
| | | | | The function filelist_find_directory() will be useful for the following patch.
* screen_artist: fix reload in "All tracks"Max Kellermann2008-10-031-7/+11
| | | | | | | The variable "album" was set to _("All tracks") when it was empty. When reloading the songs, ncmpc was trying to find an album named "All tracks", which didn't seem to work. Leave "album" in its canonical form and generate the title text on demand.
* charset: pass -1 instead of strlen()Max Kellermann2008-10-031-2/+2
| | | | | The GTK charset functions accept "-1" if the parameter is null terminated.
* support: removed unused function remove_trailing_slash()Max Kellermann2008-10-032-18/+0
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-23 08:06:04 +0000