| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
Threading has been disabled when I overhauled lyrics support. Remove
all libgthread checks from configure.ac.
|
|
|
|
|
| |
Instead of letting our caller poll lyrics_result(), call it back as
soon as we have the result.
|
|
|
|
|
| |
Instead of creating a thread for handling lyrics plugin data, register
a channel at the glib main loop.
|
|
|
|
|
|
| |
The variable current.song was never set, thus the cache did not work.
Don't reset it in screen_lyrics_clear() (which is called from
screen_lyrics_set()).
|
|
|
|
| |
Set the shell option "-e" to abort when one of the tools fails.
|
|
|
|
|
| |
Instead of checking for the sentinel at the end of the option table,
check the option_table_size constant.
|
|
|
|
| |
Make the options_table constant, since it is never modified.
|
|
|
|
|
|
| |
If prompt is NULL, do not add a second call to wreadln_masked() with a
literal string, but assign this literal string to the variable
"prompt". This saves several bytes in the compiled binary.
|
|
|
|
|
| |
The call to curs_set(0) in screen_read_password() was dead code,
because it was after the function return. Repair that.
|
|
|
|
| |
Store screen width and height as unsigned integer.
|
|
|
|
| |
Follow the same code style als MPD itself.
|
|
|
|
|
| |
Since screen.c has default code for CMD_SCREEN_UPDATE, return 0 from
the command handlers and let screen.c do the rest.
|
|
|
|
|
|
| |
Several screens ignore the attribute list_window->repaint. Don't set
it there. It will be replaced with a more intelligent repaint
algorithm later.
|
|
|
|
| |
The variable cur_action_id is not used at all.
|
|
|
|
|
| |
last_cmd stores the previous command sent to the screen. It is not a
timestamp, and its type should be command_t.
|
|
|
|
| |
Since the input_timestamp is only used by screen_play, move it there.
|
|
|
|
|
|
| |
Move the portion of screen_get_mouse_event() which handles list_window
clicks to list_window.c. The code contained a NULL pointer
dereference, which is now fixed.
|
|
|
|
|
| |
Moved basic libncurses initialization to ncu.c and ncu.h. Keep
generic code out of screen.c.
|
|
|
|
| |
Before terminating ncmpc, free the keyboard GIOChannel object.
|
|
|
|
|
| |
Provide program name and version in AC_INIT. Add the option
"dist-bzip2" to AM_INIT_AUTOMAKE.
|
|
|
|
|
| |
"welcome-screen-list" shows the screen list in the top row shortly
after startup, and is enabled by default.
|
|
|
|
|
| |
There are several places where browser.filelist can become NULL.
Catch that everywhere and generate an empty filelist in this case.
|
|
|
|
| |
Don't call filelist_get() with an invalid index.
|
|
|
|
| |
Check the function parameters.
|
|
|
|
|
| |
Don't try to call add_query() with no valid selection, this causes a
segfault. This usually happens when ncmpc isn't connected.
|
|
|
|
| |
Check if connection->sock is valid in mpd_executeCommand().
|
|
|
|
|
|
| |
connection->errorCode has an undefined value when connection->error is
not MPD_ERROR_ACK. Read it only if MPD_ERROR_ACK is set, to make
valgrind happy.
|
|
|
|
|
| |
During authentication, the message pointer was allocated, but never
freed. Allocate it only if it is really used (and freed).
|
|
|
|
| |
Follow the same code style als MPD itself.
|
|
|
|
|
| |
mpd_wait() must not be called when the socket is dead; add an
assertion there. In mpd_recv(), add a run-time check.
|
|
|
|
|
| |
If visible-bitrate is enabled, then the current bitrate will be drawn next
to the song time in the status bar. By default it will not be displayed.
|
|
|
|
|
| |
Adding some GNU readline-style binds. These are ^B/^F to move the cursor
back/forward, and ^N/^P to go to the next/previous line.
|
| |
|
|
|
|
|
|
|
| |
The previously bundled po/Makefile.in would use predefined variables that
should be set by the configure script. f.e., $prefix was defined as
/usr/local, and caused po files to always be installed there instead of in
the prefix given to ./configure.
|
|
|
|
|
| |
The configure help text already said the lyrics screen was disabled by
default. Now it actually will be.
|
| |
|
|
|
|
| |
The caller should decide how to display error messages.
|
|
|
|
|
| |
The "crop" command deletes all songs from the playlist, except the one
currently being played.
|
|
|
|
|
| |
Why redraw the help screen when nothing has changed? Redraw it only
after help_cmd(), and when explicitly requested (help_paint()).
|
|
|
|
|
|
|
| |
When I converted the filelist from GList to GPtrArray, I missed that
the GCompareFunc does not actually get the pointers from
g_ptr_array_sort(), but pointers to the pointers... run
g_ptr_array_sort_with_data() instead with a wrapper function.
|
|
|
|
|
| |
Somehow I forgot about changing free() to g_slice_free() in the
previous patch...
|
|
|
|
|
| |
In this case, slices are faster. Also fix a memory leak in
filelist_prepend() which I simply forgot about in the last patch set.
|
|
|
|
|
| |
Add information about the M4 macro dir ./m4/ to both configure.ac and
Makefile.am.
|
|
|
|
|
| |
Since we do a lot of indexed accesses to the filelist, a linked list
doesn't seem appropriate. Use GPtrArray instead.
|
|
|
|
|
| |
browser_get_selected() checks if there is a file list and a valid
selection, and returns the selected entry.
|
|
|
|
| |
Fix a memory leak: the concatened list was never freed.
|
|
|
|
| |
Avoid direct accesses to the filelist struct, provide an API for that.
|
|
|
|
|
| |
The separate filelist library does not depend on mpdclient, so the
prefix is superfluous.
|
|
|
|
|
| |
A song should not be twice in the browser. Simplify set_highlight()
by finding the entry with mpdclient_filelist_find_song().
|
|
|
|
|
| |
The caller must not pass NULL to set_highlight(). Replaced check with
assertion.
|