aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* songvec: sort songs by disc and track numberMax Kellermann2009-01-151-0/+46
| | | | | Sorting songs by file name does not make much sense. Most of the time, users want to add songs in track order to the playlist.
* tag: added tag_get_value()Max Kellermann2009-01-152-3/+16
|
* dirvec, songvec: sort using g_utf8_collate()Max Kellermann2009-01-152-2/+2
| | | | | | Path names in the directory and song structs are always encoded in UTF-8. Don't use strcmp(), it cannot handle UTF-8 characters properly. Use GLib's UTF-8 aware g_utf8_collate() function for that.
* shout: enlarge buffer size to 32 kBAntoine Beaupré2009-01-141-1/+1
| | | | | | | I was having problems with shoutcast stream outputs before applying the attached patch, which enlarges the shoutcast output buffer. Ideally, this should be configurable, but this resolves the issue for my needs.
* oggvorbis: use g_ascii_strncasecmp() instead of strncasecmp()Max Kellermann2009-01-141-3/+3
| | | | | Don't depend on the daemon's locale settings. Comment names are ASCII.
* oggvorbis: moved tag look into vorbis_parse_comment()Max Kellermann2009-01-141-23/+13
| | | | | | vorbis_parse_comment() should be a function which converts one comment to a tag item. It should do everything required to do the conversion, including looping over all possible tag types.
* oggvorbis: moved code to vorbis_copy_comment()Max Kellermann2009-01-141-9/+21
|
* oggvorbis: use vorbis_comment_value() in vorbis_parse_comment()Max Kellermann2009-01-141-5/+4
| | | | Eliminate some duplicate code.
* oggvorbis: always allocate a tag objectMax Kellermann2009-01-141-8/+14
| | | | | | Always allocate a new tag object before parsing the vorbis comments; free it when it turns out to be empty. This simplifies the code a bit.
* oggvorbis: no CamelCaseMax Kellermann2009-01-142-61/+65
| | | | Renamed functions and variables.
* oggvorbis: use boolMax Kellermann2009-01-141-5/+5
| | | | Make ogg_parseCommentAddToTag() return bool instead of unsigned int.
* tag_id3: added support for the "album artist" tagDaniele Sluijters2009-01-141-0/+12
| | | | Read the id3 tags "TPE2" and "TSO2" into the "album artist" tag.
* allow ~/.mpd/mpd.conf as alternate config fileJérôme Quelin2009-01-143-12/+20
| | | | | | | | | | | | mpd uses some additional files to work, such as pid_file, state_file, db_file, etc. when running mpd as non-root user, it is often that those files end in ~/.mpd in that case, we end up with 2 entries in a user's home, .mpdconf and .mpd - which clutters homedirs. this patch allows ~/.mpd/mpd.conf as an alternative to ~/.mpdconf, allowing for a cleaner homedir
* song_save: don't fail on empty tag valuesMax Kellermann2009-01-141-2/+2
| | | | | | If a tag value is an empty string, the space after the colon was removed by g_strchomp(). Fix this by removing the space check and using g_strchug() on the return value.
* song_save: return value pointer from matchesAnMpdTagItemKey()Max Kellermann2009-01-141-8/+8
| | | | | | | The matchesAnMpdTagItemKey() API becomes more powerful and flexible if the return value is the value pointer instead of a boolean. It also removes (invalid and dangerous) assumptions about the string from its caller.
* song_save: itemType is "enum tag_type", not "int"Max Kellermann2009-01-141-2/+2
|
* playlist: safely search the playlist for deleted songMax Kellermann2009-01-142-1/+8
| | | | | | | | When a song file is deleted during database update, all pointers to it must be removed from the playlist. The "for" loop in deleteASongFromPlaylist() did not deal with multiple copies of the deleted song properly, and left instances of the (to-be-invalidated) pointer in. Fix this by reversing the loop.
* tag: added core support for the "album artist" tagMax Kellermann2009-01-132-0/+2
| | | | | | | | Added TAG_ITEM_ALBUM_ARTIST. With this patch, MPD should be able to read the (inofficial) "ALBUMARTIST" Vorbis comment. Implementations in other decoder plugins will follow soon.
* song_save: check for colon and space when loading a tagMax Kellermann2009-01-131-2/+4
| | | | | | matchesAnMpdTagItemKey() broke when two tag items had the same prefix, because it did not check if the tag name ended after the prefix. Add a check for the colon and the space after the tag name.
* input_curl: honour http_proxy_* config directivesJoe Milbourn2009-01-132-0/+31
| | | | | | | | | | If http_proxy_{host, port, user, password} are provided in mpd.conf they are not passed on to libcurl. As a result mpd cannot stream from behind an http proxy. The attached patch `http_proxy.patch` makes the relevant calls to curl_easy_setopt(...) for all proxy configuration parameters, but is only tested for host and port.
* daemon: don't check the setsid() return valueMax Kellermann2009-01-131-3/+1
| | | | | There is only one valid error condition for setsid(): when the current process is already the process group leader. This is non-critical.
* daemon: don't fork twice to daemonizeMax Kellermann2009-01-131-8/+0
| | | | | To detach from the parent process, fork once and make the old process exit. No need to do that twice.
* playlist: implement Fisher-Yates shuffle properlyMax Kellermann2009-01-131-2/+2
| | | | | | | | MPD's shuffling algorithm was not implemented well: it considers songs which were already swapped, making it somewhat non-random. Fix the Fisher-Yates shuffle algorithm by passing the proper bounds to the PRNG.
* input_curl: use select() to eliminate busy loop during connectMax Kellermann2009-01-131-0/+6
| | | | | | | When decoder_run_song() (decoder_thread.c) waits for the input stream to become ready, it did that in a busy loop. Add a select() call to input_curl_buffer() during connect/handshake (i.e. before the first chunk of body data was received), to let the CPU relax.
* decoder_api: don't ignore DECODE_COMMAND_STOPMax Kellermann2009-01-131-2/+1
| | | | | | When the decoder thread is waiting for free chunks in the music pipe, don't ignore the STOP command. Just return dc.command without further checks.
* configure.ac: added the --enable-sqlite optionMax Kellermann2009-01-122-0/+16
| | | | | | MPD will (optionall) use sqlite databases in the future. Add a configure option to enable that. There is no code yet to really use sqlite, so the practical use of this patch is limited.
* Makefile.am: moved C/CPP/LDFLAGS upMax Kellermann2009-01-111-26/+26
|
* configure.ac: removed duplicate PKG_PROG_PKG_CONFIGMax Kellermann2009-01-111-2/+0
|
* removing mixer_reconfigure memmory leak, fixing configure of alsa and oss ↵Viliam Mateicka2009-01-115-9/+32
| | | | mixer (passing parameters)
* command: restore the "playlistinfo -1" behaviorMax Kellermann2009-01-111-0/+8
| | | | | If a range is "-1", display the whole list. This behavior is undocumented, but some clients rely on it.
* added valgrind suppressions fileMax Kellermann2009-01-101-0/+445
|
* main: remove "save_state" timer event on exitMax Kellermann2009-01-101-1/+4
|
* client: remove "expire" event on exitMax Kellermann2009-01-101-0/+3
|
* event_pipe: remove the GLib source from the main contextMax Kellermann2009-01-101-1/+5
| | | | Free memory before exiting.
* listen: remove the socket source from the main contextMax Kellermann2009-01-101-2/+5
| | | | Free memory before exiting.
* listen: added struct listen_socketMax Kellermann2009-01-101-16/+19
| | | | | Make the listen socket an object, allowing us to add more fields later. Convert listenSockets into a simple linked list.
* main: deinitialize main_notify on exitMax Kellermann2009-01-101-0/+1
|
* updated .gitignoreMax Kellermann2009-01-101-0/+3
|
* Introducing mixer apiViliam Mateicka2009-01-107-90/+186
| | | | | This patch tryes to introduce pluggable mixer (struct mixer_plugin) along with some basic infrastructure (mixer_* functions). Instance of mixer (struct mixer) is used in alsa and oss output plugin
* playlist: pass unsigned integers to playlistInfo()Max Kellermann2009-01-103-25/+42
| | | | | A song index cannot be negative. Also require the second parameter to be valid.
* playlist: exclude end of rangeMax Kellermann2009-01-102-2/+2
| | | | | In a range "start:end", "end" itself should not be included. Use the same semantics as other languages implementing ranges, e.g. Python.
* command: playlistinfo now uses a range argument rather than just a song idThomas Jansen2009-01-103-6/+12
| | | | | | | | | | | | | Loosely based on a patch provided by lesion in bug #1766. The playlistinfo command can now retrieve ranges of the playlist. The new argument indicates which entry is the last one that will be displayed. The number of displayed entries may be smaller than expected if the end of the playlist is reached. Previous usage: playlistinfo [start] New usage: playlistinfo [start[:end]]
* command: add a parser for range argumentsThomas Jansen2009-01-101-0/+48
| | | | | A range argument looks like start[:end] and is used to specify the entries of a list that should be returned (rather than the whole list).
* added missing explicit config.h includesMax Kellermann2009-01-0818-11/+19
|
* mapper: use directory_is_root() instead of isRootDirectory()Max Kellermann2009-01-081-3/+2
|
* path: include cleanupMax Kellermann2009-01-082-2/+0
|
* update: removed one more stack bufferMax Kellermann2009-01-081-4/+2
|
* path: allocate buffer in fs_charset conversion functionsMax Kellermann2009-01-086-46/+55
| | | | | Don't use fixed static buffers. GLib allocates a new string for us anyway, let's just return this one instead of copying it.
* update: include config.h, fix archive codeMax Kellermann2009-01-081-6/+9
| | | | | The archive code was disabled, because config.h was not included and thus ENABLE_ARCHIVE was not defined.
* mapper: re-add character set conversion in map_uri_fs()Stepan Pologov2009-01-081-0/+6
|