aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* playlist: reset after we've hit the endEric Wong2008-09-281-0/+6
| | | | | If repeat is off, we reset (and reshuffle in random mode) the playlist.
* advance to the next song on decoder errorsEric Wong2008-09-283-6/+17
| | | | | | Fix this regression introduced in the core rewrite so that we now skip to the next song when we encounter an error with the song we tried to decode.
* COMMANDS: assorted formatting fixesEric Wong2008-09-271-21/+22
| | | | | | * spaces => tabs * long lines wrapped * trailing whitespace killed
* COMMANDS: document moveid with negative _to_ argument, tooEric Wong2008-09-271-1/+3
|
* COMMANDS: document addid with optional position argumentEric Wong2008-09-271-1/+4
|
* song: removed type SongListMax Kellermann2008-09-264-45/+2
| | | | SongList has been superseded by struct songvec.
* doc/COMMANDS: document "addid"Max Kellermann2008-09-261-0/+8
|
* command: fix command "addid"Max Kellermann2008-09-261-1/+1
| | | | | | With patch 8d2830b3, I broke "addid": it did not return the id of the new song, because of a typo in the return condition (== instead of !=).
* properly configure the M4 macro directoryMax Kellermann2008-09-262-0/+2
| | | | | Add information about the M4 macro dir ./m4/ to both configure.ac and Makefile.am.
* Revert "directory: serialize freeSong() within the main thread"Eric Wong2008-09-231-9/+1
| | | | | | | | This reverts commit efefaee1f9535012be2fbfea8f0f870904daad5d. Conflicts: src/directory.c
* songvec: avoid free(NULL)Eric Wong2008-09-231-2/+4
| | | | Potentially broken free() implementations don't like it
* directory: use songvec_free to prevent memory leaks.Eric Wong2008-09-231-2/+1
|
* directory: fix leak introduced with threaded updateEric Wong2008-09-231-1/+1
| | | | | Use freeList() instead of free() to free all elements in the list.
* directory: serialize freeSong() within the main threadEric Wong2008-09-231-1/+10
| | | | | | | | | | | | | | | | | | It's possible the playlist will be accessing a song that is to be freed in the update thread. Rather than going through the complexity (and potential to make mistakes) of locking the playlist (as well as losing CPU cycles/pipelining due to barriers with mutexes), we'll just line up all songs to be freed in the main thread. It's relatively uncommon to call freeSong() heavily (as it is to update); so the extra, temporary memory usage won't be very noticeable. Additionally, if a song is renamed and it contains unique tag item; this has the additional side effect of preventing unnecessary fragmentation where an item is freed and shortly reallocated.
* log: remove umask() calls, just change open(2) argsEric Wong2008-09-221-8/+2
| | | | The umask calls were remants of when we used fopen().
* Remove EINTR checking for open(2)Eric Wong2008-09-222-4/+2
| | | | open(2) should only interrupt on "slow" devices, afaik...
* directory: don't leak file handles if we get a corrupt dbEric Wong2008-09-221-1/+1
|
* Merge branch 'ew/directory'Eric Wong2008-09-228-221/+102
|\ | | | | | | | | | | | | * ew/directory: songvec: remove songvec_prune directory: update do its work inside a thread directory: use enum update_return for return values
| * songvec: remove songvec_pruneEric Wong2008-09-223-27/+0
| | | | | | | | | | | | Any pruned files will be noticed during update and pruned from the live database, so this inefficient function can go away and never come back.
| * directory: update do its work inside a threadEric Wong2008-09-225-125/+56
| | | | | | | | | | | | | | | | | | A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
| * directory: use enum update_return for return valuesEric Wong2008-09-221-72/+49
| | | | | | | | This way we avoid having to document -1, 0, 1
* | Merge branch 'ew/directory'Eric Wong2008-09-2016-253/+318
|\| | | | | | | | | | | | | | | | | | | * ew/directory: Don't try to prune unless we're updating workaround race condition on updates with broken signal blocking Replace SongList with struct songvec directory: remove unused updateMp3Directory() function start using prefixcmp() Add prefixcmp() (stol^H^H^H^Hborrowed from git)
| * Don't try to prune unless we're updatingEric Wong2008-09-201-1/+2
| | | | | | | | | | | | Pruning is very expensive and we won't need it in the future anyways. This brings startup back to previous speeds (before songvec changes).
| * workaround race condition on updates with broken signal blockingEric Wong2008-09-201-39/+50
| | | | | | | | | | | | | | | | | | pthreads with our existing signal blocking/handling is broken, for now just sleep a bit in the child to prevent the CHLD handler from being called too early. Also, improve error reporting when handling SIGCHLD by storing the status to be called in the main task (which can be logged, since we can't do logging inside the sig handler).
| * Replace SongList with struct songvecEric Wong2008-09-208-136/+226
| | | | | | | | | | | | | | Our linked-list implementation is wasteful and the SongList isn't modified enough to benefit from being a linked list. So use a more compact array of song pointers which saves ~200K on a library with ~9K songs (on x86-32).
| * directory: remove unused updateMp3Directory() functionEric Wong2008-09-202-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | It hasn't been used in many years commit 3a89afdd80f228139554372a83a9d74486acf691 Author: Warren Dukes <warren.dukes@gmail.com> Date: Sat Nov 20 20:28:32 2004 +0000 remove --update-db option (SVN r2719)
| * start using prefixcmp()Eric Wong2008-09-208-58/+29
| | | | | | | | | | LOC reduction and less noise makes things easier for tired old folks to follow.
| * Add prefixcmp() (stol^H^H^H^Hborrowed from git)Eric Wong2008-09-202-0/+12
| | | | | | | | | | | | | | This allows us to avoid the nasty repetition in strncmp(foo, bar, strlen(foo)). We'll miss out on the compiler optimizing strlen() into sizeof() - 1 for string literals for this; but we don't use this it for performance-critical functions anyways...
* | Oops, open() with O_CREAT is nicer with a modeEric Wong2008-09-202-2/+2
| | | | | | | | Respect the user's umask (and the number of the beast!)
* | volume: oops, only #include <alloca.h> if OSS is enabledEric Wong2008-09-181-1/+0
| |
* | oss: avoid heap allocations when configuring mixerEric Wong2008-09-181-13/+13
|/ | | | Noticed-by: Courtney Cavin
* Move away from fprintf() when writing DB/state_fileEric Wong2008-09-1810-55/+60
| | | | | | | | | I have serious trust issues when using stdio to write to the FS. So it's best to clean this code out so I can start figuring out what's wrong with Rasi's box not updating... None of these writes take place in a performance-critical setting anyways...
* fdprintf and vfdprintf get error handlingEric Wong2008-09-182-14/+22
|
* Directory: don't allocate stat information dynamicallyEric Wong2008-09-182-50/+22
| | | | | | | This should save a few thousand ops. Not worth it to malloc for such a small (3-words on 32-bit ARM and x86) structures. Signed-off-by: Eric Wong <normalperson@yhbt.net>
* mp3: fix long line, I can't read past 80 colsEric Wong2008-09-171-1/+2
|
* mp3: fix buffer overflow when max_frames is too largeMax Kellermann2008-09-171-0/+5
| | | | | | | The function decodeFirstFrame() allocates memory based on data from the mp3 header. This can make the buffer size allocation overflow, or lead to a DoS attack with a very large buffer. Cap this buffer at 8 million frames, which should really be enough for reasonable files.
* client: check expired after client_process_line()Max Kellermann2008-09-171-1/+2
| | | | | | The assertion on "!client_is_expired(client)" was wrong, because writing the command response may cause the client to become expired. Replace that assertion with a check.
* mp4: fix potential integer overflow bug in the mp4_decode() functionTerry2008-09-121-0/+7
| | | | | | | | | | A crafted mp4 file could cause an integer overflow in mp4_decode function in src/inputPlugins/mp4_plugin.c. mp4ff_num_samples() function returns some tainted value. sizeof(float) * numSamples is an integer overflow operation if numSamples is too huge, so xmalloc will allocate a small memory region. I constructe a mp4 file, and use faad2 to open the file. mp4ff_num_samples() returns -1. So I think mpd bears from the same problem.
* Merge branch 'mk/client-merge'Eric Wong2008-09-1227-1363/+1981
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * mk/client-merge: (49 commits) client: shorten names of the struct client variables client: simplified client_read() client: client_input_received() returns 0 client: check for COMMAND_RETURN_CLOSE client: renamed local variable "selret" to "ret" client: moved CLOSE/KILL check after client_process_line() client: don't check FD_ISSET(client->fd) on expired client client: removed assert(client->fd)>=0 fix -Wcast-qual -Wwrite-strings warnings playlist: return -1 after assert(0) command: concatenate strings at compile time audio: don't pass "fd" to {en,dis}ableAudioDevice() volume: don't pass "fd" to changeVolumeLevel() directory: printDirectoryInfo() does not call commandError() directory: don't pass fd to traverseAllIn() directory: don't pass fd to traverseAllIn() callbacks playlist: PlaylistInfo() does not call commandError() playlist: don't pass "fd" to storedPlaylist.c functions playlist: don't pass "fd" to playlist.c functions playlist: showPlaylist() and shufflePlaylist() cannot fail ...
| * client: shorten names of the struct client variablesEric Wong2008-09-121-210/+209
| | | | | | | | | | | | | | | | | | Seeing the token "client" repeatedly in the same blocks of code adds to mental fatigue and makes it harder to follow code because there's fewer unique tokens to distinguish. "cl" is unique within mpd and conveys enough information to be useful to anybody reading the code.
| * client: simplified client_read()Max Kellermann2008-09-101-3/+5
| | | | | | | | Remove one comparison by changing branch order.
| * client: client_input_received() returns 0Max Kellermann2008-09-101-4/+2
| | | | | | | | | | | | | | | | | | Since the caller chain doesn't care about the return value (except for COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is nothing special. This saves one local variable initialization, and one access to it. Also remove one unreachable "return 1" from client_read().
| * client: check for COMMAND_RETURN_CLOSEMax Kellermann2008-09-101-15/+14
| | | | | | | | | | | | | | Don't close the client within client_process_line(), return COMMAND_RETURN_CLOSE instead. This is the signal for the caller chain to actually close it. This makes dealing with the client pointer a lot safer, since the caller always knows whether it is still valid.
| * client: renamed local variable "selret" to "ret"Max Kellermann2008-09-101-4/+5
| | | | | | | | It's easier to reuse the variable if it has a more generic name.
| * client: moved CLOSE/KILL check after client_process_line()Max Kellermann2008-09-101-4/+3
| | | | | | | | Don't update client data if it is going to be closed anyway.
| * client: don't check FD_ISSET(client->fd) on expired clientMax Kellermann2008-09-091-1/+2
| | | | | | | | | | client->fd becomes -1 when the client expires. Don't use FD_ISSET() with this expired client; doing so would cause a crash due to SIGBUS.
| * client: removed assert(client->fd)>=0Max Kellermann2008-09-091-4/+2
| | | | | | | | | | | | Since client->fd==-1 has become our "expired" flag, it may already be -1 when client_close() is called. Don't assert that it is still non-negative, and call client_set_expired() instead.
| * Merge branch 'mk/client'Eric Wong2008-09-099-813/+1292
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * mk/client: (24 commits) client: reorder function declarations client: check "expired" after command execution client: added global "expired" flag client: removed superfluous assertion client: more assertions client: moved code to sockaddr_to_tmp_string() client: replace "expired" flag with fd==-1 client: moved "expired" accesses into inline function client: no while loop in client_manager_io() client: select() errors are fatal client: use client_defer_output() in client_write() client: moved code to client_write() client: client_defer_output() can create the first defer buffer client: return early on error in client_defer_output() client: moved code to client_defer_output() client: don't free client resources except in client_close() client: allocate clients dynamically client: added function client_by_fd() client: return early in client_new() client: renamed all public functions ...
| | * client: reorder function declarationsMax Kellermann2008-09-011-3/+4
| | | | | | | | | | | | | | | Change the order of function declarations in client.h, to make it well arranged and readable.
| | * client: check "expired" after command executionMax Kellermann2008-09-011-7/+14
| | | | | | | | | | | | | | | | | | The old code tried to write a response to the client, without even checking if it was already closed. Now that we have added more assertions, these may fail... perform the "expired" check earlier.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-28 20:05:57 +0000