| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
libmikmod seems to be unmaintained, and has several critical bugs
which make MPD crash.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461519
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=476339
Disable the plugin by default to minimize harm. Users should
explicitly enable the mikmod decoder (--enable-mod) if they wish to
have it anyway.
|
|
|
|
|
|
|
|
| |
It is illegal to pass an empty audio buffer around. pcm_resample()
sometimes seems to result in 0 samples, maybe related to
libsamplerate. To work around that problem, add special checks after
both pcm_convert() invocations. Removed the pcm_resample()==0 checks
from pcm_convert().
|
|
|
|
|
|
|
|
|
|
|
| |
When a response is very long (e.g. a large playlist > 100k songs),
most of it will end up in the deferred buffers. Filling the deferred
queue is very expensive currently, because a new buffer is allocated
for every client_write() operation. This may lead to long delays, and
the client might give up and disconnect meanwhile. This patch makes
MPD attempt to flush the deferred queue as often as possible, to work
around this problem. Due to the MPD 0.14 code freeze, we should not
optimize the buffering code now.
|
| |
|
|
|
|
| |
Move the AC_OUTPUT below the checks. So you nicely see what goes wrong.
|
|\ |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
Conflicts:
doc/mpdconf.example
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| | |
Over time mpdconf has evolved and has been maintained and contributed to by many different folks at different
times. Try to give it some unity. Attempt to clear up some language and make things crystal clear. Add more
examples. Use tabs when it makes sense. Make better borders. Remove obsolete options. Try to put more defaults
when it makes sense.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
The "user" option does not work if MPD is started by an unprivileged
user.
|
|/
|
|
|
|
| |
Make "secure" a log level different from "default". "secure" should be
right between "default" and "verbose". Map "default" to Glib's
"MESSAGE" log level.
|
| |
|
|
|
|
|
| |
If lame was not available, the shout_mp3 plugin was enabled anyway,
and triggered compiler errors.
|
|
|
|
|
| |
First check if an ecoder plugin is available, then determine whether
to enable the shout output plugin.
|
| |
|
|
|
|
|
|
| |
getPlayerErrorStr() assumes that pc.errored_song is set when an error
occured. Since the song may have been deleted meanwhile, add a NULL
check.
|
|
|
|
|
| |
When a (remote) song is deleted from the playlist, there may still be
a reference to it in pc.errored_song. Clear this reference.
|
|
|
|
| |
least MIN(od->bufferSize, size) free bytes in the buffer. Thus MIN(od->bufferSize - od->len, size) is always equal to MIN(od->bufferSize, size).
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Additionally, add an example in mpdconf.example.
|
|
|
|
|
|
| |
When a client-specified URI has a scheme which is not supported, do
not try to open it as a local file, but provide a meaningful error
message.
|
|
|
|
|
| |
uri_has_scheme() checks if an URI contains the sub string "://", which
makes MPD assume that it is a remote URI.
|
|
|
|
|
| |
When a file had no file name extension, getSuffix() could return the
extension of the parent directory (if it had one).
|
|
|
|
|
| |
The old getSuffix() code was quite wasteful, and can be replaced
completely with strrchr().
|
|
|
|
| |
Use the C99 "bool" data type instead of "int".
|
|
|
|
|
| |
printRemoteUrlHandlers() cannot fail, and does not need a return
value.
|
|
|
|
|
| |
The function didn't do anything useful, it was just several lines
obfuscating that it was only forwarding isRemoteUrl()'s return value.
|
|
|
|
| |
ls.h does not need time.h, do not include it.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When updating from a version before libcurl was used for streaming
support, this is confusing - streaming will work with the old version
(e.g. 0.13.2) but will give "no such file" errors with the new due to
the missing dependency. However, the missing dependency will not be
obvious when running the configure script.
|
|
|
|
|
|
| |
The function strstrSearchTag() used g_utf8_casefold() to generate the
(pseudo-)lowercase version of the song's URL, but it never used the
variable.
|
|
|
|
|
|
|
|
| |
There have been bug reports on MPD regarding 24 bit output via
libao/esd. The "ao" plugin does not attempt fall back to 16 bit
currently, and thus fails to play 24 bit audio (i.e. all mp3 files).
Make it always use 16 bit samples for now, until more bits are
well-tested.
|
|
|
|
|
|
| |
The OS X output does not seem to support 24 bit audio in the way MPD
implements it currently. Fall back to 16 bit for now, and schedule
24 bit support on OS X for MPD 0.15.
|
|
|
|
|
| |
One my_usleep() invocation remains, until we find out if we can delete
it.
|
|
|
|
|
| |
Cast AudioBuffer.mData to a "unsigned char*" before adding "curpos".
This fixes a gcc warning.
|
|
|
|
|
| |
Variables which hold one of the DECODE_* values should be declared as
"enum mp3_action" instead of "int".
|
|
|
|
|
|
| |
MPD 0.13 and older followed all symbolic links. Although this can be
a security problem (as it has always been), 0.14 should offer the same
default behaviour as 0.13.
|
|
|
|
|
|
|
| |
libsamplerate produces cracks in the sound output when the destination
buffer is too small. This is the case when pcm_convert_size() rounds
down. Use ceil(x) instead of floor(0.5+x) there to prevent a buffer
overrun.
|
|
|
|
|
| |
On some systems, the time_t data type was not present, because
stored_playlist.h didn't include the time.h header directly.
|
| |
|