aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make mpd fetch the Original artist/performer tag from mp3'sQball Cow2007-02-231-0/+4
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5418 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* pcm_utils: fix libsamplerate compilation with non-C99 compilersEric Wong2007-02-191-4/+12
| | | | | | | | | | | | Mixing code and declarations is ugly, anyways. We could probably get away with using alloca(), but I'm not sure how good compiler support is for that, either. It's probably more supported than mixed declarations and code. Nevertheless; we'll trigger memory checkers on exit because we don't free the buffers; but we won't actually leak because we reuse those buffers (just like the non-SRC code path). git-svn-id: https://svn.musicpd.org/mpd/trunk@5397 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* More (v)snprintf-related buffer over-allocations removedEric Wong2007-02-193-4/+4
| | | | | Also took out an unnecessary memset in getPlayerErrorStr git-svn-id: https://svn.musicpd.org/mpd/trunk@5396 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* inputStream_http: cleanup GET request code (finishHTTPInit)Eric Wong2007-02-191-29/+29
| | | | | | | | | | | | | | | | | Avoid unnecessary memset to zero, snprintf always puts a trailing '\0'. We also have no need to subtract one from the buffer we're snprintf-ing it to. We also check the return value of snprintf to ensure it's not too long. I have a feeling we might as well avoid snprintf altogether so we don't have to worry about buffer sizing/stack overflow and just do a bunch of write(2)s, letting Nagle sort it out... Also, centralize some of the exit error handling in with goto. This makes the code a bit more consistent and maintainable as well as reducing code and binary size. git-svn-id: https://svn.musicpd.org/mpd/trunk@5395 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* inputStream_http: fix HTTP seekingEric Wong2007-02-191-1/+1
| | | | | | | | We need to identify ourselves as HTTP/1.1 so Range: works; and so the server can return HTTP/1.1 instead of HTTP/1.0. Tested against lighttpd 1.4.13 git-svn-id: https://svn.musicpd.org/mpd/trunk@5394 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Removing a global initialization to 0.J. Alexander Treuman2007-02-181-1/+1
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5378 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Closing some parenthesis around shank's email address in copyright headers.J. Alexander Treuman2007-02-187-7/+7
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5376 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Re-adding a fix to log.c that got pulled with the localization reversion.J. Alexander Treuman2007-02-181-5/+4
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5374 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Reverting all of my localization changes. It was a horribleJ. Alexander Treuman2007-02-188-171/+58
| | | | | | implementation, and fixing it is a big enough job that I don't know when I'll get around to it. Probably best just starting from scratch anyhow. git-svn-id: https://svn.musicpd.org/mpd/trunk@5373 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix for bug #1447Warren Dukes2007-02-181-6/+20
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5369 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Fixing some weird floating point comparison issue. Not exactly sure whyJ. Alexander Treuman2007-02-131-2/+3
| | | | | this fixes it though. git-svn-id: https://svn.musicpd.org/mpd/trunk@5338 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Tidying up libsamplerate documentation in the mpd.conf man page.J. Alexander Treuman2007-02-131-13/+17
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5335 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Tidying up libsamplerate example in mpdconf.example.J. Alexander Treuman2007-02-131-4/+5
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5333 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* #1) fix a few potential deadlock conditons in decode.c when crossfading is ↵Warren Dukes2007-02-113-9/+11
| | | | | | | enabled #2) fix a deadlock condition when attempting to seek if the decoder quit and returned to playerInit() git-svn-id: https://svn.musicpd.org/mpd/trunk@5325 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Fix a bug where mpd would complain about a proxy password being specifiedJ. Alexander Treuman2007-02-061-7/+7
| | | | | and not a proxy user even when both are specified. git-svn-id: https://svn.musicpd.org/mpd/trunk@5324 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Add libsamplerate support, old resampling is still an option, but this ↵Avuton Olrich2007-02-026-11/+156
| | | | | sounds much better for those who need it and don't want to use pulseaudio. Reviewed by shank/avuton. git-svn-id: https://svn.musicpd.org/mpd/trunk@5316 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* on second thought, comment out the debug statement so that users aren't ↵Warren Dukes2007-01-241-1/+1
| | | | | potentially flooded git-svn-id: https://svn.musicpd.org/mpd/trunk@5270 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* add debug statement for bug #1380Warren Dukes2007-01-241-0/+1
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5269 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Fix some error messages concerning _ao output driverQball Cow2007-01-211-2/+2
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5268 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* José Anarch: JACK updatesAvuton Olrich2007-01-201-40/+63
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5267 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Committing posix_fadvise(); normalperson/jat reviewed. Appears fine. Fixes ↵Avuton Olrich2007-01-191-0/+6
| | | | | bug #1428. git-svn-id: https://svn.musicpd.org/mpd/trunk@5265 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Call initLocalization() earlier so that errors, --version, etc. outputJ. Alexander Treuman2007-01-171-1/+1
| | | | | correctly. git-svn-id: https://svn.musicpd.org/mpd/trunk@5264 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* avahi: malloc => xmallocEric Wong2007-01-141-2/+3
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5262 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* sparse: move extern declarations for plugins into header filesEric Wong2007-01-144-19/+20
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5261 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* More sparse fixes now that we've re-enabled -Wmissing-prototypesEric Wong2007-01-142-7/+7
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5260 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* avahi: use #ifdef instead of #if because AVAHI may not be defined at allEric Wong2007-01-141-2/+2
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5259 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* flac: workaround for type inconsistency between new/old read callbackEric Wong2007-01-142-1/+3
| | | | | | size_t (1.1.3) makes a lot more sense, but older flac used unsigned here... git-svn-id: https://svn.musicpd.org/mpd/trunk@5258 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: fix type warning in error messageEric Wong2007-01-141-2/+2
| | | | | | | | just casting to int because it's the simplest (%z is not well-supported) Noticed-by: avuton on a 64-bit machine git-svn-id: https://svn.musicpd.org/mpd/trunk@5257 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* configure.ac: no longer drop MPD_CFLAGS if shout is enabledEric Wong2007-01-141-5/+3
| | | | | I'm an idiot for not noticing that :x git-svn-id: https://svn.musicpd.org/mpd/trunk@5256 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* configure.ac: get rid of scary message about OggFLAC with FLAC 1.1.3Eric Wong2007-01-141-3/+13
| | | | | | | We don't need to check for libOggFLAC with FLAC 1.1.3 because FLAC 1.1.3 can be recompiled to enable/disable OggFLAC support without recompiling mpd. git-svn-id: https://svn.musicpd.org/mpd/trunk@5255 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Don't initialize globals to zero (or NULL)Eric Wong2007-01-1434-206/+88
| | | | | | | | Some compilers and linkers aren't smart enough to optimize this, as global variables are implictly initialized to zero. As a result, binaries are a bit smaller as more goes in the .bss and less in the text section. git-svn-id: https://svn.musicpd.org/mpd/trunk@5254 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* flac/ogg/oggflac: keep old mime-types in addition to the new onesEric Wong2007-01-143-4/+15
| | | | | | We'll be dealing with legacy server configurations for a long time to come. git-svn-id: https://svn.musicpd.org/mpd/trunk@5253 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: fix double-free in finish routineEric Wong2007-01-141-3/+12
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5252 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: fix potential segfaults in parsing bad configs for 'ports'Eric Wong2007-01-141-5/+21
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5251 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: fix multiple segfaults when jackd hasn't been startedEric Wong2007-01-141-8/+17
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5250 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: strdup => xstrdup for error checkingEric Wong2007-01-141-4/+4
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5249 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* avahi: more sparse fixes (-Wshadow, non-ANSI declarations)Eric Wong2007-01-142-9/+9
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5248 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* jack: declare global variables as staticEric Wong2007-01-141-3/+3
| | | | | | | There's no reason they shouldn't be static. Additionally, output_ports doesn't need to be initialized to NULLs; that is (and has always been) implicit (for all global variables) git-svn-id: https://svn.musicpd.org/mpd/trunk@5247 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* mp3: sparse: fix warnings reported with -WshadowEric Wong2007-01-141-8/+7
| | | | | | sendDataToOutputBuffer returns an int (and always has), and using the existing 'ret' is fine in mp3Read(). git-svn-id: https://svn.musicpd.org/mpd/trunk@5246 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* localization: fix implicit declaration warnings (WARNING and strcmp)Eric Wong2007-01-141-0/+2
| | | | | just added the missing includes. git-svn-id: https://svn.musicpd.org/mpd/trunk@5245 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* flac: sparse: mismatched enum type for seekEric Wong2007-01-141-1/+1
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5244 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* zeroconf: avoid mixing declarations and codeEric Wong2007-01-141-15/+19
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5243 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* inputStream_http: stop mixing declarations with codeEric Wong2007-01-141-1/+3
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5242 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* flac: fix a stupid mistake newer preprocessors don't complain aboutEric Wong2007-01-141-2/+2
| | | | | FLAC__{seekable_,}_stream_decoder_new() takes no arguments git-svn-id: https://svn.musicpd.org/mpd/trunk@5241 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* configure.ac: shell portability fix (test -a)Eric Wong2007-01-141-4/+6
| | | | | | -a and -o flags for 'test' are not consistently supported across many platforms and not specified by POSIX git-svn-id: https://svn.musicpd.org/mpd/trunk@5240 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Added zeroconf service publishing using avahiJim Ramsay2007-01-1112-4/+692
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5238 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Remove a line of dead codeQball Cow2007-01-111-2/+1
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5235 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Output warning messages in the current locale's charset.J. Alexander Treuman2007-01-081-1/+4
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5229 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Fixed some silly logic that caused an extra \n to be printed when flushingJ. Alexander Treuman2007-01-081-5/+4
| | | | | warning messages. git-svn-id: https://svn.musicpd.org/mpd/trunk@5228 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Convert log messages sent to stdout to the current locale's charset.J. Alexander Treuman2007-01-085-11/+32
| | | git-svn-id: https://svn.musicpd.org/mpd/trunk@5227 09075e82-0dd4-0310-85a5-a0d7c8717e4f