| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Break the large function mp3_read() into smaller pieces.
|
|
|
|
| |
Break the large function mp3_read() into smaller pieces.
|
|
|
|
|
|
| |
dc_seek() won't send a SEEK command to the decoder thread unless the
stream is seekable. No need to do another check; convert that to an
assertion.
|
|
|
|
|
| |
need_chunks() returns a decoder_command enum. Store its return value
as this type.
|
|
|
|
|
| |
The function mp3_decode_first_frame() is too large. Move some code to
separate smaller functions.
|
|
|
|
| |
http://xkcd.com/292/
|
|
|
|
| |
This removes the need for util.h.
|
|
|
|
| |
Use the C99 bool data type for boolean values.
|
|
|
|
|
| |
Renamed all functions and variables. Also removed the mp3DecodeData
typedef.
|
| |
|
|
|
|
|
| |
Yet another superfluous buffering layer. input_file was using FILE*,
but we're better off with unbuffered I/O using open(), read(), ...
|
|
|
|
|
|
| |
size_t and long aren't 64 bit safe (i.e. files larger than 2 GB on a
32 bit OS). Use off_t instead, which is a 64 bit integer if compiled
with large file support.
|
|
|
|
| |
Remove duplicated code from MPD.
|
|
|
|
|
|
|
| |
When the decoder failed to start, the function do_play() returned,
still having pc.command==PLAY. This is because pc.command was reset
only when the decoder started up successfully. Add another
player_command_finished() call in the error handler.
|
|
|
|
|
| |
Don't attempt to open a HTTP URL as a local file, and don't send a
local path to libcurl.
|
|
|
|
|
| |
Due to a missing "test", the "xyes" token was interpreted as a
command.
|
|
|
|
| |
Don't compile the sources of disabled output plugins at all.
|
|
|
|
|
| |
On some systems, string.h declares basename(). This emits a shadow
warning. Change the variable name.
|
|
|
|
|
| |
If the server sends the headers "icy-name", "ice-name",
"x-audiocast-name", set the stream title.
|
| |
|
|
|
|
|
|
| |
Replaced the local variable "colon" (which had only temporary meaning)
with the variable "value". It is a pointer to the first byte of the
header value.
|
|
|
|
| |
g_free() allows passing the NULL pointer.
|
|
|
|
|
| |
For boolean values and success flags, use bool instead of integer (1/0
for true/false, 0/-1 for success/failure).
|
|
|
|
| |
close() shouldn't fail with read-only streams.
|
|
|
|
|
|
|
| |
Instead of managing a set of method pointers in each input_stream
struct, move these into the new input_plugin struct. Each
input_stream has only a pointer to the plugin struct. Pointers to all
implementations are kept in the array "input_plugins".
|
|
|
|
| |
Renamed all functions and variables.
|
|
|
|
| |
The global constructor is empty, and can be removed.
|
|
|
|
|
| |
The methods are only used in inputStream_fileOpen(), and should not be
exported.
|
|
|
|
| |
Everybody should use struct input_stream.
|
|
|
|
| |
Renamed inputStream.c and inputStream_file.c.
|
|
|
|
|
|
|
| |
MPD's HTTP client code has always been broken, no matter how effort
was put into fixing it. Replace it with libcurl, which is known to be
quite stable. This adds a fat library dependency, but only for people
who need streaming.
|
|
|
|
|
| |
The hook input_stream_global_finish() deinitializes global structures
of all input stream implementations.
|
|
|
|
| |
Cast playlist_max_length to off_t before comparing it to stat.st_size.
|
|
|
|
| |
check_bool() accepts only "0" or "1". The range check is superfluous.
|
|
|
|
| |
Again, no CamelCase in the directory name.
|
|
|
|
|
| |
These plugins are not input plugins, they are decoder plugins. No
CamelCase in the directory name.
|
|
|
|
|
|
|
| |
Several clients refuse to accept the protocol version "0.14~git",
because they think it is malformed. This is clearly a client bug, but
we cannot wait for all clients to fix this bug right now. For now,
change the version back to "0.14.0".
|
| |
|
|
|
|
| |
The file name "NEWS" is standardized.
|
|
|
|
|
|
|
| |
For testers, it should be clear that they're not using version 0.14.0
final, but an inofficial intermediate version from the git repository.
The protocol version is set to the same string, since the protocol is
subject to change during MPD development.
|
|
|
|
|
| |
Since we're not building the local mp4ff library anymore, we can
remove AC_PROG_LIBTOOL.
|
|
|
|
|
|
| |
MPD shouldn't integrate sources of other libraries. Since libmp4ff is
part of libfaad, we should remove the old copy from src/mp4ff and link
with the current version from libfaad instead.
|
|
|
|
|
|
|
|
|
| |
PA_SAMPLE_S16NE is the only sample format which is suported by both
MPD and pulseaudio. Unfortunately, pulse does not accept 24 bit
samples.
Instead of bailing out with an error message, we should tell the MPD
core to convert all samples to 16 bit for pulse.
|
|
|
|
|
| |
Eric is too busy with other projects and will remain inactive
indefinitely.
|
|
|
|
|
|
|
|
|
| |
This bug caused the audio output devices to stay open, although MPD
wasn't playing: quitDecode() resetted player_control.command, assuming
that the command was STOP. This way, player_task() didn't see the
CLOSE_AUDIO command, and the device was kept open.
Don't clear player_control.command in quitDecode().
|
|
|
|
| |
These are results from failed merges which I didn't notice.
|
|
|
|
|
|
| |
When the audio source provides 24 bit samples, don't bother to convert
(lossily) them to 16 bit before jack's floating point conversion - go
directly from 24 bit to float.
|
|
|
|
| |
Move sample format dependent code to a separate function.
|
|
|
|
|
| |
Renamed all variables and functions. Add the prefix "mpd_jack_" to
function names.
|
|
|
|
| |
We must never pass partial frames. Added assertions to debug this.
|